[PATCH v3] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

[PATCH v3] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

[hehuan1]

From: Huan He <hehuan1@eswincomputing.com>

The binding defines tuple-style reset-names items for some
compatibles, which implicitly enforces a fixed array length
via JSON Schema.

Defining global maxItems for resets and reset-names causes these
constraints to be intersected via allOf, resulting in an effective
minItems equal to the global maxItems. This leads to dtbs_check
failures reporting reset arrays as too short, even when the DTS
provides the correct number of entries.

Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
Signed-off-by: Huan He <hehuan1@eswincomputing.com>

---
Changes in v3:
  - Add minItems: 5 in 'else' branch for non-eswin,eic7700-dwcmshc
    compatibles

Changes in v2:
  - Keep the global maxItems constraints and add minItems: 4 for both
    resets and reset-names properties
  - Update commit message

- Link to v1: https://lore.kernel.org/all/20260211094736.88-1-hehuan1@eswincomputing.com/
---
 Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
index 7e7c55dc2440..5cebe5eb1efb 100644
--- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
@@ -50,9 +50,11 @@ properties:
     maxItems: 1
 
   resets:
+    minItems: 4
     maxItems: 5
 
   reset-names:
+    minItems: 4
     maxItems: 5
 
   rockchip,txclk-tapnum:
@@ -146,6 +148,7 @@ allOf:
     else:
       properties:
         resets:
+          minItems: 5
           maxItems: 5
         reset-names:
           items:
-- 
2.25.1

Re: [PATCH v3] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]

On Tue, Feb 24, 2026 at 05:23:37PM +0800, hehuan1@eswincomputing.com wrote:
> From: Huan He <hehuan1@eswincomputing.com>
> 
> The binding defines tuple-style reset-names items for some
> compatibles, which implicitly enforces a fixed array length
> via JSON Schema.
> 
> Defining global maxItems for resets and reset-names causes these
> constraints to be intersected via allOf, resulting in an effective
> minItems equal to the global maxItems. This leads to dtbs_check
> failures reporting reset arrays as too short, even when the DTS
> provides the correct number of entries.
> 
> Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
> Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>

Signoff chain looks wrong. You're author and submitter, what did
Pritesh do?
Content looks okay to me.

> 
> ---
> Changes in v3:
>   - Add minItems: 5 in 'else' branch for non-eswin,eic7700-dwcmshc
>     compatibles
> 
> Changes in v2:
>   - Keep the global maxItems constraints and add minItems: 4 for both
>     resets and reset-names properties
>   - Update commit message
> 
> - Link to v1: https://lore.kernel.org/all/20260211094736.88-1-hehuan1@eswincomputing.com/
> ---
>  Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 7e7c55dc2440..5cebe5eb1efb 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -50,9 +50,11 @@ properties:
>      maxItems: 1
>  
>    resets:
> +    minItems: 4
>      maxItems: 5
>  
>    reset-names:
> +    minItems: 4
>      maxItems: 5
>  
>    rockchip,txclk-tapnum:
> @@ -146,6 +148,7 @@ allOf:
>      else:
>        properties:
>          resets:
> +          minItems: 5
>            maxItems: 5
>          reset-names:
>            items:
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Re: [PATCH v3] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

[Huan He]

> > The binding defines tuple-style reset-names items for some
> > compatibles, which implicitly enforces a fixed array length
> > via JSON Schema.
> > 
> > Defining global maxItems for resets and reset-names causes these
> > constraints to be intersected via allOf, resulting in an effective
> > minItems equal to the global maxItems. This leads to dtbs_check
> > failures reporting reset arrays as too short, even when the DTS
> > provides the correct number of entries.
> > 
> > Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
> > Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
> > Signed-off-by: Huan He <hehuan1@eswincomputing.com>
> 
> Signoff chain looks wrong. You're author and submitter, what did
> Pritesh do?

Thank you very much for taking the time to review the patch and for your
valuable feedback.

Internally, Pritesh provided the initial version of this fix, and I have
made subsequent updates and refinements before submitting it to the
community.

Best regards,
Huan He

Re: Re: [PATCH v3] dt-bindings: mmc: dwcmshc-sdhci: Fix resets array validation

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Wed, Feb 25, 2026 at 11:24:29AM +0800, Huan He wrote:
> > > The binding defines tuple-style reset-names items for some
> > > compatibles, which implicitly enforces a fixed array length
> > > via JSON Schema.
> > > 
> > > Defining global maxItems for resets and reset-names causes these
> > > constraints to be intersected via allOf, resulting in an effective
> > > minItems equal to the global maxItems. This leads to dtbs_check
> > > failures reporting reset arrays as too short, even when the DTS
> > > provides the correct number of entries.
> > > 
> > > Fixes: 30009a21f257 ("dt-bindings: mmc: sdhci-of-dwcmshc: Add Eswin EIC7700")
> > > Signed-off-by: Pritesh Patel <pritesh.patel@einfochips.com>
> > > Signed-off-by: Huan He <hehuan1@eswincomputing.com>
> > 
> > Signoff chain looks wrong. You're author and submitter, what did
> > Pritesh do?
> 
> Thank you very much for taking the time to review the patch and for your
> valuable feedback.
> 
> Internally, Pritesh provided the initial version of this fix, and I have
> made subsequent updates and refinements before submitting it to the
> community.

Then you need to add a Co-developed-by tag for them in addition to the
Signed-off-by.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]