[PATCH] dt-bindings: intel: Add Agilex5 SoCFPGA modular board

[PATCH] dt-bindings: intel: Add Agilex5 SoCFPGA modular board

[Dinh Nguyen]

Add compatible for Agilex5 SoCFPGA modular board.

Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 712916b7447a..206686f3eebc 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -111,6 +111,7 @@ properties:
           - enum:
               - intel,socfpga-agilex5-socdk
               - intel,socfpga-agilex5-socdk-013b
+              - intel,socfpga-agilex5-socdk-modular
               - intel,socfpga-agilex5-socdk-nand
           - const: intel,socfpga-agilex5
 
-- 
2.42.0.411.g813d9a9188

Re: [PATCH] dt-bindings: intel: Add Agilex5 SoCFPGA modular board

[Krzysztof Kozlowski]

On Wed, Feb 25, 2026 at 11:21:45PM -0600, Dinh Nguyen wrote:
> Add compatible for Agilex5 SoCFPGA modular board.

Which is what?

And why do we want it? There is no user of it here or you forgot to
explain WHY you are doing things.

... and why you did not include my tags?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: intel: Add Agilex5 SoCFPGA modular board

[Dinh Nguyen]

On 2/26/26 02:20, Krzysztof Kozlowski wrote:
> On Wed, Feb 25, 2026 at 11:21:45PM -0600, Dinh Nguyen wrote:
>> Add compatible for Agilex5 SoCFPGA modular board.
> 
> Which is what?
> 
> And why do we want it? There is no user of it here or you forgot to
> explain WHY you are doing things.

This is for the socfpga_agilex5_socdk_modular.dts board. When I did the 
merge of the intel bindings into the altera file, somehow I left this 
binding out. [1]

> 
> ... and why you did not include my tags?
> 

I treated this patch as a new patch since the change is going into a 
different file so I didn't add your tag.

I will respin a v2 with a reason for this patch.

Thanks,

Dinh


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/commit/?h=socfpga_dts_for_v6.20_v3&id=1cb8486ac5f3adc0a4f38e8b59962c2314fc2ca5

Re: [PATCH] dt-bindings: intel: Add Agilex5 SoCFPGA modular board

[Krzysztof Kozlowski]

On 27/02/2026 12:51, Dinh Nguyen wrote:
> 
> 
> On 2/26/26 02:20, Krzysztof Kozlowski wrote:
>> On Wed, Feb 25, 2026 at 11:21:45PM -0600, Dinh Nguyen wrote:
>>> Add compatible for Agilex5 SoCFPGA modular board.
>>
>> Which is what?
>>
>> And why do we want it? There is no user of it here or you forgot to
>> explain WHY you are doing things.
> 
> This is for the socfpga_agilex5_socdk_modular.dts board. When I did the 
> merge of the intel bindings into the altera file, somehow I left this 
> binding out. [1]

This should be explained in the commit msg.

> 
>>
>> ... and why you did not include my tags?
>>
> 
> I treated this patch as a new patch since the change is going into a 
> different file so I didn't add your tag.
> 
> I will respin a v2 with a reason for this patch.

So this will be v3, because v1 was before and this is v2. Every time you
drop tags you must explain why in the changelog.

https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577



Best regards,
Krzysztof

Re: [PATCH] dt-bindings: intel: Add Agilex5 SoCFPGA modular board

[Krzysztof Kozlowski]

On 26/02/2026 06:21, Dinh Nguyen wrote:
> Add compatible for Agilex5 SoCFPGA modular board.
> 
> Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
>  Documentation/devicetree/bindings/arm/altera.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof