Re: [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88}

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

On Fri, Feb 27, 2026 at 08:38:13AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Feb 26, 2026 at 10:15:49PM +0000, Conor Dooley wrote:
> > > 
> > > 
> > > 	if (rkvdec->variant->has_single_reg_region) {
> > > 		rkvdec->regs = devm_platform_ioremap_resource(pdev, 0);
> > > 		if (IS_ERR(rkvdec->regs))
> > > 			return PTR_ERR(rkvdec->regs);
> > > 	} else {
> > > 		rkvdec->regs = devm_platform_ioremap_resource_byname(pdev, "function");
> > > 		if (IS_ERR(rkvdec->regs))
> > > 			return PTR_ERR(rkvdec->regs);
> > > 
> > > 		rkvdec->link = devm_platform_ioremap_resource_byname(pdev, "link");
> > > 		if (IS_ERR(rkvdec->link))
> > > 			return PTR_ERR(rkvdec->link);
> > > 	}
> > > 
> > > 
> > > Where for RK35xx variants, it only pick the resources by name. I don't see the
> > > bug that you see, but I believe this was just a supposition, that you didn't
> > > check the code.
> > 
> > Busy reading path of exile patch notes, so sniping this comment only...
> > 
> > This is a bug, not a supposition, and it's that snippet from the
> > driver that prompted my comment.. That code requires that if
> > ->has_single_reg_region is set that the dts provides reg-names, but the
> 
> No, the opposite. With has_single_reg_region you take first entry and
> ignore names.

Right, that's of course what I meant, I just a word ;)

> > binding does not mandate reg-names for rk3576-vdec and rk3588-vdec, so
> 
> Best regards,
> Krzysztof
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]