From: Monish Chunara <monish.chunara@oss.qualcomm.com>
To: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
dmitry.baryshkov@oss.qualcomm.com, mani@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sarthak.garg@oss.qualcomm.com,
pradeep.pragallapati@oss.qualcomm.com,
nitin.rawat@oss.qualcomm.com,
Monish Chunara <monish.chunara@oss.qualcomm.com>
Subject: [PATCH 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT
Date: Fri, 27 Feb 2026 16:20:53 +0530 [thread overview]
Message-ID: <20260227105055.2364348-2-monish.chunara@oss.qualcomm.com> (raw)
In-Reply-To: <20260227105055.2364348-1-monish.chunara@oss.qualcomm.com>
The Monaco SoC SDHC controller supports both eMMC and SD cards. However,
the 'supports-cqe' property (Command Queue Engine) is specific to eMMC
and conflicts with SD card operation.
Remove 'supports-cqe' from the SoC device tree to ensure compatibility
with SD cards. Simultaneously, add the property explicitly to the
qcs8300-ride board device tree, as this board uses the controller in
eMMC mode.
This ensures the SoC definition remains generic while enabling features
correctly at the board level.
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/monaco.dtsi | 1 -
arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index 5d2df4305d1c..680f0edf4356 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -4742,7 +4742,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
qcom,dll-config = <0x000f64ee>;
qcom,ddr-config = <0x80040868>;
- supports-cqe;
dma-coherent;
status = "disabled";
diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index c04e0ad53eec..b0bec20eed34 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -428,6 +428,7 @@ &sdhc_1 {
vmmc-supply = <&vreg_l8a>;
vqmmc-supply = <&vreg_s4a>;
+ supports-cqe;
non-removable;
no-sd;
no-sdio;
--
2.34.1
next prev parent reply other threads:[~2026-02-27 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 10:50 [PATCH 0/3] arm64: dts: qcom: monaco: Enable SDHCI storage support Monish Chunara
2026-02-27 10:50 ` Monish Chunara [this message]
2026-02-27 20:05 ` [PATCH 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT Dmitry Baryshkov
2026-02-27 10:50 ` [PATCH 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay Monish Chunara
2026-02-27 20:03 ` Dmitry Baryshkov
2026-03-02 14:24 ` Monish Chunara
2026-03-23 14:15 ` Konrad Dybcio
2026-06-16 12:30 ` Monish Chunara
2026-06-16 13:01 ` Konrad Dybcio
2026-02-27 10:50 ` [PATCH 3/3] arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC " Monish Chunara
2026-02-27 20:05 ` [PATCH 0/3] arm64: dts: qcom: monaco: Enable SDHCI storage support Dmitry Baryshkov
2026-03-02 14:37 ` Monish Chunara
2026-03-02 14:47 ` Dmitry Baryshkov
2026-03-02 15:05 ` Monish Chunara
2026-03-05 4:51 ` Dmitry Baryshkov
2026-06-16 12:32 ` Monish Chunara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227105055.2364348-2-monish.chunara@oss.qualcomm.com \
--to=monish.chunara@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=pradeep.pragallapati@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sarthak.garg@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox