Re: [PATCH v4 1/3] dt-bindings: reset: add sky1 reset controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sun, Mar 01, 2026 at 03:09:08PM +0800, Xueyuan Chen wrote:
> From: Gary Yang <gary.yang@cixtech.com>
> 
> There are two reset controllers on Cix sky1 Soc.
> One is located in S0 domain, and the other is located
> in S5 domain.
> 
> [Xueyuan Chen: Refactored to a flat syscon architecture to fix v3 review issues]
> 
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> Co-developed-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
> Signed-off-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
> ---
>  .../bindings/reset/cix,sky1-rst.yaml          |  51 ++++++
>  include/dt-bindings/reset/cix,sky1-rst-fch.h  |  42 +++++
>  include/dt-bindings/reset/cix,sky1-rst.h      | 164 ++++++++++++++++++
>  3 files changed, 257 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
>  create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
>  create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h
> 
> diff --git a/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> new file mode 100644
> index 000000000000..27b6df71c3e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/cix,sky1-rst.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CIX Sky1 Reset Register Region
> +
> +maintainers:
> +  - Gary Yang <gary.yang@cixtech.com>
> +  - Xueyuan Chen <xueyuan.chen21@gmail.com>
> +
> +description: |
> +  An assortment of registers that control elements of the CIX Sky1 SoC,
> +  including resets, clocks, among others.
> +  The Reset block acts as a system controller (syscon) and provides
> +  reset capabilities to various peripherals.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - cix,sky1-src-s5
> +          - cix,sky1-src-fch
> +      - const: syscon

I don't understand what is happening here.

Something VERY similar was sent as v9 and this is v4. Compatibles look
different, yet similar.

It looks like you just duplicated a lot bypassing 5 rounds of comments.

That would not be acceptable, we don't review just to be ignored.

Best regards,
Krzysztof