public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: ipq5332: Add the IMEM node
Date: Sun, 1 Mar 2026 12:28:04 +0100	[thread overview]
Message-ID: <20260301-tricky-fine-bonobo-da83c0@quoll> (raw)
In-Reply-To: <20260228-imem-v3-6-20fbcc1a9404@oss.qualcomm.com>

On Sat, Feb 28, 2026 at 06:38:05PM +0530, Kathiravan Thirumoorthy wrote:
> Add the IMEM node to the device tree to extract debugging information
> like system restart reason, which is populated via IMEM. Define the
> IMEM region to enable this functionality.
> 
> As described, overall IMEM region is 80KB but only initial 4KB is
> accessible by all masters in the SoC.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5332.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 45fc512a3bab221c0d99f819294abf63369987da..b5f87db419fe7c1cecd05b5a85745cc3971028e4 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -423,6 +423,17 @@ blsp1_spi2: spi@78b7000 {
>  			status = "disabled";
>  		};
>  
> +		sram@8600000 {
> +			compatible = "qcom,ipq5332-imem", "mmio-sram";
> +			reg = <0x08600000 0x14000>;
> +			ranges = <0 0x08600000 0x14000>;

Why?

> +
> +			no-memory-wc;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;

Why? You do not have any children.

Best regards,
Krzysztof


      reply	other threads:[~2026-03-01 11:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 13:07 [PATCH v3 0/6] Describe the IMEM present in Qualcomm IPQ SoC's Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 1/6] dt-bindings: sram: Describe the IMEM present in Qualcomm IPQ SoCs Kathiravan Thirumoorthy
2026-03-01 11:27   ` Krzysztof Kozlowski
2026-03-02 13:52     ` Konrad Dybcio
2026-03-02 13:56       ` Krzysztof Kozlowski
2026-03-02 14:10         ` Konrad Dybcio
2026-03-02 14:54           ` Krzysztof Kozlowski
2026-03-02 14:56             ` Konrad Dybcio
2026-03-02 16:33               ` Krzysztof Kozlowski
2026-03-03 10:48                 ` Konrad Dybcio
2026-03-04 11:16                   ` Kathiravan Thirumoorthy
2026-03-04 11:29                     ` Krzysztof Kozlowski
2026-03-04 11:38                       ` Konrad Dybcio
2026-03-04 11:44                         ` Krzysztof Kozlowski
2026-02-28 13:08 ` [PATCH v3 2/6] arm64: dts: qcom: ipq8074: Add the IMEM node Kathiravan Thirumoorthy
2026-03-01 11:29   ` Krzysztof Kozlowski
2026-02-28 13:08 ` [PATCH v3 3/6] arm64: dts: qcom: ipq6018: " Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 4/6] arm64: dts: qcom: ipq5018: " Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 5/6] arm64: dts: qcom: ipq9574: " Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 6/6] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2026-03-01 11:28   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260301-tricky-fine-bonobo-da83c0@quoll \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox