From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF3A4277035; Mon, 2 Mar 2026 18:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475909; cv=none; b=Fthlqc1ONbpVrjR39KbGiNAFxkY7LXoaRribRFJkwzP5x4xXbc7YdXQoa+pLgwX9Xvwj4bXDEfLAVI7gFpT88r6e7cR1vxl9ptLOS3DiYjMdE9/LS0cHsHZcD4jW7yKZxyo0LEwuQtgbmQXpm14I1feEJ/JxmqbWf3eu4lmbaA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772475909; c=relaxed/simple; bh=hqlQdJr+TwetXdWKctFYGt6ONv9TGR3xJA5uUdRsGnk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p1CvFCm0ELiqA1Q6UKQfaEm+dd2Szzu+r175TtU5RseoNAGG5HvxXBttE2TZsxyc8iofwkTxQSG7soIs1uUCfoCJ6qZOlchVoL656/LbNWxCRKrAJcSZCMXiXaZPQBCdfoZlLTR/udm4xB/aObRf9b0Ya//D+5vdlLgwEhK+dMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OGt9U3xD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OGt9U3xD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CB3BC19423; Mon, 2 Mar 2026 18:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772475909; bh=hqlQdJr+TwetXdWKctFYGt6ONv9TGR3xJA5uUdRsGnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OGt9U3xDvCQN6CIVGOex4BE7QHpNb61w5XBxlJUVPFtv9DuRJh78Oc7k+gpUqLZjU qjPwqRwzpsxc4wTLJUm7ClOBT5QwEd5bGBPURqbw1gjzecInQzic0mUtVfokZ0DnN4 5zgZSVRTn8d5KxjczSElpn8u8JVgqpCzLNAG21KEiPklO0HjEYpzv21i6h3ra2sZFj ldRKL0+SqlgUsDfjbOufYVgz7815DGm8Y/6HDWuPgOxris8tcTulN72Sqguji0/RnR +081cCM5HLlESx40P8S+1XzHGWUJyywyo+HwtkzJs2bX7htwpOnMcYApBxckdU/Swx GpfgsmaY3W+rw== Date: Mon, 2 Mar 2026 18:25:03 +0000 From: Conor Dooley To: Iker Pedrosa Cc: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Michael Opdenacker , Javier Martinez Canillas , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] dt-bindings: mmc: spacemit,sdhci: add AIB voltage switching registers Message-ID: <20260302-crewman-faster-9fd00b62e30c@spud> References: <20260302-orangepi-sd-card-uhs-v1-0-89c219973c0c@gmail.com> <20260302-orangepi-sd-card-uhs-v1-1-89c219973c0c@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iVG0vKrqfY2+UZi0" Content-Disposition: inline In-Reply-To: <20260302-orangepi-sd-card-uhs-v1-1-89c219973c0c@gmail.com> --iVG0vKrqfY2+UZi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 02, 2026 at 04:13:22PM +0100, Iker Pedrosa wrote: > Add SpacemiT K1 AIB register properties for UHS voltage switching > support: >=20 > - spacemit,aib-mmc1-io-reg: AIB MMC1 IO register address for voltage > switching > - spacemit,apbc-asfar-reg: APBC ASFAR register address for AIB access > - spacemit,apbc-assar-reg: APBC ASSAR register address for AIB access >=20 > These properties enable the driver to perform voltage switching between > 3.3V and 1.8V required for UHS SD card modes. >=20 > Signed-off-by: Iker Pedrosa > --- > Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml | 15 +++++++++= ++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml b/= Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml > index 13d9382058fbc1c12be1024d1c550f04a825673c..4d6590aa8262009b6e5697a04= b45cf3736c0fa42 100644 > --- a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml > @@ -32,6 +32,18 @@ properties: > - const: core > - const: io > =20 > + spacemit,aib-mmc1-io-reg: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: AIB MMC1 IO register address for voltage switching > + > + spacemit,apbc-asfar-reg: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: APBC ASFAR register address for AIB access > + > + spacemit,apbc-assar-reg: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: APBC ASSAR register address for AIB access > + > required: > - compatible > - reg > @@ -50,4 +62,7 @@ examples: > interrupt-parent =3D <&plic>; > clocks =3D <&clk_apmu 10>, <&clk_apmu 13>; > clock-names =3D "core", "io"; > + spacemit,aib-mmc1-io-reg =3D <0xd401e81c>; This looks very very wrong to me. This is part of the pinctrl reservation: pinctrl: pinctrl@d401e000 { compatible =3D "spacemit,k1-pinctrl"; reg =3D <0x0 0xd401e000 0x0 0x1000>; clocks =3D <&syscon_apbc CLK_AIB>, <&syscon_apbc CLK_AIB_BUS>; clock-names =3D "func", "bus"; spacemit,apbc =3D <&syscon_apbc>; }; so if you need to change something here, you need to do it via pinctrl. > + spacemit,apbc-asfar-reg =3D <0xd4015050>; > + spacemit,apbc-assar-reg =3D <0xd4015054>; These two are the apbc syscon: syscon_apbc: system-controller@d4015000 { compatible =3D "spacemit,k1-syscon-apbc"; reg =3D <0x0 0xd4015000 0x0 0x1000>; clocks =3D <&osc_32k>, <&vctcxo_1m>, <&vctcxo_3m>, <&vctcxo_24m>; clock-names =3D "osc", "vctcxo_1m", "vctcxo_3m", "vctcxo_24m"; #clock-cells =3D <1>; #reset-cells =3D <1>; }; so add a phandle to the syscon (like the pinctrl currently has) and access these via its regmap. What you've got here is a non-runner, sorry. pw-bot: changes-requested Thanks, Conor. --iVG0vKrqfY2+UZi0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaaXV/wAKCRB4tDGHoIJi 0mz2AP9Q9b/xkWkD/y0/gd0Q80+ijFziY/LsJwgySgJsYSig7gD/YRFFEbPlNDFf Bl1OTEmAhqj29hPvOZ0o5CC11uqBGgs= =A6Ze -----END PGP SIGNATURE----- --iVG0vKrqfY2+UZi0--