[PATCH 0/2] ASoC: tegra: Add Tegra238 sound card support

[PATCH 0/2] ASoC: tegra: Add Tegra238 sound card support

[Sheetal .]

From: sheetal <sheetal@nvidia.com>

Add Tegra238 sound card support in the Tegra audio graph card driver,
as Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared
to other Tegra platforms.

Sheetal (2):
  ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card
  ASoC: tegra: Add support for Tegra238 soundcard

 .../sound/nvidia,tegra-audio-graph-card.yaml        |  1 +
 sound/soc/tegra/tegra_audio_graph_card.c            | 13 ++++++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH 1/2] ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card

[Sheetal .]

From: Sheetal <sheetal@nvidia.com>

Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared to
other Tegra platforms. Add Tegra238 compatible string to the APE
tegra-audio-graph-card bindings.

Signed-off-by: Sheetal <sheetal@nvidia.com>
---
 .../devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
index da89523ccf5f..92bc3ef56f2c 100644
--- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
+++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-graph-card.yaml
@@ -23,6 +23,7 @@ properties:
     enum:
       - nvidia,tegra210-audio-graph-card
       - nvidia,tegra186-audio-graph-card
+      - nvidia,tegra238-audio-graph-card
       - nvidia,tegra264-audio-graph-card
 
   clocks:
-- 
2.34.1

[PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

[Sheetal .]

From: Sheetal <sheetal@nvidia.com>

Tegra238 platforms use different clock rates for plla and
plla_out0 clocks. Add Tegra238 support in the Tegra
sound card driver to apply specific clock configurations.

Signed-off-by: Aditya Bavanari <abavanari@nvidia.com>
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
 sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c
index 94b5ab77649b..b6dadd6a3d3d 100644
--- a/sound/soc/tegra/tegra_audio_graph_card.c
+++ b/sound/soc/tegra/tegra_audio_graph_card.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
+// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
 //
 // tegra_audio_graph_card.c - Audio Graph based Tegra Machine Driver
 
@@ -231,6 +231,15 @@ static const struct tegra_audio_cdata tegra186_data = {
 	.plla_out0_rates[x11_RATE] = 45158400,
 };
 
+static const struct tegra_audio_cdata tegra238_data = {
+	/* PLLA */
+	.plla_rates[x8_RATE] = 1277952000,
+	.plla_rates[x11_RATE] = 1264435200,
+	/* PLLA_OUT0 */
+	.plla_out0_rates[x8_RATE] = 49152000,
+	.plla_out0_rates[x11_RATE] = 45158400,
+};
+
 static const struct tegra_audio_cdata tegra264_data = {
 	/* PLLA1 */
 	.plla_rates[x8_RATE] = 983040000,
@@ -245,6 +254,8 @@ static const struct of_device_id graph_of_tegra_match[] = {
 	  .data = &tegra210_data },
 	{ .compatible = "nvidia,tegra186-audio-graph-card",
 	  .data = &tegra186_data },
+	{ .compatible = "nvidia,tegra238-audio-graph-card",
+	  .data = &tegra238_data },
 	{ .compatible = "nvidia,tegra264-audio-graph-card",
 	  .data = &tegra264_data },
 	{},
-- 
2.34.1

Re: [PATCH 1/2] ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card

[Krzysztof Kozlowski]

On 02/03/2026 09:53, Sheetal . wrote:
> From: Sheetal <sheetal@nvidia.com>
> 
> Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared to
> other Tegra platforms. Add Tegra238 compatible string to the APE
> tegra-audio-graph-card bindings.
> 
> Signed-off-by: Sheetal <sheetal@nvidia.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

[Krzysztof Kozlowski]

On 02/03/2026 09:53, Sheetal . wrote:
> From: Sheetal <sheetal@nvidia.com>
> 
> Tegra238 platforms use different clock rates for plla and
> plla_out0 clocks. Add Tegra238 support in the Tegra
> sound card driver to apply specific clock configurations.
> 
> Signed-off-by: Aditya Bavanari <abavanari@nvidia.com>
> Signed-off-by: Sheetal <sheetal@nvidia.com>
> ---
>  sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c
> index 94b5ab77649b..b6dadd6a3d3d 100644
> --- a/sound/soc/tegra/tegra_audio_graph_card.c
> +++ b/sound/soc/tegra/tegra_audio_graph_card.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> -// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
> +// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.

If updating it, you should rather drop it and use standard copyright.
This tag is not supported in kernel in general and I document it only
because it already spread all over.


Best regards,
Krzysztof

Re: (subset) [PATCH 0/2] ASoC: tegra: Add Tegra238 sound card support

[Mark Brown]

On Mon, 02 Mar 2026 14:23:21 +0530, Sheetal . wrote:
> Add Tegra238 sound card support in the Tegra audio graph card driver,
> as Tegra238 requires different PLLA and PLLA_OUT0 clock rates compared
> to other Tegra platforms.
> 
> Sheetal (2):
>   ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card
>   ASoC: tegra: Add support for Tegra238 soundcard
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: tegra: Add compatible for Tegra238 sound card
      commit: a8df7892a9f42b2e2d5851f8835c734bd7fe8ad4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

[Jon Hunter]

On 02/03/2026 09:04, Krzysztof Kozlowski wrote:
> On 02/03/2026 09:53, Sheetal . wrote:
>> From: Sheetal <sheetal@nvidia.com>
>>
>> Tegra238 platforms use different clock rates for plla and
>> plla_out0 clocks. Add Tegra238 support in the Tegra
>> sound card driver to apply specific clock configurations.
>>
>> Signed-off-by: Aditya Bavanari <abavanari@nvidia.com>
>> Signed-off-by: Sheetal <sheetal@nvidia.com>
>> ---
>>   sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c
>> index 94b5ab77649b..b6dadd6a3d3d 100644
>> --- a/sound/soc/tegra/tegra_audio_graph_card.c
>> +++ b/sound/soc/tegra/tegra_audio_graph_card.c
>> @@ -1,5 +1,5 @@
>>   // SPDX-License-Identifier: GPL-2.0-only
>> -// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
>> +// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
> 
> If updating it, you should rather drop it and use standard copyright.
> This tag is not supported in kernel in general and I document it only
> because it already spread all over.

To be clear, you mean that 'SPDX-FileCopyrightText' is not supported? 
Where exactly do you document it for reference?

I know that Rob previously indicated that the 'Copyright' string in the 
above was redundant, but we have been told to keep this by the people at 
NVIDIA that specify how we should be formatting such tags when adding 
NVIDIA copyrights.

Jon

-- 
nvpublic

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

[Krzysztof Kozlowski]

On 03/03/2026 15:24, Jon Hunter wrote:
> 
> On 02/03/2026 09:04, Krzysztof Kozlowski wrote:
>> On 02/03/2026 09:53, Sheetal . wrote:
>>> From: Sheetal <sheetal@nvidia.com>
>>>
>>> Tegra238 platforms use different clock rates for plla and
>>> plla_out0 clocks. Add Tegra238 support in the Tegra
>>> sound card driver to apply specific clock configurations.
>>>
>>> Signed-off-by: Aditya Bavanari <abavanari@nvidia.com>
>>> Signed-off-by: Sheetal <sheetal@nvidia.com>
>>> ---
>>>   sound/soc/tegra/tegra_audio_graph_card.c | 13 ++++++++++++-
>>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/sound/soc/tegra/tegra_audio_graph_card.c b/sound/soc/tegra/tegra_audio_graph_card.c
>>> index 94b5ab77649b..b6dadd6a3d3d 100644
>>> --- a/sound/soc/tegra/tegra_audio_graph_card.c
>>> +++ b/sound/soc/tegra/tegra_audio_graph_card.c
>>> @@ -1,5 +1,5 @@
>>>   // SPDX-License-Identifier: GPL-2.0-only
>>> -// SPDX-FileCopyrightText: Copyright (c) 2020-2025 NVIDIA CORPORATION. All rights reserved.
>>> +// SPDX-FileCopyrightText: Copyright (c) 2020-2026 NVIDIA CORPORATION. All rights reserved.
>>
>> If updating it, you should rather drop it and use standard copyright.
>> This tag is not supported in kernel in general and I document it only
>> because it already spread all over.
> 
> To be clear, you mean that 'SPDX-FileCopyrightText' is not supported? 

Yes

> Where exactly do you document it for reference?

paste SPDX-FileCopyrightText in lore


> 
> I know that Rob previously indicated that the 'Copyright' string in the 
> above was redundant, but we have been told to keep this by the people at 
> NVIDIA that specify how we should be formatting such tags when adding 
> NVIDIA copyrights.

For the kernel, for most of us, most likely legally it is redundant and
Rob was right, but some companies insist on it and I don't want to
discuss with them, because they never use actual arguments except "my
legal told me I must do", so you can have it. That's not a problem.


Best regards,
Krzysztof

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

[Jon Hunter]

On 03/03/2026 14:54, Krzysztof Kozlowski wrote:

...

>> Where exactly do you document it for reference?
> 
> paste SPDX-FileCopyrightText in lore

Got it!

>> I know that Rob previously indicated that the 'Copyright' string in the
>> above was redundant, but we have been told to keep this by the people at
>> NVIDIA that specify how we should be formatting such tags when adding
>> NVIDIA copyrights.
> 
> For the kernel, for most of us, most likely legally it is redundant and
> Rob was right, but some companies insist on it and I don't want to
> discuss with them, because they never use actual arguments except "my
> legal told me I must do", so you can have it. That's not a problem.

Before I had requested we change this everywhere but there was concern 
that we would have slightly different variants in different places. What 
I could ask if for the kernel we can just use ...

  SPDX-FileCopyrightText: <date> NVIDIA CORPORATION. All rights reserved.

Although I see some instances in the kernel with 'NVIDIA CORPORATION & 
AFFILIATES' and so they may want ...

  SPDX-FileCopyrightText: <date> NVIDIA CORPORATION & AFFILIATES. All
   rights reserved.

Anyway, would the above be acceptable?

Jon
-- 
nvpublic

Re: [PATCH 2/2] ASoC: tegra: Add support for Tegra238 soundcard

[Krzysztof Kozlowski]

On 03/03/2026 17:38, Jon Hunter wrote:
> 
> On 03/03/2026 14:54, Krzysztof Kozlowski wrote:
> 
> ...
> 
>>> Where exactly do you document it for reference?
>>
>> paste SPDX-FileCopyrightText in lore
> 
> Got it!
> 
>>> I know that Rob previously indicated that the 'Copyright' string in the
>>> above was redundant, but we have been told to keep this by the people at
>>> NVIDIA that specify how we should be formatting such tags when adding
>>> NVIDIA copyrights.
>>
>> For the kernel, for most of us, most likely legally it is redundant and
>> Rob was right, but some companies insist on it and I don't want to
>> discuss with them, because they never use actual arguments except "my
>> legal told me I must do", so you can have it. That's not a problem.
> 
> Before I had requested we change this everywhere but there was concern 
> that we would have slightly different variants in different places. What 
> I could ask if for the kernel we can just use ...
> 
>   SPDX-FileCopyrightText: <date> NVIDIA CORPORATION. All rights reserved.
> 
> Although I see some instances in the kernel with 'NVIDIA CORPORATION & 
> AFFILIATES' and so they may want ...
> 
>   SPDX-FileCopyrightText: <date> NVIDIA CORPORATION & AFFILIATES. All
>    rights reserved.
> 
> Anyway, would the above be acceptable?

I suggest to drop the SPDX and use standard Copyright. I do not have
preference what goes after the copyright, especially that some companies
have odd choices and - as Greg KH once explained to me - it does not
matter for us.

Best regards,
Krzysztof