From: Andreas Kemnade <andreas@kemnade.info>
To: Mithil Bavishi <bavishimithil@gmail.com>
Cc: aaro.koskinen@iki.fi, airlied@gmail.com, conor+dt@kernel.org,
jernej.skrabec@gmail.com, jonas@kwiboo.se, khilman@baylibre.com,
krzk+dt@kernel.org, laurent.pinchart@ideasonboard.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
neil.armstrong@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com, jesszhan0024@gmail.com,
rfoss@kernel.org, robh@kernel.org, rogerq@kernel.org,
simona@ffwll.ch, thierry.reding@gmail.com, tony@atomide.com,
tzimmermann@suse.de, andrzej.hajda@intel.com,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v8 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series
Date: Mon, 2 Mar 2026 20:58:31 +0100 [thread overview]
Message-ID: <20260302205831.5a54b142@kemnade.info> (raw)
In-Reply-To: <20260223134941.427-6-bavishimithil@gmail.com>
On Mon, 23 Feb 2026 08:49:37 -0500
Mithil Bavishi <bavishimithil@gmail.com> wrote:
> Create common device tree for Samsung Espresso series devices
>
> Create a shared device tree for all variants first.
> Device-specific trees will be added later based on screen size.
>
> Signed-off-by: Mithil Bavishi <bavishimithil@gmail.com>
[...]
> +&omap4_pmx_wkup {
> + gpio_keys: gpio-keys-pins {
> + pinctrl-single,pins = <
> + OMAP4_IOPAD(0x046, PIN_INPUT | MUX_MODE3)
> + /* sim_cd.gpio_wk3 - EXT_WAKEUP */
> + OMAP4_IOPAD(0x056, | PIN_INPUT | MUX_MODE3)
> + /* fref_clk3_req.gpio_wk30 - VOL_UP */
> + OMAP4_IOPAD(0x05C, | PIN_INPUT | MUX_MODE3)
syntax error. stray | in these two lines. even for small cosmetic
changes, at the very least build it.
Regards,
Andreas
next prev parent reply other threads:[~2026-03-02 19:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:49 Mithil Bavishi
2026-02-23 13:49 ` [PATCH v8 1/8] ARM: dts: twl6032: Add DTS file for TWL6032 PMIC Mithil Bavishi
2026-02-23 13:49 ` [PATCH v8 2/8] dt-bindings: vendor-prefixes: Add Doestek Mithil Bavishi
2026-02-23 13:49 ` [PATCH v8 3/8] dt-bindings: display: bridge: lvds-codec: add doestek,dtc34lm85am Mithil Bavishi
2026-03-02 20:16 ` Andreas Kemnade
2026-02-23 13:49 ` [PATCH v8 4/8] dt-bindings: display: panel-lvds: Add compatibles for Samsung LTN070NL01 and LTN101AL03 panels Mithil Bavishi
2026-02-23 13:49 ` [PATCH v8 5/8] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series Mithil Bavishi
2026-03-02 19:58 ` Andreas Kemnade [this message]
2026-02-23 13:49 ` [PATCH v8 6/8] dt-bindings: omap: Add Samsung Galaxy Tab 2 7.0 and 10.1 Mithil Bavishi
2026-02-23 13:49 ` [PATCH v8 7/8] ARM: dts: ti: omap: samsung-espresso7: Add initial support for Galaxy Tab 2 7.0 Mithil Bavishi
2026-02-23 13:49 ` [PATCH v8 8/8] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1 Mithil Bavishi
2026-03-02 19:52 ` Andreas Kemnade
2026-03-26 9:02 ` (subset) Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302205831.5a54b142@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=bavishimithil@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=jonas@kwiboo.se \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=simona@ffwll.ch \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox