From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81D0033DEFC; Tue, 3 Mar 2026 21:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573027; cv=none; b=Xfl+/ExligDBxaNlaj0qkeotG7AOl6h9QQkbPBUR+RMrt72xP7m8nhaHf8kdunbcts44sxAFarvz5JTPXobCvRmSQPvbvhV7XlEaQQWFqnMCZfh5uV6wRoSddg80hwn+k7x//JFXb+UrRlG+pfgIPQpgCLLLT1+qmVpDrLJz3Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573027; c=relaxed/simple; bh=YcSocgznECK+o/we3yUad/E/8vBVLRMAT3MtSKO/W30=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=TKlSr9KqCDl4TEdKW+Q4t++WcuxWkFeermI03RCsvKSVAy656wwS/jeOzksh36rBbOfHFvwJAGuaQX8A4VLTR0U15drz72hDUbFfRMzKd8T/2kfXew6gW1Ra0cEavW/3jCnkXElJR5H8Iu5UGnzeaOM3xmWTXhEt2xVhIl55PvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fOz+tlne; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fOz+tlne" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 063BAC116C6; Tue, 3 Mar 2026 21:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772573027; bh=YcSocgznECK+o/we3yUad/E/8vBVLRMAT3MtSKO/W30=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fOz+tlnehFyphQ/3M8Tq4w8E8RjCKOAmlOHznFurSZzI28e4zpb+I/DjpUwHK6V/t p4es7NsaKNZLBR/kCVeLyB2qRiidgk4hQ6ULh7H4jEUY9WTvQXv8YyTdofb9hK/fwi xMxbkCaJcBNM215s0ByGjA9DI9Y9kqxOGgxcvKFOyLzaxsqSdUnkG4AYP0BplKyt1K lwDXfKxyHc1Re2XoPas1d12x8beCocMwIsV3vE7rd9HI1zmsaWO7WqZCneKIDIZNP9 jb8peg9LuPnlMH/rfiqZ+LoKXp9iZeJYix8ShkoUDlBcF1it2f4T1FwytRt/26xzdj yFQqhXNp3aR+g== Date: Tue, 3 Mar 2026 15:23:45 -0600 From: Bjorn Helgaas To: Caleb James DeLisle Cc: linux-mips@vger.kernel.org, naseefkm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, tsbogend@alpha.franken.de, ryder.lee@mediatek.com, jianjun.wang@mediatek.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, vkoul@kernel.org, neil.armstrong@linaro.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, nbd@nbd.name, ansuelsmth@gmail.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 7/8] PCI: Skip bridge window reads when window is not supported Message-ID: <20260303212345.GA4074959@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303190948.694783-8-cjd@cjdns.fr> On Tue, Mar 03, 2026 at 07:09:47PM +0000, Caleb James DeLisle wrote: > pci_read_bridge_io() and pci_read_bridge_mmio_pref() read bridge window > registers unconditionally. If the registers are hardwired to zero > (not implemented), both base and limit will be 0. Since (0 <= 0) is > true, a bogus window [mem 0x00000000-0x000fffff] or [io 0x0000-0x0fff] > gets created. > > pci_read_bridge_windows() already detects unsupported windows by > testing register writability and sets io_window/pref_window flags > accordingly. Check these flags at the start of pci_read_bridge_io() > and pci_read_bridge_mmio_pref() to skip reading registers when the > window is not supported. > > Suggested-by: Bjorn Helgaas I think this refers to the conversation at: https://lore.kernel.org/r/20260113210259.GA715789@bhelgaas/ Can you include that URL for reference? > Signed-off-by: Ahmed Naseef > Signed-off-by: Caleb James DeLisle Acked-by: Bjorn Helgaas > --- > drivers/pci/probe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index bccc7a4bdd79..4eacb741b4ec 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -395,6 +395,9 @@ static void pci_read_bridge_io(struct pci_dev *dev, struct resource *res, > unsigned long io_mask, io_granularity, base, limit; > struct pci_bus_region region; > > + if (!dev->io_window) > + return; > + > io_mask = PCI_IO_RANGE_MASK; > io_granularity = 0x1000; > if (dev->io_window_1k) { > @@ -465,6 +468,9 @@ static void pci_read_bridge_mmio_pref(struct pci_dev *dev, struct resource *res, > pci_bus_addr_t base, limit; > struct pci_bus_region region; > > + if (!dev->pref_window) > + return; > + > pci_read_config_word(dev, PCI_PREF_MEMORY_BASE, &mem_base_lo); > pci_read_config_word(dev, PCI_PREF_MEMORY_LIMIT, &mem_limit_lo); > base64 = (mem_base_lo & PCI_PREF_RANGE_MASK) << 16; > -- > 2.39.5 >