From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Alexandru Hossu <hossu.alexandru@gmail.com>,
robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property
Date: Wed, 4 Mar 2026 14:22:53 +0000 [thread overview]
Message-ID: <20260304-premises-brunch-26faa087389a@spud> (raw)
In-Reply-To: <9d57af5e-ac23-4679-9719-6505dd851a2e@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2294 bytes --]
On Wed, Mar 04, 2026 at 03:08:46PM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2026 14:29, Conor Dooley wrote:
> >
> >
> > On 4 March 2026 13:22:48 GMT, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> On Wed, Mar 04, 2026 at 02:16:10PM +0100, Alexandru Hossu wrote:
> >>> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
> >>
> >> For obvious reasons, we can't take patches without any changelog text,
> >> nor would you want us to.
> >
> > This is also a second person working on this conversation.
>
> I see, so that's a patch for something which does not exist yet (not
> merged).
This is the usual "two people working independently", except
Alexandru's "v2" is actually not a v2 but rather a patch on top of his
own v1. Ditto with his v3. It's not a patch on top of the other guy.
>
> > I left commentary on the other version of it.
> > I am fairly confident that converting this binding is almost useless without evaluating whether this should become a dma engine.
> > I'm almost certain my employer has something very similar, based on naming and use case, and I saw no reason why it could not be a dma engine.
> > Any as-is conversation of this should, IMO, come with an evaluation of why this is the correct way to model it.
> > I don't think it's suitable for any sort of "internship" program that sees binding conversations as low hanging fruit.
Whoops, my bad on the long lines, sent it from my phone..
> Do you suspect another round of some GSoC or LFX mentorship?
Yeah, that is my suspicion. Lucas (the other submitter) also displayed
lack of familiarity with the process, but that may just be happenstance.
Plenty of binding conversions I am sure are suitable for some sort of
"internship", but probably not ones in staging, since they probably need
to come with an evaluation of whether things are currently correct and
maybe with driver changes that really require having the hardware.
This is probably one of the few cases where what's in staging is a bad
candidate to work on, and things outside of staging that have a fixed
ABI are much easier to convert.
If this is some sort of "internship", probably the guidance on what to
do should not include binding conversions without oversight from the
mentor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-04 14:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 11:08 [PATCH] staging: axis-fifo: fix alignment and add DT binding documentation Alexandru Hossu
2026-03-04 12:30 ` Rob Herring (Arm)
2026-03-04 12:32 ` Krzysztof Kozlowski
2026-03-04 12:46 ` [PATCH v2] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property Alexandru Hossu
2026-03-04 12:51 ` Krzysztof Kozlowski
2026-03-04 12:52 ` Krzysztof Kozlowski
2026-03-04 13:16 ` [PATCH] " Alexandru Hossu
2026-03-04 13:22 ` Greg KH
2026-03-04 13:29 ` Conor Dooley
2026-03-04 14:08 ` Krzysztof Kozlowski
2026-03-04 14:22 ` Conor Dooley [this message]
2026-03-04 13:24 ` Krzysztof Kozlowski
2026-03-04 14:12 ` [PATCH v2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304-premises-brunch-26faa087389a@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hossu.alexandru@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox