[PATCH v3] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property

[PATCH v3] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property

[Alexandru Hossu]

Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
---
 .../devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
index 6d1cd651e..cdc295f2d 100644
--- a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
+++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
@@ -31,8 +31,6 @@ properties:
     items:
       - const: interrupt
 
-  interrupt-parent: true
-
   xlnx,use-rx-data:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum: [0, 1]
@@ -56,7 +54,6 @@ required:
   - reg
   - interrupts
   - interrupt-names
-  - interrupt-parent
   - xlnx,use-rx-data
   - xlnx,use-tx-data
 
@@ -64,11 +61,16 @@ additionalProperties: true
 
 examples:
   - |
+    intc: interrupt-controller {
+      interrupt-controller;
+      #interrupt-cells = <1>;
+    };
+
     axi_fifo_mm_s_0: axi_fifo_mm_s@43c00000 {
       compatible = "xlnx,axi-fifo-mm-s-4.1";
       interrupt-names = "interrupt";
       interrupt-parent = <&intc>;
-      interrupts = <0 29 4>;
+      interrupts = <29>;
       reg = <0x43c00000 0x10000>;
       xlnx,use-rx-data = <0x0>;
       xlnx,use-tx-data = <0x1>;
-- 
2.43.0

Re: [PATCH v3] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property

[Krzysztof Kozlowski]

On 04/03/2026 14:05, Alexandru Hossu wrote:
> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>

For the third time, please slow down and re-check what you are doing.
There is no commit msg here at all. Nothing here looks justified.

You never responded to any emails, so I will finish with my replies.
Next one I will just NAK.

Best regards,
Krzysztof

Re: [PATCH v3] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property

[Greg KH]

On Wed, Mar 04, 2026 at 02:05:56PM +0100, Alexandru Hossu wrote:
> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
> ---
>  .../devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml   | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> index 6d1cd651e..cdc295f2d 100644
> --- a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> @@ -31,8 +31,6 @@ properties:
>      items:
>        - const: interrupt
>  
> -  interrupt-parent: true
> -
>    xlnx,use-rx-data:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [0, 1]
> @@ -56,7 +54,6 @@ required:
>    - reg
>    - interrupts
>    - interrupt-names
> -  - interrupt-parent
>    - xlnx,use-rx-data
>    - xlnx,use-tx-data
>  
> @@ -64,11 +61,16 @@ additionalProperties: true
>  
>  examples:
>    - |
> +    intc: interrupt-controller {
> +      interrupt-controller;
> +      #interrupt-cells = <1>;
> +    };
> +
>      axi_fifo_mm_s_0: axi_fifo_mm_s@43c00000 {
>        compatible = "xlnx,axi-fifo-mm-s-4.1";
>        interrupt-names = "interrupt";
>        interrupt-parent = <&intc>;
> -      interrupts = <0 29 4>;
> +      interrupts = <29>;
>        reg = <0x43c00000 0x10000>;
>        xlnx,use-rx-data = <0x0>;
>        xlnx,use-tx-data = <0x1>;
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v3] dt-bindings: misc: xlnx,axi-fifo-mm-s: fix interrupt-parent property

[Krzysztof Kozlowski]

On 04/03/2026 14:05, Alexandru Hossu wrote:
> Signed-off-by: Alexandru Hossu <hossu.alexandru@gmail.com>
> ---
>  .../devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml   | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> index 6d1cd651e..cdc295f2d 100644
> --- a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml


And there is no such file. What is happening here?!?

Best regards,
Krzysztof