From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add shaping nodes for rk3576
Date: Sat, 7 Mar 2026 16:18:07 +0100 [thread overview]
Message-ID: <20260307-impartial-cat-of-efficiency-a742ff@quoll> (raw)
In-Reply-To: <1772782832-216867-4-git-send-email-shawn.lin@rock-chips.com>
On Fri, Mar 06, 2026 at 03:40:32PM +0800, Shawn Lin wrote:
> <&cru PCLK_VOP_ROOT>;
> pm_qos = <&qos_vop_m0>,
> <&qos_vop_m1ro>;
> + pm_shaping = <&shaping_vop_m0>,
> + <&shaping_vop_m1ro>;
> #power-domain-cells = <1>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -1602,11 +1626,21 @@
> reg = <0x0 0x27f05000 0x0 0x20>;
> };
>
> + shaping_gpu: shaping@27f05088 {
> + compatible = "rockchip,rk3576-shaping", "syscon";
NAK, undocumented ABI.
And basic checkpatch would tell you that.
Also, shaping block is not a syscon. Please read what the syscon is.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-07 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 7:40 [PATCH 0/3] Add shaping support for Rockchip platforms Shawn Lin
2026-03-06 7:40 ` [PATCH 1/3] dt-bindings: power: rockchip: Add pm_shaping support Shawn Lin
2026-03-07 15:17 ` Krzysztof Kozlowski
2026-03-06 7:40 ` [PATCH 2/3] pmdomain: " Shawn Lin
2026-03-06 7:40 ` [PATCH 3/3] arm64: dts: rockchip: Add shaping nodes for rk3576 Shawn Lin
2026-03-07 15:18 ` Krzysztof Kozlowski [this message]
2026-03-06 10:43 ` [PATCH 0/3] Add shaping support for Rockchip platforms Heiko Stuebner
2026-03-06 12:10 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307-impartial-cat-of-efficiency-a742ff@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox