Re: [PATCH 1/1] riscv: dts: spacemit: Add 'linux,pci-domain' to PCIe nodes for K1

[Yixun Lan <dlan@gentoo.org>]

Hi Chukun,

On 12:38 Sat 07 Mar     , Chukun Pan wrote:
> Hi,
> 
> > You describe what's has been done here, but no why?
> 
> Because the PCIe boot order is random, if there are two R8125
> network cards, their interface names will not be fixed.
> 
> For example:
> First boot:
> pcie@ca400000 -> eth2
> pcie@ca800000 -> eth3
> 
> Second boot:
> pcie@ca400000 -> eth3
> pcie@ca800000 -> eth2
> 
Ok, I can understand your problem

> If their PCI domain numbers are fixed, I can fix the interface
> names by matching /sys/devices using a script.
> 
If you want to have a fixed interface name, you could setup a udev
rules according to mac address? something like:

$ cat /etc/udev/rules.d/70-network.rules
SUBSYSTEM=="net", ACTION=="add", DRIVERS=="?*", ATTR{address}=="01:02:03:12:34:56", NAME="eth2"

but, I see no harm to add a pci domain property..

> > Can you add description about why problem with random domain,
> > and the motivation of the change behind?
> 
> Should I improve the commit messages?
> 
Yes, please, thanks

> Thanks,
> Chukun
> 

-- 
Yixun Lan (dlan)