From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF0C44102F for ; Tue, 10 Mar 2026 09:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134968; cv=none; b=a/0VQn0Xz7n34V7Mgl3TtdKppXGyncpPS/1gwON+EXxOBILeyanEeb9x7eo/lYh+CCfy7AJwr0M0aqePCl2+x1GQNXz8OmIxNw0eMW0ya0cihDFwbSVWQ9nWAFT1I1H5BUK8Nx7La4t4MIdmUIOL9rWMaKCOntD6VWYYXE1p+aY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134968; c=relaxed/simple; bh=uhoOBLTkCt9koWbQVb9qbShLeGalrFZRwZECwHGWC0Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pxEOLA0fVup4bi7ZiBJyj8UmdbCah32hiIbbHPM9PcQcuenKBgQiAlHeOQhAmPH0yapdRC5iN51p1RjH3V4A6B/MpwStHqqWJDtQnwIdCuyGvE3ztTBSUAEqBtPAP9aIvRIv8mNYkKeY16gd+n3AMF+9d8/YFwdDbl4lbzYH5ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=8IoaQdpn; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="8IoaQdpn" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4852e9ca034so28736535e9.2 for ; Tue, 10 Mar 2026 02:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773134966; x=1773739766; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XCPvyofErjhorjvOzgcNlfIsVmqLN0uhP/f3Z0DZct8=; b=8IoaQdpniGTg3J6DKnb32KHRH0sycNRGaeTUw4PxH8cUHaxx/FSnxd+KDMbeCOZod3 t+Ja3fvXVkUS9tUPX01B46aE6qMa8xnuBP6s0pCJqRZQ8ggpsjDU0zSntnfErnPSk1JL O6OfPMmgeyWOs16+QWiYPUFx674BsT9lIjTkwDrPuTCrQyShLKe6TgjetroMJi9am/GD U7OHpjxRjyo+TCaAft8CP5DDKcFa6KKjXfqaIyCSRtEUZX585kr6iFLwnqQYcUa9aPBd PJTpnB3ChwVWuhIwtBdhClKA5Jxq8lrorsszwwlIe3BsRZCmZUJtRmXeUoZvmzpTcD5c NADA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773134966; x=1773739766; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XCPvyofErjhorjvOzgcNlfIsVmqLN0uhP/f3Z0DZct8=; b=IJr+OmvCy0PaufUMZ2854w/dWHYche2PvxZSxWcKgkndFAptkcxvomx6Ohjuv2bK88 uamoeTDRSTPT+Z7r5jXobM3ohnUlmgmQjhh15/fpT2JQDfmvKsAriyuxGPnEXGRCFPGp kIOGEi5eGHAo8pOXiFP4Zn2SuunhhhEu8NNLNxBFqxiXWfL1hZUwSQZXtVQ2xQphEL+p 9A9lfSyqw0pYbTvUwbpobMhlAofpafXYfwDWDOQfskrC3aihUgEaLKqFgjNqFOb2d8tj l8tuG83bLNnYZEGimIctU87E9Eb2IUnYNTzOwT0XY2w9oTD7wf6oNfmB3ePKqfGxB8qM vC8g== X-Gm-Message-State: AOJu0YzqufQPYu6fkVgOYENCIP4hNYJSNYcfewORompbN+Cyz+r0Tnyi 49b7xTWwPeRJ9y1j+0n20dMUzXw07hZ7af432YLv5dcJ2uv/miNir9hz41HwuZEO5Gg= X-Gm-Gg: ATEYQzw7uFG43yxGuo5ToYB7pLK05/ZW5rtP8BJZ7knjBzHmK9IPtq1H7AMdte6DMiv j1QUtNLWkvTKPmKkGWcr5+JBcLsE7erra+NH22+1BOafOIBc/t7+Osh8g72eJV8mt84+Qby9fCh Lo9/A6qwA4wHrRa18gm7IzDunMIQ0wVSgyF20iPjGTB2hDbvrQvb73QdC7RimuhUzbM5coW+YNa LVib3mAocBnqsWLqvqrxcinKktRUZtrWktMvuMJrj5pc4JrTDxaCwe4tGIaluisBJkcr8boOwv6 otBzOyDUP39em1Mz/T8nSyigh/P+WiOtu4UAQ6qDTkMOSegntn38ZtTLf7LV728oq+XH7FiUptj iM633m4Tp+DDPo+/ZSpTjFvdUK8gEuT55sV/NwrsjU96aKvX9HiRkDI9b/gfKMcLqs5piFjwgsv icLnH/TqKa1ZALprTaFfaTWxd7YSZqLp7eVar+CPXScrINYMM/FQuLyeyrqvCM+TikVs9jL2wOQ 39zMQ== X-Received: by 2002:a05:600c:350e:b0:477:9b35:3e49 with SMTP id 5b1f17b1804b1-48526916bafmr216148855e9.3.1773134965857; Tue, 10 Mar 2026 02:29:25 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48529f019a4sm104214285e9.12.2026.03.10.02.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 02:29:25 -0700 (PDT) From: Alexey Charkov Date: Tue, 10 Mar 2026 13:28:31 +0400 Subject: [PATCH v3 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260310-bq25792-v3-7-02f8e232d63b@flipper.net> References: <20260310-bq25792-v3-0-02f8e232d63b@flipper.net> In-Reply-To: <20260310-bq25792-v3-0-02f8e232d63b@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3415; i=alchark@flipper.net; h=from:subject:message-id; bh=uhoOBLTkCt9koWbQVb9qbShLeGalrFZRwZECwHGWC0Y=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSuf5L4NvKH67LLO18+Sn5RxHPNdrv3nO0LruRGXQj+0 /20df1fvo6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCm2t+WkWHS7M0t5hLsDYsOPvvOY/LJnP2eQPVPZp/GQ1tXs3l0pp1j+M3CuXN qTVjBB8fv3MybHe4Vyxkde/t8/bKv0YLzZ66W1uQAAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/bq257xx_charger.c index e14dd16f9d08..deb60a9bd222 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -30,9 +30,15 @@ struct bq257xx_chip_info { int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; /** @@ -489,22 +495,22 @@ static int bq257xx_get_charger_property(struct power_supply *psy, break; case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); case POWER_SUPPLY_PROP_USB_TYPE: val->intval = pdata->usb_type; @@ -632,9 +638,15 @@ static const struct bq257xx_chip_info bq25703_chip_info = { .bq257xx_hw_init = &bq25703_hw_init, .bq257xx_hw_shutdown = &bq25703_hw_shutdown, .bq257xx_get_state = &bq25703_get_state, + .bq257xx_get_ichg = &bq25703_get_ichg_cur, .bq257xx_set_ichg = &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg = &bq25703_get_chrg_volt, .bq257xx_set_vbatreg = &bq25703_set_chrg_volt, + .bq257xx_get_iindpm = &bq25703_get_iindpm, .bq257xx_set_iindpm = &bq25703_set_iindpm, + .bq257xx_get_cur = &bq25703_get_cur, + .bq257xx_get_vbat = &bq25703_get_vbat, + .bq257xx_get_min_vsys = &bq25703_get_min_vsys, }; /** -- 2.52.0