From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42FBC3EF0B0; Tue, 10 Mar 2026 08:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773131051; cv=none; b=bOSuGCxERRXHMfjLfWGwKNFRn8s/haYtNNzc12cOxZjKCvvD1CnX17tT+idJ8YwUjnTu8qcqifxIFuGE1Vp1DpmMqWYm4GzPy4aQT7L1U+nnOK3fAUAAhXcUSFo50q9kBolR3bMd2D9Fl1qNQjwhV73LZgNrp2yG1cTFi0jGWtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773131051; c=relaxed/simple; bh=X93Yxq3bUx636kMPKo1AS2iratZcYw/WWrjo9W6vW9c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OKXjUA8RgsniYmvalpfcorvpwAokxAVkoM3Vysm42IPiSSoHqFh/uPJfYh2931z2mXsgo585Dav9G/xs0qmyIZIP9qYM4d2QZZKl/hGkxCqT2N74bTbWEpijUB8YIcUV3Hmp9Dpt0jclmorBUpL6d5azJYyQZobFZ9ALzsABY5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MDZ3AMGN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MDZ3AMGN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45449C19423; Tue, 10 Mar 2026 08:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773131050; bh=X93Yxq3bUx636kMPKo1AS2iratZcYw/WWrjo9W6vW9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MDZ3AMGNrWWJr5OO/Vv7W7DPwZ840Y/Cw7CurnzVxWroksyoh8Dqe9AaGC4rCwprR NqqY9Axsh71dzpfh/4oGqBvaF+Mn7OjU63cNLDMV2IiIlSl9ByjqLa+7gyOb/wv5nZ iacizi1sBrvWpHv/TDBzI0FP41KgS5/iGVGJ325LoczzcdDF4PTj0OUmmlD60bnk/S QA1dgecDr2zleSU8epPC5M0Hwy1fWWF7EDqo+stAapt5cBUdhxcbJVfsOEBDUJH3I1 EMkDhDZBZQv1AXbKrsoGqoxmueiwb3LLHV+6ScLghnJM43vV5vKNlOV9ZyElByVpmF eUdQ3lYXxYQTg== Date: Tue, 10 Mar 2026 09:24:08 +0100 From: Krzysztof Kozlowski To: Caleb James DeLisle Cc: linux-mips@vger.kernel.org, naseefkm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, tsbogend@alpha.franken.de, ryder.lee@mediatek.com, jianjun.wang@mediatek.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, vkoul@kernel.org, neil.armstrong@linaro.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, nbd@nbd.name, ansuelsmth@gmail.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/8] dt-bindings: phy: Document PCIe PHY in EcoNet EN751221 and EN7528 Message-ID: <20260310-scrupulous-fat-ara-eab47c@quoll> References: <20260309131818.74467-1-cjd@cjdns.fr> <20260309131818.74467-4-cjd@cjdns.fr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260309131818.74467-4-cjd@cjdns.fr> On Mon, Mar 09, 2026 at 01:18:13PM +0000, Caleb James DeLisle wrote: > EN751221 and EN7528 SoCs have two PCIe slots, and each one has a PHY > which behaves slightly differently because one slot is Gen1/Gen2 while > the other is Gen1 only. > > Signed-off-by: Caleb James DeLisle Still, four separate subsystems unnecessarily merged into one patchset. Split independent parts of your work per subsystem. See also submitting patches. > --- > .../phy/econet,en751221-pcie-phy.yaml | 50 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/econet,en751221-pcie-phy.yaml Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof