From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D565F29C35A for ; Wed, 11 Mar 2026 03:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199063; cv=none; b=Azr4yqBEacTheL0FeOxdFjIpG2Di4bBmzzM/8+ZtfB0cqCnws+SMW4mYO3fTCOv4CvHjQkJ9IMYg47ZeaLsUIljuqXrraWPsA0u+1ixF+dXOoRpcZI8qYub+Wfd2sBeIe+libr5LVid2JIujLNZwpJftUeYaZX4eWas00BphI2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773199063; c=relaxed/simple; bh=9oo8f816zUb8gdoM9br7bk+Bv4pQ1YUHqKG/Gnd1WLI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V1FCr0Ef53SGhdRiSMrOXH/II9EZG8ZWNhpv3MmhcT8JGh8bNS/E9W3pDDVk9l/SKc2JdiRFmruQk1r3IKJHOO4crz8lIjB0sfpMt9YhFrKeXwlQ7pliR40NeWKwaaPaNFZn5QIo3kghH8PGoLyGM39fMqwqUkDNBUCPH+n3x3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nfpQZjZf; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nfpQZjZf" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-829afe24fb5so3026567b3a.0 for ; Tue, 10 Mar 2026 20:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773199062; x=1773803862; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9oo8f816zUb8gdoM9br7bk+Bv4pQ1YUHqKG/Gnd1WLI=; b=nfpQZjZfY6X76Hb1dyvwJLVEXYQv+4MCXo1Q6Jm8SqZmQXQWUa1rVko+T5WLjqrAll cAT4rjT5d+y20Vavldb1mSyRgiqjNtNaTsN22EpX6FRf+mIWEsXfUhV3c5Uxi2s7V//x SUfj56KVE/+VaYsvbX77PzzQZwMZCXl1w4BUs0YGyC+UEPrqp5blAeELCt/Mfc1xuKIr l2l6HPl3ACm8sAdW8JqHXdkwiZpda6LUyDiSb/HQrQgsitKhSNpqZssfkNUKosNg89tT nHDBs+qIWQw0bOw1UHGYUxjDp4au9Vujcamkc4jXQ0oqs9bRQSK628P9e189Q5UDrbJg ptYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773199062; x=1773803862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9oo8f816zUb8gdoM9br7bk+Bv4pQ1YUHqKG/Gnd1WLI=; b=OWBHZap2M0PFKS3S0Iyyc7W8sCax3x/bRQLGzrDW88/Z022eH3ZSUnxL6pyu/GUFu0 gKRk6Um2RC+ZN3hXM3KYoHwNqvRoVx4O6dBZ6sgSCJnCYJHZdyA8xeHoYArRaO8r63k+ ZoXQdZrp9vOxfNmE4c0daxLxAaMWemXtQ+go7/t/wTb8o3ibMiTmMmG561KKOcoNNa6C 3Qbf9ZgopTj5yQA88F0IMaf/aa+G7kHfY/dX0K2wdny2OxMr5Pvo/3syWunb22PVYxrc 3zDA0hOuz0aTwIzP1KVMf572HMbt3r9MrpWEgKxt4B7z0J+ARWTXj6YaeIoVHPIiOJFZ 4+gA== X-Forwarded-Encrypted: i=1; AJvYcCVA0XpZJDvvpEkTAPoM8lSOlvMCDuI1ff56KSMPXy3ighfRQ4cmUtjooz1mGRzhB52GV1Oh9SjkAzEo@vger.kernel.org X-Gm-Message-State: AOJu0YzB06FHJWJ18tG+4YQYHBJfKG07EVr8P19KGSn/jh2gM9FEUD6C X90WrXZQUvPI7W8dTUboZPxuLG2y7CIqmB4JOQFEJOhqTl93PtZwp087 X-Gm-Gg: ATEYQzzjKaZMOjbIvjUNfSG7MjfmcYUSnCQhgwGLb8va1dkdM/oma69IIvCdNP8/65o 8B5AiyOJBkI8zblILY8x1to2V0fa/Wj4J3KUQmoA8kI55+SOIYsEc+p1zFmqarNXyO3dLWsjnG2 +6toavv3DbfU/vxwC0D6VKGdtyiPShpA/PhB80SjN7C8ABYKpEzpb+B6kGDtKuh2djZdxq51k6/ BJ1WjF1f1517PyuYA1ZD3Ci5HkDdtvjZ8u4Ylk+QcQlGICwfmmM6D/oFX/guUhbh5HIpgqdSuCy BPryLIAg4fHspSZ9sSqn3RsUUXv0VGD4grtgad1pxxeeSCOzlfI6vZy24sH5HOzgoZcVf89Rl5e zn2y7Z1DdkrEpPqckJyd9VeeRvHfuqMwezmuylKSEh8GS/4PgUG5lUFYAjA1Fn/z6BWiY1Xpgo4 MXVMw57STw151lrunjM3MyG+pPnBj4y2jb3+CfARR5gcNkJGrs3Xm839iyMG8zezYBgNI+GEHmE 76Yeg== X-Received: by 2002:a05:6a20:938a:b0:398:6461:6888 with SMTP id adf61e73a8af0-398c615d5f8mr835628637.60.1773199062154; Tue, 10 Mar 2026 20:17:42 -0700 (PDT) Received: from localhost.localdomain ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829f6df3417sm711651b3a.19.2026.03.10.20.17.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 10 Mar 2026 20:17:41 -0700 (PDT) From: phucduc.bui@gmail.com To: dmitry.torokhov@gmail.com Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, marex@denx.de, mingo@kernel.org, mwelling@ieee.org, phucduc.bui@gmail.com, robh@kernel.org, tglx@kernel.org Subject: [PATCH 2/2] Input: Touchscreen: tsc200x - delegate wakeup IRQ Date: Wed, 11 Mar 2026 10:17:35 +0700 Message-Id: <20260311031735.2044-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dmitry, > Sorry, but this just makes it all worse. There is no downside from > letting the driver to control wakeup if it wants to, so I'd rather leave > it as it was, at least for now. Thanks you for your reply I was thinking that the code might be simplified by removing ts->wake_irq_enabled. In resume(), we could just check device_may_wakeup(dev) before calling disable_irq_wake(ts->irq). From what I can see, wake_irq_enabled is only used there, so it seems redundant. I don't have the hardware to test this right now, so I didn't try the change myself. Do you think it would make sense to remove this field? Best regards, Phuc