From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB6E378D74; Wed, 11 Mar 2026 22:11:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773267077; cv=none; b=V3+IBEeHq79t6BaE6eMtaq1e8Ov51cSEf/7Q8mbPbvtN3Bt26p8qnpGnHKnD1zNTww6ypwFEaaS1oU5UnsVO/sJjaXQ4mEr9CpN4blPCGOSa1zgFZirBHZsvidKvYFQaI5DeL/XWBJn6/+eZSDVwWknt/zbQiu7m2WcB+lrVWGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773267077; c=relaxed/simple; bh=khlI1DVyLEdkGQTJL55L84uDojA4mCd8tZUSWPV72Fo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OrcTjMKIc1mBdDbEb1U1kvV5lvpP6JUQMPFJNtyHTOVZHH3bNPE/UajgvovuivJd0elM3P+UiOcViWVMLlFogRTJWga2y9Kz+HHJr+XxSiXBeVO3BWolMujgfRGJqa0QL3Y23etDbu25uWeLL/J1CFhXAZ3iHhsxEWLh9//06GI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t88SZAwC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t88SZAwC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F0C0C4CEF7; Wed, 11 Mar 2026 22:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773267076; bh=khlI1DVyLEdkGQTJL55L84uDojA4mCd8tZUSWPV72Fo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t88SZAwCQTdLx7TVG9wnCq2c0qzcjkLnjKP6bQiTn8teXv7+/3ZX34lqOVPp3AGn9 sA8Nj7NwCitdaiO7m+i2UWk3AOtldBQt6kyDkBK8AhrFsMAV9jtBmRRuNJtFJImsgd UJZ3HuWpjKZpnx3mD9MoJ6oQyYOjwu9mpZQ7AnhmJYBdsypLwDH4MfS6n4LKmzquLp Wfb2lFY3cfEcFAR90wHwTI+fBjB0Byyp4bWmAhdm6gDopKFnn5mTocApEhxrfH0fbL nUZRYtr4LSLNR6fJdFWoAWe0n6uoQ/mSsTTdoqDA+6iqJDuHvB8JiLYYQrLjwQ/05B GGtgZS54UoneA== Date: Wed, 11 Mar 2026 17:11:15 -0500 From: Rob Herring To: Svyatoslav Ryhel Cc: Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Liam Girdwood , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Chanwoo Choi , Alexandre Belloni , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v3 2/6] dt-binding: pinctrl: pinctrl-max77620: convert to DT schema Message-ID: <20260311221115.GA775894-robh@kernel.org> References: <20260306133351.31589-1-clamor95@gmail.com> <20260306133351.31589-3-clamor95@gmail.com> <20260307-smiling-coyote-of-economy-317afe@quoll> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Mar 07, 2026 at 03:30:21PM +0200, Svyatoslav Ryhel wrote: > сб, 7 бер. 2026 р. о 14:48 Krzysztof Kozlowski пише: > > > > On Fri, Mar 06, 2026 at 03:33:47PM +0200, Svyatoslav Ryhel wrote: > > > Convert pinctrl-max77620 devicetree bindings for the MAX77620 PMIC from > > > TXT to YAML format. This patch does not change any functionality; the > > > bindings remain the same. > > > > > > Signed-off-by: Svyatoslav Ryhel > > > --- > > > .../pinctrl/maxim,max77620-pinctrl.yaml | 97 +++++++++++++ > > > .../bindings/pinctrl/pinctrl-max77620.txt | 127 ------------------ > > > 2 files changed, 97 insertions(+), 127 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/pinctrl/maxim,max77620-pinctrl.yaml > > > delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-max77620.txt > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/maxim,max77620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/maxim,max77620-pinctrl.yaml > > > new file mode 100644 > > > index 000000000000..7364a8bdd7d3 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/pinctrl/maxim,max77620-pinctrl.yaml > > > @@ -0,0 +1,97 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/pinctrl/maxim,max77620-pinctrl.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Pinmux controller function for Maxim MAX77620 Power management IC > > > + > > > +maintainers: > > > + - Svyatoslav Ryhel > > > + > > > +description: > > > + Device has 8 GPIO pins which can be configured as GPIO as well as the > > > + special IO functions. > > > + > > > +allOf: > > > + - $ref: /schemas/pinctrl/pincfg-node.yaml > > > + - $ref: /schemas/pinctrl/pinmux-node.yaml > > > + > > > +patternProperties: > > > + "^(pin_gpio|gpio)[0-7_]+$": > > > > Underscores are not allowed in general, so pattern needs fixes. Does > > anything actually rely on this name? Is this ABI? I don't see old > > binding and driver using the name, thus this should be just ^pin-[0-7]$ > > (+ is also not correct if you have max 8 gpios) > > > > Old txt schema uses pin_gpio[0-7] hence it is here, but greping trees > did not reveal use of pin_gpio so it may be dropped. > > No this is not ABI, name may be any. Including gpio0-1-2-3, gpio2-4 > etc which is why + is there. or maybe you know better way to cover > those names? > > There are device trees which use gpio5_6 with the underscore > (tegra210-smaug.dts; tegra210-p2894.dtsi for example). Should the > schema account for those? Defining a specific pattern looks like an endorsement of the name. I would just do the minimum you need. Something like '^(pin|gpio).' unless you have a pinctrl-* property. Rob