* [PATCH v1 0/2] bus: Remove Baikal SoC pieces
@ 2026-02-27 7:26 Andy Shevchenko
2026-02-27 7:26 ` [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Andy Shevchenko @ 2026-02-27 7:26 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Philipp Zabel,
Randy Dunlap, Andy Shevchenko
Baikal SoC and platform support won't be finalised, remove stale pieces.
Andy Shevchenko (2):
bus: Remove not-going-to-be-supported code for Baikal SoC
dt-bindings: bus: Remove unused bindings
.../bindings/bus/baikal,bt1-apb.yaml | 90 ----
.../bindings/bus/baikal,bt1-axi.yaml | 107 -----
drivers/bus/Kconfig | 30 --
drivers/bus/Makefile | 2 -
drivers/bus/bt1-apb.c | 396 ------------------
drivers/bus/bt1-axi.c | 292 -------------
6 files changed, 917 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
delete mode 100644 drivers/bus/bt1-apb.c
delete mode 100644 drivers/bus/bt1-axi.c
--
2.50.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC
2026-02-27 7:26 [PATCH v1 0/2] bus: Remove Baikal SoC pieces Andy Shevchenko
@ 2026-02-27 7:26 ` Andy Shevchenko
2026-02-27 7:37 ` Randy Dunlap
2026-02-27 7:26 ` [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings Andy Shevchenko
2026-03-11 22:43 ` [PATCH v1 0/2] bus: Remove Baikal SoC pieces Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2026-02-27 7:26 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Philipp Zabel,
Randy Dunlap, Andy Shevchenko
As noticed in the discussion [1] the Baikal SoC and platforms
are not going to be finalized, hence remove stale code.
Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/bus/Kconfig | 30 ----
drivers/bus/Makefile | 2 -
drivers/bus/bt1-apb.c | 396 ------------------------------------------
drivers/bus/bt1-axi.c | 292 -------------------------------
4 files changed, 720 deletions(-)
delete mode 100644 drivers/bus/bt1-apb.c
delete mode 100644 drivers/bus/bt1-axi.c
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 2a1b46f07080..5a7361c81be5 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -38,36 +38,6 @@ config BRCMSTB_GISB_ARB
arbiter. This driver provides timeout and target abort error handling
and internal bus master decoding.
-config BT1_APB
- bool "Baikal-T1 APB-bus driver"
- depends on MIPS_BAIKAL_T1 || COMPILE_TEST
- select REGMAP_MMIO
- help
- Baikal-T1 AXI-APB bridge is used to access the SoC subsystem CSRs.
- IO requests are routed to this bus by means of the DW AMBA 3 AXI
- Interconnect. In case of any APB protocol collisions, slave device
- not responding on timeout an IRQ is raised with an erroneous address
- reported to the APB terminator (APB Errors Handler Block). This
- driver provides the interrupt handler to detect the erroneous
- address, prints an error message about the address fault, updates an
- errors counter. The counter and the APB-bus operations timeout can be
- accessed via corresponding sysfs nodes.
-
-config BT1_AXI
- bool "Baikal-T1 AXI-bus driver"
- depends on MIPS_BAIKAL_T1 || COMPILE_TEST
- select MFD_SYSCON
- help
- AXI3-bus is the main communication bus connecting all high-speed
- peripheral IP-cores with RAM controller and with MIPS P5600 cores on
- Baikal-T1 SoC. Traffic arbitration is done by means of DW AMBA 3 AXI
- Interconnect (so called AXI Main Interconnect) routing IO requests
- from one SoC block to another. This driver provides a way to detect
- any bus protocol errors and device not responding situations by
- means of an embedded on top of the interconnect errors handler
- block (EHB). AXI Interconnect QoS arbitration tuning is currently
- unsupported.
-
config MOXTET
tristate "CZ.NIC Turris Mox module configuration bus"
depends on SPI_MASTER && OF
diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index 8e693fe8a03a..768a27e96276 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -13,8 +13,6 @@ obj-$(CONFIG_MOXTET) += moxtet.o
# DPAA2 fsl-mc bus
obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/
-obj-$(CONFIG_BT1_APB) += bt1-apb.o
-obj-$(CONFIG_BT1_AXI) += bt1-axi.o
obj-$(CONFIG_IMX_AIPSTZ) += imx-aipstz.o
obj-$(CONFIG_IMX_WEIM) += imx-weim.o
obj-$(CONFIG_INTEL_IXP4XX_EB) += intel-ixp4xx-eb.o
diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
deleted file mode 100644
index 7463124b6dd9..000000000000
--- a/drivers/bus/bt1-apb.c
+++ /dev/null
@@ -1,396 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
- *
- * Authors:
- * Serge Semin <Sergey.Semin@baikalelectronics.ru>
- *
- * Baikal-T1 APB-bus driver
- */
-
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/types.h>
-#include <linux/device.h>
-#include <linux/atomic.h>
-#include <linux/platform_device.h>
-#include <linux/interrupt.h>
-#include <linux/io.h>
-#include <linux/nmi.h>
-#include <linux/of.h>
-#include <linux/regmap.h>
-#include <linux/clk.h>
-#include <linux/reset.h>
-#include <linux/time64.h>
-#include <linux/sysfs.h>
-
-#define APB_EHB_ISR 0x00
-#define APB_EHB_ISR_PENDING BIT(0)
-#define APB_EHB_ISR_MASK BIT(1)
-#define APB_EHB_ADDR 0x04
-#define APB_EHB_TIMEOUT 0x08
-
-#define APB_EHB_TIMEOUT_MIN 0x000003FFU
-#define APB_EHB_TIMEOUT_MAX 0xFFFFFFFFU
-
-/*
- * struct bt1_apb - Baikal-T1 APB EHB private data
- * @dev: Pointer to the device structure.
- * @regs: APB EHB registers map.
- * @res: No-device error injection memory region.
- * @irq: Errors IRQ number.
- * @rate: APB-bus reference clock rate.
- * @pclk: APB-reference clock.
- * @prst: APB domain reset line.
- * @count: Number of errors detected.
- */
-struct bt1_apb {
- struct device *dev;
-
- struct regmap *regs;
- void __iomem *res;
- int irq;
-
- unsigned long rate;
- struct clk *pclk;
-
- struct reset_control *prst;
-
- atomic_t count;
-};
-
-static const struct regmap_config bt1_apb_regmap_cfg = {
- .reg_bits = 32,
- .val_bits = 32,
- .reg_stride = 4,
- .max_register = APB_EHB_TIMEOUT,
- .fast_io = true
-};
-
-static inline unsigned long bt1_apb_n_to_timeout_us(struct bt1_apb *apb, u32 n)
-{
- u64 timeout = (u64)n * USEC_PER_SEC;
-
- do_div(timeout, apb->rate);
-
- return timeout;
-
-}
-
-static inline unsigned long bt1_apb_timeout_to_n_us(struct bt1_apb *apb,
- unsigned long timeout)
-{
- u64 n = (u64)timeout * apb->rate;
-
- do_div(n, USEC_PER_SEC);
-
- return n;
-
-}
-
-static irqreturn_t bt1_apb_isr(int irq, void *data)
-{
- struct bt1_apb *apb = data;
- u32 addr = 0;
-
- regmap_read(apb->regs, APB_EHB_ADDR, &addr);
-
- dev_crit_ratelimited(apb->dev,
- "APB-bus fault %d: Slave access timeout at 0x%08x\n",
- atomic_inc_return(&apb->count),
- addr);
-
- /*
- * Print backtrace on each CPU. This might be pointless if the fault
- * has happened on the same CPU as the IRQ handler is executed or
- * the other core proceeded further execution despite the error.
- * But if it's not, by looking at the trace we would get straight to
- * the cause of the problem.
- */
- trigger_all_cpu_backtrace();
-
- regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING, 0);
-
- return IRQ_HANDLED;
-}
-
-static void bt1_apb_clear_data(void *data)
-{
- struct bt1_apb *apb = data;
- struct platform_device *pdev = to_platform_device(apb->dev);
-
- platform_set_drvdata(pdev, NULL);
-}
-
-static struct bt1_apb *bt1_apb_create_data(struct platform_device *pdev)
-{
- struct device *dev = &pdev->dev;
- struct bt1_apb *apb;
- int ret;
-
- apb = devm_kzalloc(dev, sizeof(*apb), GFP_KERNEL);
- if (!apb)
- return ERR_PTR(-ENOMEM);
-
- ret = devm_add_action(dev, bt1_apb_clear_data, apb);
- if (ret) {
- dev_err(dev, "Can't add APB EHB data clear action\n");
- return ERR_PTR(ret);
- }
-
- apb->dev = dev;
- atomic_set(&apb->count, 0);
- platform_set_drvdata(pdev, apb);
-
- return apb;
-}
-
-static int bt1_apb_request_regs(struct bt1_apb *apb)
-{
- struct platform_device *pdev = to_platform_device(apb->dev);
- void __iomem *regs;
-
- regs = devm_platform_ioremap_resource_byname(pdev, "ehb");
- if (IS_ERR(regs)) {
- dev_err(apb->dev, "Couldn't map APB EHB registers\n");
- return PTR_ERR(regs);
- }
-
- apb->regs = devm_regmap_init_mmio(apb->dev, regs, &bt1_apb_regmap_cfg);
- if (IS_ERR(apb->regs)) {
- dev_err(apb->dev, "Couldn't create APB EHB regmap\n");
- return PTR_ERR(apb->regs);
- }
-
- apb->res = devm_platform_ioremap_resource_byname(pdev, "nodev");
- if (IS_ERR(apb->res))
- dev_err(apb->dev, "Couldn't map reserved region\n");
-
- return PTR_ERR_OR_ZERO(apb->res);
-}
-
-static int bt1_apb_request_rst(struct bt1_apb *apb)
-{
- int ret;
-
- apb->prst = devm_reset_control_get_optional_exclusive(apb->dev, "prst");
- if (IS_ERR(apb->prst))
- return dev_err_probe(apb->dev, PTR_ERR(apb->prst),
- "Couldn't get reset control line\n");
-
- ret = reset_control_deassert(apb->prst);
- if (ret)
- dev_err(apb->dev, "Failed to deassert the reset line\n");
-
- return ret;
-}
-
-static int bt1_apb_request_clk(struct bt1_apb *apb)
-{
- apb->pclk = devm_clk_get_enabled(apb->dev, "pclk");
- if (IS_ERR(apb->pclk))
- return dev_err_probe(apb->dev, PTR_ERR(apb->pclk),
- "Couldn't get APB clock descriptor\n");
-
- apb->rate = clk_get_rate(apb->pclk);
- if (!apb->rate) {
- dev_err(apb->dev, "Invalid clock rate\n");
- return -EINVAL;
- }
-
- return 0;
-}
-
-static void bt1_apb_clear_irq(void *data)
-{
- struct bt1_apb *apb = data;
-
- regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_MASK, 0);
-}
-
-static int bt1_apb_request_irq(struct bt1_apb *apb)
-{
- struct platform_device *pdev = to_platform_device(apb->dev);
- int ret;
-
- apb->irq = platform_get_irq(pdev, 0);
- if (apb->irq < 0)
- return apb->irq;
-
- ret = devm_request_irq(apb->dev, apb->irq, bt1_apb_isr, IRQF_SHARED,
- "bt1-apb", apb);
- if (ret) {
- dev_err(apb->dev, "Couldn't request APB EHB IRQ\n");
- return ret;
- }
-
- ret = devm_add_action(apb->dev, bt1_apb_clear_irq, apb);
- if (ret) {
- dev_err(apb->dev, "Can't add APB EHB IRQs clear action\n");
- return ret;
- }
-
- /* Unmask IRQ and clear it' pending flag. */
- regmap_update_bits(apb->regs, APB_EHB_ISR,
- APB_EHB_ISR_PENDING | APB_EHB_ISR_MASK,
- APB_EHB_ISR_MASK);
-
- return 0;
-}
-
-static ssize_t count_show(struct device *dev, struct device_attribute *attr,
- char *buf)
-{
- struct bt1_apb *apb = dev_get_drvdata(dev);
-
- return scnprintf(buf, PAGE_SIZE, "%d\n", atomic_read(&apb->count));
-}
-static DEVICE_ATTR_RO(count);
-
-static ssize_t timeout_show(struct device *dev, struct device_attribute *attr,
- char *buf)
-{
- struct bt1_apb *apb = dev_get_drvdata(dev);
- unsigned long timeout;
- int ret;
- u32 n;
-
- ret = regmap_read(apb->regs, APB_EHB_TIMEOUT, &n);
- if (ret)
- return ret;
-
- timeout = bt1_apb_n_to_timeout_us(apb, n);
-
- return scnprintf(buf, PAGE_SIZE, "%lu\n", timeout);
-}
-
-static ssize_t timeout_store(struct device *dev,
- struct device_attribute *attr,
- const char *buf, size_t count)
-{
- struct bt1_apb *apb = dev_get_drvdata(dev);
- unsigned long timeout;
- int ret;
- u32 n;
-
- if (kstrtoul(buf, 0, &timeout) < 0)
- return -EINVAL;
-
- n = bt1_apb_timeout_to_n_us(apb, timeout);
- n = clamp(n, APB_EHB_TIMEOUT_MIN, APB_EHB_TIMEOUT_MAX);
-
- ret = regmap_write(apb->regs, APB_EHB_TIMEOUT, n);
-
- return ret ?: count;
-}
-static DEVICE_ATTR_RW(timeout);
-
-static ssize_t inject_error_show(struct device *dev,
- struct device_attribute *attr, char *buf)
-{
- return scnprintf(buf, PAGE_SIZE, "Error injection: nodev irq\n");
-}
-
-static ssize_t inject_error_store(struct device *dev,
- struct device_attribute *attr,
- const char *data, size_t count)
-{
- struct bt1_apb *apb = dev_get_drvdata(dev);
-
- /*
- * Either dummy read from the unmapped address in the APB IO area
- * or manually set the IRQ status.
- */
- if (sysfs_streq(data, "nodev"))
- readl(apb->res);
- else if (sysfs_streq(data, "irq"))
- regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
- APB_EHB_ISR_PENDING);
- else
- return -EINVAL;
-
- return count;
-}
-static DEVICE_ATTR_RW(inject_error);
-
-static struct attribute *bt1_apb_sysfs_attrs[] = {
- &dev_attr_count.attr,
- &dev_attr_timeout.attr,
- &dev_attr_inject_error.attr,
- NULL
-};
-ATTRIBUTE_GROUPS(bt1_apb_sysfs);
-
-static void bt1_apb_remove_sysfs(void *data)
-{
- struct bt1_apb *apb = data;
-
- device_remove_groups(apb->dev, bt1_apb_sysfs_groups);
-}
-
-static int bt1_apb_init_sysfs(struct bt1_apb *apb)
-{
- int ret;
-
- ret = device_add_groups(apb->dev, bt1_apb_sysfs_groups);
- if (ret) {
- dev_err(apb->dev, "Failed to create EHB APB sysfs nodes\n");
- return ret;
- }
-
- ret = devm_add_action_or_reset(apb->dev, bt1_apb_remove_sysfs, apb);
- if (ret)
- dev_err(apb->dev, "Can't add APB EHB sysfs remove action\n");
-
- return ret;
-}
-
-static int bt1_apb_probe(struct platform_device *pdev)
-{
- struct bt1_apb *apb;
- int ret;
-
- apb = bt1_apb_create_data(pdev);
- if (IS_ERR(apb))
- return PTR_ERR(apb);
-
- ret = bt1_apb_request_regs(apb);
- if (ret)
- return ret;
-
- ret = bt1_apb_request_rst(apb);
- if (ret)
- return ret;
-
- ret = bt1_apb_request_clk(apb);
- if (ret)
- return ret;
-
- ret = bt1_apb_request_irq(apb);
- if (ret)
- return ret;
-
- ret = bt1_apb_init_sysfs(apb);
- if (ret)
- return ret;
-
- return 0;
-}
-
-static const struct of_device_id bt1_apb_of_match[] = {
- { .compatible = "baikal,bt1-apb" },
- { }
-};
-MODULE_DEVICE_TABLE(of, bt1_apb_of_match);
-
-static struct platform_driver bt1_apb_driver = {
- .probe = bt1_apb_probe,
- .driver = {
- .name = "bt1-apb",
- .of_match_table = bt1_apb_of_match
- }
-};
-module_platform_driver(bt1_apb_driver);
-
-MODULE_AUTHOR("Serge Semin <Sergey.Semin@baikalelectronics.ru>");
-MODULE_DESCRIPTION("Baikal-T1 APB-bus driver");
diff --git a/drivers/bus/bt1-axi.c b/drivers/bus/bt1-axi.c
deleted file mode 100644
index a5254c73bf43..000000000000
--- a/drivers/bus/bt1-axi.c
+++ /dev/null
@@ -1,292 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
- *
- * Authors:
- * Serge Semin <Sergey.Semin@baikalelectronics.ru>
- *
- * Baikal-T1 AXI-bus driver
- */
-
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/types.h>
-#include <linux/bitfield.h>
-#include <linux/device.h>
-#include <linux/atomic.h>
-#include <linux/regmap.h>
-#include <linux/platform_device.h>
-#include <linux/mfd/syscon.h>
-#include <linux/interrupt.h>
-#include <linux/io.h>
-#include <linux/nmi.h>
-#include <linux/of.h>
-#include <linux/clk.h>
-#include <linux/reset.h>
-#include <linux/sysfs.h>
-
-#define BT1_AXI_WERRL 0x110
-#define BT1_AXI_WERRH 0x114
-#define BT1_AXI_WERRH_TYPE BIT(23)
-#define BT1_AXI_WERRH_ADDR_FLD 24
-#define BT1_AXI_WERRH_ADDR_MASK GENMASK(31, BT1_AXI_WERRH_ADDR_FLD)
-
-/*
- * struct bt1_axi - Baikal-T1 AXI-bus private data
- * @dev: Pointer to the device structure.
- * @qos_regs: AXI Interconnect QoS tuning registers.
- * @sys_regs: Baikal-T1 System Controller registers map.
- * @irq: Errors IRQ number.
- * @aclk: AXI reference clock.
- * @arst: AXI Interconnect reset line.
- * @count: Number of errors detected.
- */
-struct bt1_axi {
- struct device *dev;
-
- void __iomem *qos_regs;
- struct regmap *sys_regs;
- int irq;
-
- struct clk *aclk;
-
- struct reset_control *arst;
-
- atomic_t count;
-};
-
-static irqreturn_t bt1_axi_isr(int irq, void *data)
-{
- struct bt1_axi *axi = data;
- u32 low = 0, high = 0;
-
- regmap_read(axi->sys_regs, BT1_AXI_WERRL, &low);
- regmap_read(axi->sys_regs, BT1_AXI_WERRH, &high);
-
- dev_crit_ratelimited(axi->dev,
- "AXI-bus fault %d: %s at 0x%x%08x\n",
- atomic_inc_return(&axi->count),
- high & BT1_AXI_WERRH_TYPE ? "no slave" : "slave protocol error",
- high, low);
-
- /*
- * Print backtrace on each CPU. This might be pointless if the fault
- * has happened on the same CPU as the IRQ handler is executed or
- * the other core proceeded further execution despite the error.
- * But if it's not, by looking at the trace we would get straight to
- * the cause of the problem.
- */
- trigger_all_cpu_backtrace();
-
- return IRQ_HANDLED;
-}
-
-static void bt1_axi_clear_data(void *data)
-{
- struct bt1_axi *axi = data;
- struct platform_device *pdev = to_platform_device(axi->dev);
-
- platform_set_drvdata(pdev, NULL);
-}
-
-static struct bt1_axi *bt1_axi_create_data(struct platform_device *pdev)
-{
- struct device *dev = &pdev->dev;
- struct bt1_axi *axi;
- int ret;
-
- axi = devm_kzalloc(dev, sizeof(*axi), GFP_KERNEL);
- if (!axi)
- return ERR_PTR(-ENOMEM);
-
- ret = devm_add_action(dev, bt1_axi_clear_data, axi);
- if (ret) {
- dev_err(dev, "Can't add AXI EHB data clear action\n");
- return ERR_PTR(ret);
- }
-
- axi->dev = dev;
- atomic_set(&axi->count, 0);
- platform_set_drvdata(pdev, axi);
-
- return axi;
-}
-
-static int bt1_axi_request_regs(struct bt1_axi *axi)
-{
- struct platform_device *pdev = to_platform_device(axi->dev);
- struct device *dev = axi->dev;
-
- axi->sys_regs = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon");
- if (IS_ERR(axi->sys_regs)) {
- dev_err(dev, "Couldn't find syscon registers\n");
- return PTR_ERR(axi->sys_regs);
- }
-
- axi->qos_regs = devm_platform_ioremap_resource_byname(pdev, "qos");
- if (IS_ERR(axi->qos_regs))
- dev_err(dev, "Couldn't map AXI-bus QoS registers\n");
-
- return PTR_ERR_OR_ZERO(axi->qos_regs);
-}
-
-static int bt1_axi_request_rst(struct bt1_axi *axi)
-{
- int ret;
-
- axi->arst = devm_reset_control_get_optional_exclusive(axi->dev, "arst");
- if (IS_ERR(axi->arst))
- return dev_err_probe(axi->dev, PTR_ERR(axi->arst),
- "Couldn't get reset control line\n");
-
- ret = reset_control_deassert(axi->arst);
- if (ret)
- dev_err(axi->dev, "Failed to deassert the reset line\n");
-
- return ret;
-}
-
-static int bt1_axi_request_clk(struct bt1_axi *axi)
-{
- axi->aclk = devm_clk_get_enabled(axi->dev, "aclk");
- if (IS_ERR(axi->aclk))
- return dev_err_probe(axi->dev, PTR_ERR(axi->aclk),
- "Couldn't get AXI Interconnect clock\n");
-
- return 0;
-}
-
-static int bt1_axi_request_irq(struct bt1_axi *axi)
-{
- struct platform_device *pdev = to_platform_device(axi->dev);
- int ret;
-
- axi->irq = platform_get_irq(pdev, 0);
- if (axi->irq < 0)
- return axi->irq;
-
- ret = devm_request_irq(axi->dev, axi->irq, bt1_axi_isr, IRQF_SHARED,
- "bt1-axi", axi);
- if (ret)
- dev_err(axi->dev, "Couldn't request AXI EHB IRQ\n");
-
- return ret;
-}
-
-static ssize_t count_show(struct device *dev,
- struct device_attribute *attr, char *buf)
-{
- struct bt1_axi *axi = dev_get_drvdata(dev);
-
- return scnprintf(buf, PAGE_SIZE, "%d\n", atomic_read(&axi->count));
-}
-static DEVICE_ATTR_RO(count);
-
-static ssize_t inject_error_show(struct device *dev,
- struct device_attribute *attr, char *buf)
-{
- return scnprintf(buf, PAGE_SIZE, "Error injection: bus unaligned\n");
-}
-
-static ssize_t inject_error_store(struct device *dev,
- struct device_attribute *attr,
- const char *data, size_t count)
-{
- struct bt1_axi *axi = dev_get_drvdata(dev);
-
- /*
- * Performing unaligned read from the memory will cause the CM2 bus
- * error while unaligned writing - the AXI bus write error handled
- * by this driver.
- */
- if (sysfs_streq(data, "bus"))
- readb(axi->qos_regs);
- else if (sysfs_streq(data, "unaligned"))
- writeb(0, axi->qos_regs);
- else
- return -EINVAL;
-
- return count;
-}
-static DEVICE_ATTR_RW(inject_error);
-
-static struct attribute *bt1_axi_sysfs_attrs[] = {
- &dev_attr_count.attr,
- &dev_attr_inject_error.attr,
- NULL
-};
-ATTRIBUTE_GROUPS(bt1_axi_sysfs);
-
-static void bt1_axi_remove_sysfs(void *data)
-{
- struct bt1_axi *axi = data;
-
- device_remove_groups(axi->dev, bt1_axi_sysfs_groups);
-}
-
-static int bt1_axi_init_sysfs(struct bt1_axi *axi)
-{
- int ret;
-
- ret = device_add_groups(axi->dev, bt1_axi_sysfs_groups);
- if (ret) {
- dev_err(axi->dev, "Failed to add sysfs files group\n");
- return ret;
- }
-
- ret = devm_add_action_or_reset(axi->dev, bt1_axi_remove_sysfs, axi);
- if (ret)
- dev_err(axi->dev, "Can't add AXI EHB sysfs remove action\n");
-
- return ret;
-}
-
-static int bt1_axi_probe(struct platform_device *pdev)
-{
- struct bt1_axi *axi;
- int ret;
-
- axi = bt1_axi_create_data(pdev);
- if (IS_ERR(axi))
- return PTR_ERR(axi);
-
- ret = bt1_axi_request_regs(axi);
- if (ret)
- return ret;
-
- ret = bt1_axi_request_rst(axi);
- if (ret)
- return ret;
-
- ret = bt1_axi_request_clk(axi);
- if (ret)
- return ret;
-
- ret = bt1_axi_request_irq(axi);
- if (ret)
- return ret;
-
- ret = bt1_axi_init_sysfs(axi);
- if (ret)
- return ret;
-
- return 0;
-}
-
-static const struct of_device_id bt1_axi_of_match[] = {
- { .compatible = "baikal,bt1-axi" },
- { }
-};
-MODULE_DEVICE_TABLE(of, bt1_axi_of_match);
-
-static struct platform_driver bt1_axi_driver = {
- .probe = bt1_axi_probe,
- .driver = {
- .name = "bt1-axi",
- .of_match_table = bt1_axi_of_match
- }
-};
-module_platform_driver(bt1_axi_driver);
-
-MODULE_AUTHOR("Serge Semin <Sergey.Semin@baikalelectronics.ru>");
-MODULE_DESCRIPTION("Baikal-T1 AXI-bus driver");
--
2.50.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings
2026-02-27 7:26 [PATCH v1 0/2] bus: Remove Baikal SoC pieces Andy Shevchenko
2026-02-27 7:26 ` [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
@ 2026-02-27 7:26 ` Andy Shevchenko
2026-02-27 7:37 ` Randy Dunlap
2026-03-11 22:43 ` [PATCH v1 0/2] bus: Remove Baikal SoC pieces Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2026-02-27 7:26 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Philipp Zabel,
Randy Dunlap, Andy Shevchenko
As stated in [1] the Baikal platforms are not supported and
the respective driver code has just been removed. Remove
unused bindings.
Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
.../bindings/bus/baikal,bt1-apb.yaml | 90 ---------------
.../bindings/bus/baikal,bt1-axi.yaml | 107 ------------------
2 files changed, 197 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
diff --git a/Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml b/Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
deleted file mode 100644
index 37ba3337f944..000000000000
--- a/Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
+++ /dev/null
@@ -1,90 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-# Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/bus/baikal,bt1-apb.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Baikal-T1 APB-bus
-
-maintainers:
- - Serge Semin <fancer.lancer@gmail.com>
-
-description: |
- Baikal-T1 CPU or DMAC MMIO requests are handled by the AMBA 3 AXI Interconnect
- which routes them to the AXI-APB bridge. This interface is a single master
- multiple slaves bus in turn serializing IO accesses and routing them to the
- addressed APB slave devices. In case of any APB protocol collisions, slave
- device not responding on timeout an IRQ is raised with an erroneous address
- reported to the APB terminator (APB Errors Handler Block).
-
-allOf:
- - $ref: /schemas/simple-bus.yaml#
-
-properties:
- compatible:
- contains:
- const: baikal,bt1-apb
-
- reg:
- items:
- - description: APB EHB MMIO registers
- - description: APB MMIO region with no any device mapped
-
- reg-names:
- items:
- - const: ehb
- - const: nodev
-
- interrupts:
- maxItems: 1
-
- clocks:
- items:
- - description: APB reference clock
-
- clock-names:
- items:
- - const: pclk
-
- resets:
- items:
- - description: APB domain reset line
-
- reset-names:
- items:
- - const: prst
-
-unevaluatedProperties: false
-
-required:
- - compatible
- - reg
- - reg-names
- - interrupts
- - clocks
- - clock-names
-
-examples:
- - |
- #include <dt-bindings/interrupt-controller/mips-gic.h>
-
- bus@1f059000 {
- compatible = "baikal,bt1-apb", "simple-bus";
- reg = <0x1f059000 0x1000>,
- <0x1d000000 0x2040000>;
- reg-names = "ehb", "nodev";
- #address-cells = <1>;
- #size-cells = <1>;
-
- ranges;
-
- interrupts = <GIC_SHARED 16 IRQ_TYPE_LEVEL_HIGH>;
-
- clocks = <&ccu_sys 1>;
- clock-names = "pclk";
-
- resets = <&ccu_sys 1>;
- reset-names = "prst";
- };
-...
diff --git a/Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml b/Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
deleted file mode 100644
index 4ac78b44e45e..000000000000
--- a/Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
+++ /dev/null
@@ -1,107 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-# Copyright (C) 2020 BAIKAL ELECTRONICS, JSC
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/bus/baikal,bt1-axi.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Baikal-T1 AXI-bus
-
-maintainers:
- - Serge Semin <fancer.lancer@gmail.com>
-
-description: |
- AXI3-bus is the main communication bus of Baikal-T1 SoC connecting all
- high-speed peripheral IP-cores with RAM controller and with MIPS P5600
- cores. Traffic arbitration is done by means of DW AXI Interconnect (so
- called AXI Main Interconnect) routing IO requests from one block to
- another: from CPU to SoC peripherals and between some SoC peripherals
- (mostly between peripheral devices and RAM, but also between DMA and
- some peripherals). In case of any protocol error, device not responding
- an IRQ is raised and a faulty situation is reported to the AXI EHB
- (Errors Handler Block) embedded on top of the DW AXI Interconnect and
- accessible by means of the Baikal-T1 System Controller.
-
-allOf:
- - $ref: /schemas/simple-bus.yaml#
-
-properties:
- compatible:
- contains:
- const: baikal,bt1-axi
-
- reg:
- minItems: 1
- items:
- - description: Synopsys DesignWare AXI Interconnect QoS registers
- - description: AXI EHB MMIO system controller registers
-
- reg-names:
- minItems: 1
- items:
- - const: qos
- - const: ehb
-
- '#interconnect-cells':
- const: 1
-
- syscon:
- $ref: /schemas/types.yaml#/definitions/phandle
- description: Phandle to the Baikal-T1 System Controller DT node
-
- interrupts:
- maxItems: 1
-
- clocks:
- items:
- - description: Main Interconnect uplink reference clock
-
- clock-names:
- items:
- - const: aclk
-
- resets:
- items:
- - description: Main Interconnect reset line
-
- reset-names:
- items:
- - const: arst
-
-unevaluatedProperties: false
-
-required:
- - compatible
- - reg
- - reg-names
- - syscon
- - interrupts
- - clocks
- - clock-names
-
-examples:
- - |
- #include <dt-bindings/interrupt-controller/mips-gic.h>
-
- bus@1f05a000 {
- compatible = "baikal,bt1-axi", "simple-bus";
- reg = <0x1f05a000 0x1000>,
- <0x1f04d110 0x8>;
- reg-names = "qos", "ehb";
- #address-cells = <1>;
- #size-cells = <1>;
- #interconnect-cells = <1>;
-
- syscon = <&syscon>;
-
- ranges;
-
- interrupts = <GIC_SHARED 127 IRQ_TYPE_LEVEL_HIGH>;
-
- clocks = <&ccu_axi 0>;
- clock-names = "aclk";
-
- resets = <&ccu_axi 0>;
- reset-names = "arst";
- };
-...
--
2.50.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings
2026-02-27 7:26 ` [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings Andy Shevchenko
@ 2026-02-27 7:37 ` Randy Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2026-02-27 7:37 UTC (permalink / raw)
To: Andy Shevchenko, devicetree, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Philipp Zabel
On 2/26/26 11:26 PM, Andy Shevchenko wrote:
> As stated in [1] the Baikal platforms are not supported and
> the respective driver code has just been removed. Remove
> unused bindings.
>
> Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> .../bindings/bus/baikal,bt1-apb.yaml | 90 ---------------
> .../bindings/bus/baikal,bt1-axi.yaml | 107 ------------------
> 2 files changed, 197 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-apb.yaml
> delete mode 100644 Documentation/devicetree/bindings/bus/baikal,bt1-axi.yaml
>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC
2026-02-27 7:26 ` [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
@ 2026-02-27 7:37 ` Randy Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2026-02-27 7:37 UTC (permalink / raw)
To: Andy Shevchenko, devicetree, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Philipp Zabel
On 2/26/26 11:26 PM, Andy Shevchenko wrote:
> As noticed in the discussion [1] the Baikal SoC and platforms
> are not going to be finalized, hence remove stale code.
>
> Link: https://lore.kernel.org/lkml/22b92ddf-6321-41b5-8073-f9c7064d3432@infradead.org/ [1]
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/bus/Kconfig | 30 ----
> drivers/bus/Makefile | 2 -
> drivers/bus/bt1-apb.c | 396 ------------------------------------------
> drivers/bus/bt1-axi.c | 292 -------------------------------
> 4 files changed, 720 deletions(-)
> delete mode 100644 drivers/bus/bt1-apb.c
> delete mode 100644 drivers/bus/bt1-axi.c
>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/2] bus: Remove Baikal SoC pieces
2026-02-27 7:26 [PATCH v1 0/2] bus: Remove Baikal SoC pieces Andy Shevchenko
2026-02-27 7:26 ` [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
2026-02-27 7:26 ` [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings Andy Shevchenko
@ 2026-03-11 22:43 ` Rob Herring
2026-03-12 9:23 ` Andy Shevchenko
2 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2026-03-11 22:43 UTC (permalink / raw)
To: Andy Shevchenko
Cc: devicetree, linux-kernel, Krzysztof Kozlowski, Conor Dooley,
Philipp Zabel, Randy Dunlap
On Fri, Feb 27, 2026 at 08:26:24AM +0100, Andy Shevchenko wrote:
> Baikal SoC and platform support won't be finalised, remove stale pieces.
>
> Andy Shevchenko (2):
> bus: Remove not-going-to-be-supported code for Baikal SoC
> dt-bindings: bus: Remove unused bindings
As there doesn't seem to be a maintainer for drivers/bus/, I just took
both patches.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 0/2] bus: Remove Baikal SoC pieces
2026-03-11 22:43 ` [PATCH v1 0/2] bus: Remove Baikal SoC pieces Rob Herring
@ 2026-03-12 9:23 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2026-03-12 9:23 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Krzysztof Kozlowski, Conor Dooley,
Philipp Zabel, Randy Dunlap
On Wed, Mar 11, 2026 at 05:43:56PM -0500, Rob Herring wrote:
> On Fri, Feb 27, 2026 at 08:26:24AM +0100, Andy Shevchenko wrote:
> > Baikal SoC and platform support won't be finalised, remove stale pieces.
> >
> > Andy Shevchenko (2):
> > bus: Remove not-going-to-be-supported code for Baikal SoC
> > dt-bindings: bus: Remove unused bindings
>
> As there doesn't seem to be a maintainer for drivers/bus/, I just took
> both patches.
Merci!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-03-12 9:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 7:26 [PATCH v1 0/2] bus: Remove Baikal SoC pieces Andy Shevchenko
2026-02-27 7:26 ` [PATCH v1 1/2] bus: Remove not-going-to-be-supported code for Baikal SoC Andy Shevchenko
2026-02-27 7:37 ` Randy Dunlap
2026-02-27 7:26 ` [PATCH v1 2/2] dt-bindings: bus: Remove unused bindings Andy Shevchenko
2026-02-27 7:37 ` Randy Dunlap
2026-03-11 22:43 ` [PATCH v1 0/2] bus: Remove Baikal SoC pieces Rob Herring
2026-03-12 9:23 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox