* [PATCH 0/2] Enable TSENS and thermal zone for SM8750 SoC
@ 2026-03-13 10:34 Gaurav Kohli
2026-03-13 10:34 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor Gaurav Kohli
2026-03-13 10:34 ` [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones Gaurav Kohli
0 siblings, 2 replies; 12+ messages in thread
From: Gaurav Kohli @ 2026-03-13 10:34 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey,
dipa.mantre, Gaurav Kohli, Manaf Meethalavalappu Pallikunhi
Adding compatible string in TSENS dt-bindings, device node
for TSENS controller and Thermal zone support.
Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
---
Manaf Meethalavalappu Pallikunhi (2):
dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor
arm64: dts: qcom: sm8750: Enable TSENS and thermal zones
.../devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++
2 files changed, 898 insertions(+)
---
base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f
change-id: 20260309-sm8750_tsens-59f9e363b996
Best regards,
--
Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor 2026-03-13 10:34 [PATCH 0/2] Enable TSENS and thermal zone for SM8750 SoC Gaurav Kohli @ 2026-03-13 10:34 ` Gaurav Kohli 2026-03-14 10:30 ` Krzysztof Kozlowski 2026-03-13 10:34 ` [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones Gaurav Kohli 1 sibling, 1 reply; 12+ messages in thread From: Gaurav Kohli @ 2026-03-13 10:34 UTC (permalink / raw) To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Gaurav Kohli, Manaf Meethalavalappu Pallikunhi From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> Document the Temperature Sensor (TSENS) on the SM8750 SoC. Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> --- Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index 3c5256b0cd9f..57f1cbb4c188 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -81,6 +81,7 @@ properties: - qcom,sm8450-tsens - qcom,sm8550-tsens - qcom,sm8650-tsens + - qcom,sm8750-tsens - qcom,x1e80100-tsens - const: qcom,tsens-v2 -- 2.34.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor 2026-03-13 10:34 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor Gaurav Kohli @ 2026-03-14 10:30 ` Krzysztof Kozlowski 2026-03-14 10:46 ` Daniel Lezcano 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2026-03-14 10:30 UTC (permalink / raw) To: Gaurav Kohli Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On Fri, Mar 13, 2026 at 04:04:17PM +0530, Gaurav Kohli wrote: > From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > > Document the Temperature Sensor (TSENS) on the SM8750 SoC. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor 2026-03-14 10:30 ` Krzysztof Kozlowski @ 2026-03-14 10:46 ` Daniel Lezcano 0 siblings, 0 replies; 12+ messages in thread From: Daniel Lezcano @ 2026-03-14 10:46 UTC (permalink / raw) To: Krzysztof Kozlowski, Gaurav Kohli Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 3/14/26 11:30, Krzysztof Kozlowski wrote: > On Fri, Mar 13, 2026 at 04:04:17PM +0530, Gaurav Kohli wrote: >> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> >> Document the Temperature Sensor (TSENS) on the SM8750 SoC. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> >> --- Applied thanks ! ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-13 10:34 [PATCH 0/2] Enable TSENS and thermal zone for SM8750 SoC Gaurav Kohli 2026-03-13 10:34 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor Gaurav Kohli @ 2026-03-13 10:34 ` Gaurav Kohli 2026-03-14 10:31 ` Krzysztof Kozlowski 2026-03-18 9:44 ` Konrad Dybcio 1 sibling, 2 replies; 12+ messages in thread From: Gaurav Kohli @ 2026-03-13 10:34 UTC (permalink / raw) To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Gaurav Kohli, Manaf Meethalavalappu Pallikunhi From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> The sm8750 includes four TSENS instances, with a total of 47 thermal sensors distributed across various locations on the SoC. The TSENS max/reset threshold is configured to 130°C in the hardware. Enable all TSENS instances, and define the thermal zones with a hot trip at 120°C and critical trip at 125°C. Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++++++++++++++++ 1 file changed, 897 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi index f56b1f889b85..db2a97cb228d 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -20,6 +20,7 @@ #include <dt-bindings/soc/qcom,gpr.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h> +#include <dt-bindings/thermal/thermal.h> / { interrupt-parent = <&intc>; @@ -5457,6 +5458,902 @@ compute-cb@14 { }; }; }; + + tsens0: thermal-sensor@c228000 { + compatible = "qcom,sm8750-tsens", "qcom,tsens-v2"; + reg = <0x0 0x0c228000 0x0 0x1000>, + <0x0 0x0c222000 0x0 0x1000>; + interrupts = <GIC_SPI 771 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 484 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "uplow", + "critical"; + #qcom,sensors = <15>; + #thermal-sensor-cells = <1>; + }; + + tsens1: thermal-sensor@c229000 { + compatible = "qcom,sm8750-tsens", "qcom,tsens-v2"; + reg = <0x0 0x0c229000 0x0 0x1000>, + <0x0 0x0c223000 0x0 0x1000>; + interrupts = <GIC_SPI 772 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 485 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "uplow", + "critical"; + #qcom,sensors = <7>; + #thermal-sensor-cells = <1>; + }; + + tsens2: thermal-sensor@c22a000 { + compatible = "qcom,sm8750-tsens", "qcom,tsens-v2"; + reg = <0x0 0x0c22a000 0x0 0x1000>, + <0x0 0x0c224000 0x0 0x1000>; + interrupts = <GIC_SPI 773 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "uplow", + "critical"; + #qcom,sensors = <16>; + #thermal-sensor-cells = <1>; + }; + + tsens3: thermal-sensor@c22b000 { + compatible = "qcom,sm8750-tsens", "qcom,tsens-v2"; + reg = <0x0 0x0c22b000 0x0 0x1000>, + <0x0 0x0c225000 0x0 0x1000>; + interrupts = <GIC_SPI 774 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "uplow", + "critical"; + #qcom,sensors = <9>; + #thermal-sensor-cells = <1>; + }; + }; + + thermal-zones { + aoss0-thermal { + thermal-sensors = <&tsens0 0>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + aoss0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-0-0-thermal { + thermal-sensors = <&tsens0 1>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-0-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-0-1-thermal { + thermal-sensors = <&tsens0 2>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-0-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-1-0-thermal { + thermal-sensors = <&tsens0 3>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-1-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-1-1-thermal { + thermal-sensors = <&tsens0 4>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-1-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-2-0-thermal { + thermal-sensors = <&tsens0 5>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-2-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-2-1-thermal { + thermal-sensors = <&tsens0 6>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-2-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-3-0-thermal { + thermal-sensors = <&tsens0 7>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-3-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-3-1-thermal { + thermal-sensors = <&tsens0 8>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-3-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-4-0-thermal { + thermal-sensors = <&tsens0 9>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-4-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-4-1-thermal { + thermal-sensors = <&tsens0 10>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-4-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-5-0-thermal { + thermal-sensors = <&tsens0 11>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-5-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-0-5-1-thermal { + thermal-sensors = <&tsens0 12>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-0-5-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpuss-0-0-thermal { + thermal-sensors = <&tsens0 13>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpuss-0-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpuss-0-1-thermal { + thermal-sensors = <&tsens0 14>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpuss-0-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + aoss1-thermal { + thermal-sensors = <&tsens1 0>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + aoss1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-1-0-0-thermal { + thermal-sensors = <&tsens1 1>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-1-0-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-1-0-1-thermal { + thermal-sensors = <&tsens1 2>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-1-0-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-1-1-0-thermal { + thermal-sensors = <&tsens1 3>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-1-1-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpu-1-1-1-thermal { + thermal-sensors = <&tsens1 4>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpu-1-1-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpuss-1-0-thermal { + thermal-sensors = <&tsens1 5>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpuss-1-0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + cpuss-1-1-thermal { + thermal-sensors = <&tsens1 6>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + cpuss-1-1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + aoss2-thermal { + thermal-sensors = <&tsens2 0>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + aoss2-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss0-thermal { + thermal-sensors = <&tsens2 1>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss1-thermal { + thermal-sensors = <&tsens2 2>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss2-thermal { + thermal-sensors = <&tsens2 3>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss2-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss3-thermal { + thermal-sensors = <&tsens2 4>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss3-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss4-thermal { + thermal-sensors = <&tsens2 5>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss4-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss5-thermal { + thermal-sensors = <&tsens2 6>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss5-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss6-thermal { + thermal-sensors = <&tsens2 7>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss6-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + gpuss7-thermal { + thermal-sensors = <&tsens2 8>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + gpuss7-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + modem0-thermal { + thermal-sensors = <&tsens2 9>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + modem0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + modem1-thermal { + thermal-sensors = <&tsens2 10>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + modem1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + modem2-thermal { + thermal-sensors = <&tsens2 11>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + modem2-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + modem3-thermal { + thermal-sensors = <&tsens2 12>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + modem3-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + camera0-thermal { + thermal-sensors = <&tsens2 13>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + camera0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + camera1-thermal { + thermal-sensors = <&tsens2 14>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + camera1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + video-thermal { + thermal-sensors = <&tsens2 15>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + video-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + aoss3-thermal { + thermal-sensors = <&tsens3 0>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + aoss3-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphvx0-thermal { + thermal-sensors = <&tsens3 1>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphvx0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphvx1-thermal { + thermal-sensors = <&tsens3 2>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphvx1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphvx2-thermal { + thermal-sensors = <&tsens3 3>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphvx2-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphmx0-thermal { + thermal-sensors = <&tsens3 4>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphmx0-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphmx1-thermal { + thermal-sensors = <&tsens3 5>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphmx1-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphmx2-thermal { + thermal-sensors = <&tsens3 6>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphmx2-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + nsphmx3-thermal { + thermal-sensors = <&tsens3 7>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <5000>; + type = "hot"; + }; + + nsphmx3-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + + ddr-thermal { + thermal-sensors = <&tsens3 8>; + + trips { + trip-point0 { + temperature = <120000>; + hysteresis = <2000>; + type = "hot"; + }; + + ddr-critical { + temperature = <125000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; }; timer { -- 2.34.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-13 10:34 ` [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones Gaurav Kohli @ 2026-03-14 10:31 ` Krzysztof Kozlowski 2026-03-16 7:33 ` Gaurav Kohli 2026-03-18 9:44 ` Konrad Dybcio 1 sibling, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2026-03-14 10:31 UTC (permalink / raw) To: Gaurav Kohli Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On Fri, Mar 13, 2026 at 04:04:18PM +0530, Gaurav Kohli wrote: > From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > > The sm8750 includes four TSENS instances, with a total of 47 thermal > sensors distributed across various locations on the SoC. > > The TSENS max/reset threshold is configured to 130°C in the hardware. > Enable all TSENS instances, and define the thermal zones with a hot trip > at 120°C and critical trip at 125°C. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++++++++++++++++ > 1 file changed, 897 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi > index f56b1f889b85..db2a97cb228d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi > @@ -20,6 +20,7 @@ > #include <dt-bindings/soc/qcom,gpr.h> > #include <dt-bindings/soc/qcom,rpmh-rsc.h> > #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h> > +#include <dt-bindings/thermal/thermal.h> > > / { > interrupt-parent = <&intc>; > @@ -5457,6 +5458,902 @@ compute-cb@14 { > }; > }; > }; > + > + tsens0: thermal-sensor@c228000 { Please read carefully DTS coding style before posting patches. Actually, read also Linux kernel coding style as well. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-14 10:31 ` Krzysztof Kozlowski @ 2026-03-16 7:33 ` Gaurav Kohli 2026-03-16 7:41 ` Krzysztof Kozlowski 0 siblings, 1 reply; 12+ messages in thread From: Gaurav Kohli @ 2026-03-16 7:33 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 3/14/2026 4:01 PM, Krzysztof Kozlowski wrote: > On Fri, Mar 13, 2026 at 04:04:18PM +0530, Gaurav Kohli wrote: >> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> >> The sm8750 includes four TSENS instances, with a total of 47 thermal >> sensors distributed across various locations on the SoC. >> >> The TSENS max/reset threshold is configured to 130°C in the hardware. >> Enable all TSENS instances, and define the thermal zones with a hot trip >> at 120°C and critical trip at 125°C. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> >> --- >> arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 897 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> index f56b1f889b85..db2a97cb228d 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi >> @@ -20,6 +20,7 @@ >> #include <dt-bindings/soc/qcom,gpr.h> >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >> #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h> >> +#include <dt-bindings/thermal/thermal.h> >> >> / { >> interrupt-parent = <&intc>; >> @@ -5457,6 +5458,902 @@ compute-cb@14 { >> }; >> }; >> }; >> + >> + tsens0: thermal-sensor@c228000 { > > Please read carefully DTS coding style before posting patches. Actually, > read also Linux kernel coding style as well. > Thanks Krzysztof for review. Can i use temperature-sensor instead of thermal-sensor as per generic-names-recommendation ? > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-16 7:33 ` Gaurav Kohli @ 2026-03-16 7:41 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2026-03-16 7:41 UTC (permalink / raw) To: Gaurav Kohli Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 16/03/2026 08:33, Gaurav Kohli wrote: > > > On 3/14/2026 4:01 PM, Krzysztof Kozlowski wrote: >> On Fri, Mar 13, 2026 at 04:04:18PM +0530, Gaurav Kohli wrote: >>> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >>> >>> The sm8750 includes four TSENS instances, with a total of 47 thermal >>> sensors distributed across various locations on the SoC. >>> >>> The TSENS max/reset threshold is configured to 130°C in the hardware. >>> Enable all TSENS instances, and define the thermal zones with a hot trip >>> at 120°C and critical trip at 125°C. >>> >>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >>> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> >>> --- >>> arch/arm64/boot/dts/qcom/sm8750.dtsi | 897 +++++++++++++++++++++++++++++++++++ >>> 1 file changed, 897 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi >>> index f56b1f889b85..db2a97cb228d 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi >>> @@ -20,6 +20,7 @@ >>> #include <dt-bindings/soc/qcom,gpr.h> >>> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >>> #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h> >>> +#include <dt-bindings/thermal/thermal.h> >>> >>> / { >>> interrupt-parent = <&intc>; >>> @@ -5457,6 +5458,902 @@ compute-cb@14 { >>> }; >>> }; >>> }; >>> + >>> + tsens0: thermal-sensor@c228000 { >> >> Please read carefully DTS coding style before posting patches. Actually, >> read also Linux kernel coding style as well. >> > > Thanks Krzysztof for review. > > Can i use temperature-sensor instead of thermal-sensor as per > generic-names-recommendation ? Both work for me. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-13 10:34 ` [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones Gaurav Kohli 2026-03-14 10:31 ` Krzysztof Kozlowski @ 2026-03-18 9:44 ` Konrad Dybcio 2026-03-18 9:44 ` Konrad Dybcio 2026-03-23 9:02 ` Gaurav Kohli 1 sibling, 2 replies; 12+ messages in thread From: Konrad Dybcio @ 2026-03-18 9:44 UTC (permalink / raw) To: Gaurav Kohli, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 3/13/26 11:34 AM, Gaurav Kohli wrote: > From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > > The sm8750 includes four TSENS instances, with a total of 47 thermal > sensors distributed across various locations on the SoC. > > The TSENS max/reset threshold is configured to 130°C in the hardware. > Enable all TSENS instances, and define the thermal zones with a hot trip > at 120°C and critical trip at 125°C. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> > Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> > --- [...] > + cpu-0-0-0-thermal { > + thermal-sensors = <&tsens0 1>; > + > + trips { > + trip-point0 { > + temperature = <120000>; > + hysteresis = <5000>; > + type = "hot"; > + }; Are we going to use these trip points for the CPUs? If not, let's only keep the critical ones (again, for CPUs specifically since they get externally throttled) Konrad ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-18 9:44 ` Konrad Dybcio @ 2026-03-18 9:44 ` Konrad Dybcio 2026-03-23 9:02 ` Gaurav Kohli 1 sibling, 0 replies; 12+ messages in thread From: Konrad Dybcio @ 2026-03-18 9:44 UTC (permalink / raw) To: Gaurav Kohli, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 3/18/26 10:44 AM, Konrad Dybcio wrote: > On 3/13/26 11:34 AM, Gaurav Kohli wrote: >> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> >> The sm8750 includes four TSENS instances, with a total of 47 thermal >> sensors distributed across various locations on the SoC. >> >> The TSENS max/reset threshold is configured to 130°C in the hardware. >> Enable all TSENS instances, and define the thermal zones with a hot trip >> at 120°C and critical trip at 125°C. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> >> --- > > [...] > >> + cpu-0-0-0-thermal { >> + thermal-sensors = <&tsens0 1>; >> + >> + trips { >> + trip-point0 { >> + temperature = <120000>; >> + hysteresis = <5000>; >> + type = "hot"; >> + }; > > Are we going to use these trip points for the CPUs? If not, let's only > keep the critical ones (again, for CPUs specifically since they get > externally throttled) Other than that: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-18 9:44 ` Konrad Dybcio 2026-03-18 9:44 ` Konrad Dybcio @ 2026-03-23 9:02 ` Gaurav Kohli 2026-03-23 13:12 ` Konrad Dybcio 1 sibling, 1 reply; 12+ messages in thread From: Gaurav Kohli @ 2026-03-23 9:02 UTC (permalink / raw) To: Konrad Dybcio, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 3/18/2026 3:14 PM, Konrad Dybcio wrote: > On 3/13/26 11:34 AM, Gaurav Kohli wrote: >> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> >> The sm8750 includes four TSENS instances, with a total of 47 thermal >> sensors distributed across various locations on the SoC. >> >> The TSENS max/reset threshold is configured to 130°C in the hardware. >> Enable all TSENS instances, and define the thermal zones with a hot trip >> at 120°C and critical trip at 125°C. >> >> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> >> --- > > [...] > >> + cpu-0-0-0-thermal { >> + thermal-sensors = <&tsens0 1>; >> + >> + trips { >> + trip-point0 { >> + temperature = <120000>; >> + hysteresis = <5000>; >> + type = "hot"; >> + }; > > Are we going to use these trip points for the CPUs? If not, let's only > keep the critical ones (again, for CPUs specifically since they get > externally throttled) thanks Konrad, for review. We are not using this trip points for CPUs, For Kaanapali, Dmitry suggested to add more warning for CPUs also, if in case some user want to use it. So we have added for this soc also. https://lore.kernel.org/all/vjx3bd75zdgdh6hzhrmlv5tlarnf6ea3yklwhg7jx6momknase@kstxwngyicd3/ > > Konrad ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones 2026-03-23 9:02 ` Gaurav Kohli @ 2026-03-23 13:12 ` Konrad Dybcio 0 siblings, 0 replies; 12+ messages in thread From: Konrad Dybcio @ 2026-03-23 13:12 UTC (permalink / raw) To: Gaurav Kohli, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel, aastha.pandey, dipa.mantre, Manaf Meethalavalappu Pallikunhi On 3/23/26 10:02 AM, Gaurav Kohli wrote: > > > On 3/18/2026 3:14 PM, Konrad Dybcio wrote: >> On 3/13/26 11:34 AM, Gaurav Kohli wrote: >>> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >>> >>> The sm8750 includes four TSENS instances, with a total of 47 thermal >>> sensors distributed across various locations on the SoC. >>> >>> The TSENS max/reset threshold is configured to 130°C in the hardware. >>> Enable all TSENS instances, and define the thermal zones with a hot trip >>> at 120°C and critical trip at 125°C. >>> >>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@quicinc.com> >>> Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com> >>> --- >> >> [...] >> >>> + cpu-0-0-0-thermal { >>> + thermal-sensors = <&tsens0 1>; >>> + >>> + trips { >>> + trip-point0 { >>> + temperature = <120000>; >>> + hysteresis = <5000>; >>> + type = "hot"; >>> + }; >> >> Are we going to use these trip points for the CPUs? If not, let's only >> keep the critical ones (again, for CPUs specifically since they get >> externally throttled) > > thanks Konrad, for review. > We are not using this trip points for CPUs, For Kaanapali, Dmitry suggested to add more warning for CPUs also, if in case some user want to use it. So we have added for this soc also. Alright, please resubmit with Krzysztof's comments addressed and retain my r-b then Konrad ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2026-03-23 13:12 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-13 10:34 [PATCH 0/2] Enable TSENS and thermal zone for SM8750 SoC Gaurav Kohli 2026-03-13 10:34 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: Document the SM8750 Temperature Sensor Gaurav Kohli 2026-03-14 10:30 ` Krzysztof Kozlowski 2026-03-14 10:46 ` Daniel Lezcano 2026-03-13 10:34 ` [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones Gaurav Kohli 2026-03-14 10:31 ` Krzysztof Kozlowski 2026-03-16 7:33 ` Gaurav Kohli 2026-03-16 7:41 ` Krzysztof Kozlowski 2026-03-18 9:44 ` Konrad Dybcio 2026-03-18 9:44 ` Konrad Dybcio 2026-03-23 9:02 ` Gaurav Kohli 2026-03-23 13:12 ` Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox