Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] iio: adc: ad4080: add support for AD4880 dual-channel ADC
Date: Sat, 14 Mar 2026 11:40:58 +0000	[thread overview]
Message-ID: <20260314114058.246bcfc5@jic23-huawei> (raw)
In-Reply-To: <20260313115856.87763-1-antoniu.miclaus@analog.com>

On Fri, 13 Mar 2026 13:58:49 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add support for the AD4880, a dual-channel 20-bit 40MSPS SAR ADC from
> the same family as AD4080.
> 
> The AD4880 has two independent ADC channels, each with its own SPI
> configuration interface and LVDS data output. The driver uses
> spi_new_ancillary_device() for the second channel's SPI and requires
> two io-backend instances for the data interfaces.
> 
> This series includes:
>   - Use __free(fwnode_handle) for automatic cleanup in iio backend
>   - Refactored devm_iio_backend_get_by_index() for multi-channel backend lookup
>   - DT bindings update for AD4880
>   - Driver support for AD4880
> 
> This series depends on the SPI ancillary device patches already picked
> up in Mark Brown's SPI tree (https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git).
> Added base-commit in the cover letter below.
> 
> Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4880.pdf
> 
> Changes in v6:
>   - Move fwnode_back declaration back to inline position above
>     IS_ERR() check (patch 2)
>   - Rebase on top of broonie/spi for-next and use --base to declare
>     the SPI dependency (cover letter)

Ok. Given there was nothing in v5 to indicate a need to do a v6
you should have replied to that thread to say you were doing so.
The fwnode thing was something I said I'd fix up whilst applying.
The SPI dependency was a 'do it better next time' comment.

I've dropped the v5 version I applied.  Now you have questions
to answer from Andy on this one.


> 
> Antoniu Miclaus (4):
>   iio: backend: use __free(fwnode_handle) for automatic cleanup
>   iio: backend: add devm_iio_backend_get_by_index()
>   dt-bindings: iio: adc: ad4080: add AD4880 support
>   iio: adc: ad4080: add support for AD4880 dual-channel ADC
> 
>  .../bindings/iio/adc/adi,ad4080.yaml          |  53 +++-
>  drivers/iio/adc/ad4080.c                      | 230 ++++++++++++++----
>  drivers/iio/industrialio-backend.c            |  62 +++--
>  include/linux/iio/backend.h                   |   2 +
>  4 files changed, 278 insertions(+), 69 deletions(-)
> 
> 
> base-commit: 2cd3974b9ae59ac731a4792e1608be32621b6e98
> --
> 2.43.0
> 


  parent reply	other threads:[~2026-03-14 11:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 11:58 [PATCH v6 0/4] iio: adc: ad4080: add support for AD4880 dual-channel ADC Antoniu Miclaus
2026-03-13 11:58 ` [PATCH v6 1/4] iio: backend: use __free(fwnode_handle) for automatic cleanup Antoniu Miclaus
2026-03-13 14:16   ` Andy Shevchenko
2026-03-14 10:53   ` Nuno Sá
2026-03-13 11:58 ` [PATCH v6 2/4] iio: backend: add devm_iio_backend_get_by_index() Antoniu Miclaus
2026-03-13 14:16   ` Andy Shevchenko
2026-03-13 11:58 ` [PATCH v6 3/4] dt-bindings: iio: adc: ad4080: add AD4880 support Antoniu Miclaus
2026-03-13 11:58 ` [PATCH v6 4/4] iio: adc: ad4080: add support for AD4880 dual-channel ADC Antoniu Miclaus
2026-03-13 14:22   ` Andy Shevchenko
2026-03-14 12:00     ` Jonathan Cameron
2026-03-16  9:56       ` Andy Shevchenko
2026-03-16 12:31         ` Miclaus, Antoniu
2026-03-16 14:41           ` Andy Shevchenko
2026-03-16 15:09             ` Miclaus, Antoniu
2026-03-16 15:21               ` Andy Shevchenko
2026-03-17  9:54                 ` Miclaus, Antoniu
2026-03-17 10:31                   ` Andy Shevchenko
2026-03-21 12:01                     ` Jonathan Cameron
2026-03-14 11:40 ` Jonathan Cameron [this message]
2026-03-16  9:35   ` [PATCH v6 0/4] " Miclaus, Antoniu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260314114058.246bcfc5@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox