From: Krzysztof Kozlowski <krzk@kernel.org>
To: Erikas Bitovtas <xerikasxx@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: iio: light: vcnl4000: add regulators
Date: Sun, 15 Mar 2026 09:49:41 +0100 [thread overview]
Message-ID: <20260315-honest-debonair-oarfish-3a33ed@quoll> (raw)
In-Reply-To: <20260314-vcnl4000-regulators-v3-1-3c4a48d30676@gmail.com>
On Sat, Mar 14, 2026 at 06:06:30PM +0200, Erikas Bitovtas wrote:
> This commit adds supply properties for the sensor, I2C bus and IR LED
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> anode supplies [1], which can be found in vcnl4000 ambient light and
So other devices do not have these supplies? Or have only some?
You already received that question, so I assume you checked. Then check
again because 4040 has VDD.
thus in
that case
> proximity sensors, to ensure the sensor is powered on before proceeding
> with setup.
>
> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..a1b4c02db246 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
> interrupts:
> maxItems: 1
>
> + vdd-supply: true
> + vddio-supply: true
VCNL4000 does not have VDDIO and VLED pins.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-15 8:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 16:06 [PATCH v3 0/6] iio: light: vcnl4000: add regulator support Erikas Bitovtas
2026-03-14 16:06 ` [PATCH v3 1/6] dt-bindings: iio: light: vcnl4000: add regulators Erikas Bitovtas
2026-03-15 8:49 ` Krzysztof Kozlowski [this message]
2026-03-15 17:07 ` Erikas Bitovtas
2026-03-14 16:06 ` [PATCH v3 2/6] iio: light: vcnl4000: sort includes by their name Erikas Bitovtas
2026-03-14 16:06 ` [PATCH v3 3/6] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Erikas Bitovtas
2026-03-14 19:51 ` David Lechner
2026-03-15 18:26 ` Jonathan Cameron
2026-03-16 10:24 ` Andy Shevchenko
2026-03-14 16:06 ` [PATCH v3 4/6] iio: light: vcnl4000: add support for regulators Erikas Bitovtas
2026-03-15 18:27 ` Jonathan Cameron
2026-03-16 10:27 ` Andy Shevchenko
2026-03-14 16:06 ` [PATCH v3 5/6] iio: light: vcnl4000: remove error messages for trigger and irq Erikas Bitovtas
2026-03-15 18:31 ` Jonathan Cameron
2026-03-15 19:15 ` Erikas Bitovtas
2026-03-15 21:24 ` Jonathan Cameron
2026-03-14 16:06 ` [PATCH v3 6/6] iio: light: vcnl4000: use variables for I2C client and device instances Erikas Bitovtas
2026-03-16 10:39 ` Andy Shevchenko
2026-03-16 10:50 ` Erikas Bitovtas
2026-03-16 11:10 ` Andy Shevchenko
2026-03-14 19:53 ` [PATCH v3 0/6] iio: light: vcnl4000: add regulator support David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260315-honest-debonair-oarfish-3a33ed@quoll \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox