public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: trivial-devices: add spi-miso-mosi-loopback
Date: Mon, 16 Mar 2026 09:57:51 +0100	[thread overview]
Message-ID: <20260316085751.GA23443@francesco-nb> (raw)
In-Reply-To: <cde8671f-bb38-41d8-b27f-c54aa7242899@kernel.org>

Hello Krzysztof,
thanks for taking the time to answer this

On Mon, Mar 16, 2026 at 09:36:42AM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2026 09:35, Krzysztof Kozlowski wrote:
> > On 16/03/2026 08:35, Francesco Dolcini wrote:
> >> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> >>
> >> Add a compatible to describe a single wire loopback between SPI MISO and
> >> MOSI signals.
> >>
> >> Link: https://lore.kernel.org/all/20260310133254.GA51497@francesco-nb/
> >> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> >> ---
> >>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> >> index a482aeadcd44..2cb973c157f6 100644
> >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> >> @@ -432,6 +432,8 @@ properties:
> >>            - socionext,uniphier-smpctrl
> >>              # SparkFun Qwiic Joystick (COM-15168) with i2c interface
> >>            - sparkfun,qwiic-joystick
> >> +            # Single wire loopback between SPI MISO and MOSI signals
> >> +          - spi-miso-mosi-loopback
> > 
> > If you decided to go against my approach, then at least document it in
> > proper place - incomplete-devices - so this won't be ever used in DTS.
> >
> 
> ... and then you will notice existing linux,spi-loopback-test, so
> explain the differences and why spi-loopback-test cannot be used for
> your loopback test.

Yes, this spi-loopback-test will work.

I was not aware of it (no-one mentioned it in the email thread I opened)
and I misread your answer as an alternative suggestion, and not as a nack.

There is still an open question, I can any driver probe/bind to the
actual SPI device? My plan, once this discussion is settled, is to send
patches to add dtso file enabling this test, however, according to
trivial-devices.yaml, I cannot submit such a DT file using
linux,spi-loopback-test as a compatible.

On the actual HW I have a pins header and a wire between MISO/MOSI.

I am clearly missing something obvious, any advise is appreciated.

Thanks,
Francesco


  reply	other threads:[~2026-03-16  8:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  7:35 [PATCH v1 0/2] spi: Add data loopback OF compatible Francesco Dolcini
2026-03-16  7:35 ` [PATCH v1 1/2] dt-bindings: trivial-devices: add spi-miso-mosi-loopback Francesco Dolcini
2026-03-16  8:35   ` Krzysztof Kozlowski
2026-03-16  8:36     ` Krzysztof Kozlowski
2026-03-16  8:57       ` Francesco Dolcini [this message]
2026-03-16 16:56         ` Krzysztof Kozlowski
2026-03-18 14:14           ` Francesco Dolcini
2026-03-22 10:01             ` Krzysztof Kozlowski
2026-03-16  7:35 ` [PATCH v1 2/2] spi: spidev: Add data loopback OF compatible Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316085751.GA23443@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox