public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Flaviu Nistor <flaviu.nistor@gmail.com>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Flaviu Nistor <flaviu.nistor@gmail.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: lm75: Add label property
Date: Wed, 18 Mar 2026 22:03:24 +0200	[thread overview]
Message-ID: <20260318200324.4365-1-flaviu.nistor@gmail.com> (raw)
In-Reply-To: <e82aefd4-384e-43e6-a830-c7728f642ae2@kernel.org>

On Sat, Mar 14, 2026 at 10:50 AM, Krzysztof Kozlowski wrote:
>On 14/03/2026 08:48, Flaviu Nistor wrote:
>> On Fri, 13 Mar 2026 14:26:35 +0100, Krzysztof Kozlowski wrote:
>>> On Wed, Mar 11, 2026 at 12:58:07PM +0200, Flaviu Nistor wrote:
>>>> Add support for an optional label property similar to other hwmon devices.
>>>
>>> I do not see any support being added here.
>>>
>>> Subject is not accurate either. You did not add the label property.
>>>
>>> Best regards,
>>> Krzysztof
>> 
>> Hello and thanks for the reply.
>> I probably did not use the best description and subject name, 
>> I wanted to be linked to the other patch in the series).
>> The label property is already added by you via the hwmon-common.yaml.
>> I will have to send out a v2 for this series so I will change the subject to
>> "Add examples for label property" and also specify in the description more clear
>> that is just a simple "Add label property in the two examples."
>
>Your commit msg must explain WHY you are doing this.
My initial intention was to make sure that dtbs_check is not generating errors,
but since then I got to understand that the example section is not actually used
during the validation of DT source files.
My second intention was to add the label property to the example section as a good
practice, but I also have seen that this is not a general rule. As I understand
this is not a mandatory change, I will drop the binding patch from v2.

Best regards,
Flaviu 
>
>Best regards,
>Krzysztof

      reply	other threads:[~2026-03-18 20:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 10:58 [PATCH 1/2] dt-bindings: hwmon: lm75: Add label property Flaviu Nistor
2026-03-11 10:58 ` [PATCH 2/2] hwmon: lm75: Add support for label Flaviu Nistor
2026-03-13 18:37   ` Guenter Roeck
2026-03-13 13:26 ` [PATCH 1/2] dt-bindings: hwmon: lm75: Add label property Krzysztof Kozlowski
2026-03-14  7:48   ` Flaviu Nistor
2026-03-14  8:50     ` Krzysztof Kozlowski
2026-03-18 20:03       ` Flaviu Nistor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318200324.4365-1-flaviu.nistor@gmail.com \
    --to=flaviu.nistor@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox