Re: [PATCH v2 2/3] dt-bindings: hwmon: Add Sensirion SHT3x and GXCAS GXHT30

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2471 bytes --]

On Thu, Mar 19, 2026 at 07:38:33PM +0800, Zaixiang Xu wrote:
> Add YAML devicetree binding schema for Sensirion SHT3x series and GXCAS GXHT30 humidity and temperature sensors.

Overly long line.

> 
> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> ---
>  .../bindings/hwmon/sensirion,sht3x.yaml       | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> new file mode 100644
> index 000000000000..47dbb743e2ee
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht3x.yaml#
> +$schema: http://devicetree.org/meta-schema.yaml#
> +
> +title: Sensirion SHT3x Humidity and Temperature Sensor
> +
> +maintainers:
> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> +
> +description: |
> +  The SHT3x series is a family of humidity and temperature sensors by Sensirion.
> +  It also includes compatible sensors like GXCAS GXHT30.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sht3x

Typically, we don't permit wildcards in compatible strings.
You need to have an explanation in your commit message for why using
specific compatibles for each model is okay. Even then, should really
use a compatible that represents a real device, in case a sht38 comes
out that isn't compatible with the sht31 etc.

> +      - sensirion,sts3x
> +      - sensirion,sht85
> +      - gxcas,gxht30

None of these devices have any match data, and the driver only seems to
care about sts versus !sts. Fallbacks look like they should be used for
the sht devices and the gxht30.

pw-bot: changes-requested

Cheers,
Conor.

> +
> +  reg:
> +    maxItems: 1
> +    description: I2C address (usually 0x44 or 0x45)
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@44 {
> +            compatible = "gxcas,gxht30";
> +            reg = <0x44>;
> +        };
> +    };
> \ No newline at end of file
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]