* Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl
2026-03-19 8:55 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl Luca Weiss
@ 2026-03-19 14:39 ` Conor Dooley
2026-03-23 12:41 ` Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2026-03-19 14:39 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, ~postmarketos/upstreaming, phone-devel,
linux-arm-msm, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]
On Thu, Mar 19, 2026 at 09:55:00AM +0100, Luca Weiss wrote:
> The pinctrl nodes from sm6350.dtsi already contain a bias-* property, so
> that needs to be deleted, otherwise the dtb will contain two conflicting
> bias-* properties.
>
> Reported-by: Conor Dooley <conor@kernel.org>
> Closes: https://lore.kernel.org/r/20260310-maritime-silly-05e7b7e03aa6@spud/
> Fixes: c4ef464b24c5 ("arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks Luca.
> ---
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index a3c2b26736f4..3964aae47fd4 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -1019,12 +1019,14 @@ &qup_uart1_cts {
> * the Bluetooth module drives the pin in either
> * direction or leaves the pin fully unpowered.
> */
> + /delete-property/ bias-disable;
> bias-bus-hold;
> };
>
> &qup_uart1_rts {
> /* We'll drive RTS, so no pull */
> drive-strength = <2>;
> + /delete-property/ bias-pull-down;
> bias-disable;
> };
>
> @@ -1035,12 +1037,14 @@ &qup_uart1_rx {
> * in tri-state (module powered off or not driving the
> * signal yet).
> */
> + /delete-property/ bias-disable;
> bias-pull-up;
> };
>
> &qup_uart1_tx {
> /* We'll drive TX, so no pull */
> drive-strength = <2>;
> + /delete-property/ bias-pull-up;
> bias-disable;
> };
>
>
> ---
> base-commit: de79886ae0ce739608514f6b1ae91c14c6a9e600
> change-id: 20260319-fp4-uart1-fix-9fe390294499
>
> Best regards,
> --
> Luca Weiss <luca.weiss@fairphone.com>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl
2026-03-19 8:55 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl Luca Weiss
2026-03-19 14:39 ` Conor Dooley
@ 2026-03-23 12:41 ` Konrad Dybcio
2026-03-23 12:41 ` Konrad Dybcio
2026-03-24 3:05 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-03-23 12:41 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Conor Dooley
On 3/19/26 9:55 AM, Luca Weiss wrote:
> The pinctrl nodes from sm6350.dtsi already contain a bias-* property, so
> that needs to be deleted, otherwise the dtb will contain two conflicting
> bias-* properties.
>
> Reported-by: Conor Dooley <conor@kernel.org>
> Closes: https://lore.kernel.org/r/20260310-maritime-silly-05e7b7e03aa6@spud/
> Fixes: c4ef464b24c5 ("arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
FWIW it may be that almost no one will use this UART for anything else
than bluetooth, so I'm not entirely against just smashing these into
the common DTSI..
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl
2026-03-19 8:55 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl Luca Weiss
2026-03-19 14:39 ` Conor Dooley
2026-03-23 12:41 ` Konrad Dybcio
@ 2026-03-23 12:41 ` Konrad Dybcio
2026-03-24 3:05 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-03-23 12:41 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Conor Dooley
On 3/19/26 9:55 AM, Luca Weiss wrote:
> The pinctrl nodes from sm6350.dtsi already contain a bias-* property, so
> that needs to be deleted, otherwise the dtb will contain two conflicting
> bias-* properties.
>
> Reported-by: Conor Dooley <conor@kernel.org>
> Closes: https://lore.kernel.org/r/20260310-maritime-silly-05e7b7e03aa6@spud/
> Fixes: c4ef464b24c5 ("arm64: dts: qcom: sm7225-fairphone-fp4: Add Bluetooth")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl
2026-03-19 8:55 [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl Luca Weiss
` (2 preceding siblings ...)
2026-03-23 12:41 ` Konrad Dybcio
@ 2026-03-24 3:05 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-03-24 3:05 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Luca Weiss
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, Conor Dooley
On Thu, 19 Mar 2026 09:55:00 +0100, Luca Weiss wrote:
> The pinctrl nodes from sm6350.dtsi already contain a bias-* property, so
> that needs to be deleted, otherwise the dtb will contain two conflicting
> bias-* properties.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sm7225-fairphone-fp4: Fix conflicting bias pinctrl
commit: 5f80d68959dd1bff70fd0abea8a69f507f204287
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread