From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D61830C360; Fri, 20 Mar 2026 17:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774029430; cv=none; b=VUVw3ITj7BquJaMAmniuTs2/vvQrsk88KUwvJEpF9R3IhoVln/STywvFn+iUytyBfsglLmebLMWt9S2c6vR4PLc8yyKeiOJspXRmh783JqYCGubifEVWIpQWAxbt5nyIMY3zU1L6IjWft+u48bBXa2cRPn1Oh9/+km6KOQFEQoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774029430; c=relaxed/simple; bh=8glEvNnreBwR1w2oGJ8ufIdnmrUmRY35kJIHcmNZ0RY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J/y+y2mR595RpfbReWpbasnHyyrftVMQuw4CYk9XRePEdsOfpkyRLWyKYm1MkzzBn8GOrVX7PZlj6EvGN3O3ssQo9OegjBMKPbaIjz1v+VxkmBaijIWdumh3a/Qrfp+MFbW1E0ECFXIrQK/MZjn0Qrhf3+mRTw0uqWbgFKeZQLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TxPSODsG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TxPSODsG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98BF8C4CEF7; Fri, 20 Mar 2026 17:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774029429; bh=8glEvNnreBwR1w2oGJ8ufIdnmrUmRY35kJIHcmNZ0RY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TxPSODsGNorclc3tsg+OMczBTjPIbL0qdr0uUYVvgH4uGPxMgi0WpgOtPvboOW6Pb yt+QmKPoAITQQLJ0fkMUHOSmdJhU3Nj3XdIzHepscWJrC0nqiT5RFBgBFJeBQeBV6R 07BPHLjUjXIcJFjJ7fjjKgXUjEKu8lD8GhPgj6bxZm/OfbhTmVmkgznZNUuPZgAYwE 15HYrJBvZcfpSRyLLJx0X9mUM2gYuGPtc/RafwF5PGusO2/RwAtu8DYqS7wBZbpYyW ysuR0LIffpGD5DGpo9PnVGRWTZ+jqOh7AQnxaX5LdhqWv0F4m98XblMi7dddu88xoU DbUymsQ50Ob2Q== Date: Fri, 20 Mar 2026 17:57:05 +0000 From: Conor Dooley To: Philipp Zabel Cc: Yixun Lan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Junzhong Pan , Guodong Xu , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] reset: spacemit: k3: Decouple composite reset lines Message-ID: <20260320-starlit-isolation-40c3c80e77a4@spud> References: <20260320-01-k3-reset-usb-pci-v5-1-07f4a5ddd728@kernel.org> <272ed19e2c0d8c9f53b6e621c01dc09f0635bf9d.camel@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hP8vo3n1R88/WzCL" Content-Disposition: inline In-Reply-To: <272ed19e2c0d8c9f53b6e621c01dc09f0635bf9d.camel@pengutronix.de> --hP8vo3n1R88/WzCL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2026 at 01:02:04PM +0100, Philipp Zabel wrote: > On Fr, 2026-03-20 at 11:06 +0000, Yixun Lan wrote: > > Instead of grouping several different reset lines into one composite > > reset, decouple them to individual ones which make it more aligned > > with underlying hardware. And for DWC USB driver, it will match well > > with the number of the reset property in the DT bindings. > >=20 > > The DWC3 USB host controller in K3 SoC has three reset lines - AHB, VCC, > > PHY. The PCIe controller also has three reset lines - DBI, Slave, Maste= r. > > Also three reset lines each for UCIE and RCPU block. >=20 > Although I can't validate correctness of the id-to-bit assignments, the > changes look consistent. >=20 > I trust that the reason for the grouped reset lines was just > convenience, and not some hardware limitation that requires them to be > controlled at the same time. >=20 > There are no patches using the USB/UCIE/RCPU/PCIE resets found on lore, > so this is not an ABI break. >=20 Eh, I think it's an ABI break either way, but it is being done fast enough that there's no users since this is new as of -rc1. Acked-by: Conor Dooley Just be careful Yixun that U-Boot doesn't import and starting using it, I forget if they use -rc1 or released kernels as their import point. pw-bot: not-applicable Cheers, Conor. > > As an agreement with maintainer, the reset IDs has been rearranged as > > contiguous number but keep most part unchanged to avoid break patches > > which already sent to mailing list. The changes of DT binding header fi= le > > and reset driver are merged together as one single commit to avoid > > git-bisect breakage. > >=20 > > Fixes: 938ce3b16582 ("reset: spacemit: Add SpacemiT K3 reset driver") > > Fixes: 216e0a5e98e5 ("dt-bindings: soc: spacemit: Add K3 reset support = and IDs") > > Signed-off-by: Yixun Lan >=20 > Reviewed-by: Philipp Zabel >=20 > If there are no objections, I'll pick this up into reset/fixes for > v7.0-rc6. >=20 > regards > Philipp --hP8vo3n1R88/WzCL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCab2KcQAKCRB4tDGHoIJi 0n4FAQCnnReUmA8clg/MCzX+jyZCk7NbP4dF2JecIAuY7go4WgEAy9VobUGZbInL sYap5dRIMkC5Q4cA1ppov9UzFaiY5A4= =oCVp -----END PGP SIGNATURE----- --hP8vo3n1R88/WzCL--