Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Jon Hunter <jonathanh@nvidia.com>,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: Document Tegra194 and Tegra264 controllers
Date: Sat, 21 Mar 2026 11:47:59 +0100	[thread overview]
Message-ID: <20260321-witty-fortunate-elephant-ce50fe@quoll> (raw)
In-Reply-To: <20260320234056.2579010-1-thierry.reding@kernel.org>

On Sat, Mar 21, 2026 at 12:40:55AM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The PWM controller found on Tegra264 is largely compatible with the one
> on prior generations, but it comes with some extra features, hence a new
> compatible string is needed.

Extra features means devices are compatible.

You also always need a new compatible even without extra features, so
last part is just confusing. Suggests like you could skip new
compatible.

> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.yaml b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.yaml
> index 41cea4979132..15706d2a808d 100644
> --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.yaml
> @@ -16,6 +16,8 @@ properties:
>        - enum:
>            - nvidia,tegra20-pwm
>            - nvidia,tegra186-pwm
> +          - nvidia,tegra194-pwm

Not explained in commit msg and it's a duplicated compatible.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-03-21 10:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 23:40 [PATCH 1/2] dt-bindings: pwm: Document Tegra194 and Tegra264 controllers Thierry Reding
2026-03-20 23:40 ` [PATCH 2/2] arm64: tegra: Add PWM controllers on Tegra264 Thierry Reding
2026-03-21 10:47 ` Krzysztof Kozlowski [this message]
2026-03-23 14:45   ` [PATCH 1/2] dt-bindings: pwm: Document Tegra194 and Tegra264 controllers Thierry Reding
2026-03-23 15:00     ` Krzysztof Kozlowski
2026-03-24  8:30       ` Thierry Reding
2026-03-21 10:49 ` Krzysztof Kozlowski
2026-03-23  2:45   ` Mikko Perttunen
2026-03-23  7:23     ` Krzysztof Kozlowski
2026-03-24  4:24       ` Mikko Perttunen
2026-03-24  7:02         ` Krzysztof Kozlowski
2026-03-24  8:32           ` Thierry Reding
2026-03-25  1:13             ` Mikko Perttunen
2026-03-23 14:50   ` Thierry Reding
2026-03-23 15:04     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260321-witty-fortunate-elephant-ce50fe@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox