public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match
@ 2026-03-21  1:20 Jihed Chaibi
  2026-03-23 13:47 ` Mark Brown
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Jihed Chaibi @ 2026-03-21  1:20 UTC (permalink / raw)
  To: olivier.moysan, arnaud.pouliquen, mcoquelin.stm32,
	alexandre.torgue
  Cc: lgirdwood, broonie, krzk+dt, robh, conor+dt, devicetree,
	linux-sound, linux-stm32, linux-kernel, linux-arm-kernel,
	jihed.chaibi.dev

The conditional block that defines clock constraints for the stm32h7-sai
variant references "st,stm32mph7-sai", which does not match any compatible
string in the enum. As a result, clock validation for the h7 variant is
silently skipped. Correct the compatible string to "st,stm32h7-sai".

Fixes: 8509bb1f11a1f ("ASoC: dt-bindings: add stm32mp25 support for sai")
Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
 Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
index 4a7129d0b157..551edf39e766 100644
--- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
+++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
@@ -164,7 +164,7 @@ allOf:
       properties:
         compatible:
           contains:
-            const: st,stm32mph7-sai
+            const: st,stm32h7-sai
     then:
       properties:
         clocks:
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match
  2026-03-21  1:20 [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match Jihed Chaibi
@ 2026-03-23 13:47 ` Mark Brown
  2026-03-24 12:49   ` Olivier MOYSAN
  2026-03-24 12:54 ` Olivier MOYSAN
  2026-03-24 12:58 ` Mark Brown
  2 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2026-03-23 13:47 UTC (permalink / raw)
  To: Jihed Chaibi
  Cc: olivier.moysan, arnaud.pouliquen, mcoquelin.stm32,
	alexandre.torgue, lgirdwood, krzk+dt, robh, conor+dt, devicetree,
	linux-sound, linux-stm32, linux-kernel, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

On Sat, Mar 21, 2026 at 02:20:11AM +0100, Jihed Chaibi wrote:
> The conditional block that defines clock constraints for the stm32h7-sai
> variant references "st,stm32mph7-sai", which does not match any compatible
> string in the enum. As a result, clock validation for the h7 variant is
> silently skipped. Correct the compatible string to "st,stm32h7-sai".

A web search for stm32mph7 appears to show stm32h7 as the correct part
number...  ST people, any confirmation here?  Are both valid?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match
  2026-03-23 13:47 ` Mark Brown
@ 2026-03-24 12:49   ` Olivier MOYSAN
  0 siblings, 0 replies; 5+ messages in thread
From: Olivier MOYSAN @ 2026-03-24 12:49 UTC (permalink / raw)
  To: Mark Brown, Jihed Chaibi
  Cc: arnaud.pouliquen, mcoquelin.stm32, alexandre.torgue, lgirdwood,
	krzk+dt, robh, conor+dt, devicetree, linux-sound, linux-stm32,
	linux-kernel, linux-arm-kernel

Hi,

On 3/23/26 14:47, Mark Brown wrote:
> On Sat, Mar 21, 2026 at 02:20:11AM +0100, Jihed Chaibi wrote:
>> The conditional block that defines clock constraints for the stm32h7-sai
>> variant references "st,stm32mph7-sai", which does not match any compatible
>> string in the enum. As a result, clock validation for the h7 variant is
>> silently skipped. Correct the compatible string to "st,stm32h7-sai".
> 
> A web search for stm32mph7 appears to show stm32h7 as the correct part
> number...  ST people, any confirmation here?  Are both valid?

The right part number is "st,stm32h7-sai" only.
So, the fix is valid. Thanks for it.

BRs
Olivier

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match
  2026-03-21  1:20 [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match Jihed Chaibi
  2026-03-23 13:47 ` Mark Brown
@ 2026-03-24 12:54 ` Olivier MOYSAN
  2026-03-24 12:58 ` Mark Brown
  2 siblings, 0 replies; 5+ messages in thread
From: Olivier MOYSAN @ 2026-03-24 12:54 UTC (permalink / raw)
  To: Jihed Chaibi, arnaud.pouliquen, mcoquelin.stm32, alexandre.torgue
  Cc: lgirdwood, broonie, krzk+dt, robh, conor+dt, devicetree,
	linux-sound, linux-stm32, linux-kernel, linux-arm-kernel

Hi,

On 3/21/26 02:20, Jihed Chaibi wrote:
> The conditional block that defines clock constraints for the stm32h7-sai
> variant references "st,stm32mph7-sai", which does not match any compatible
> string in the enum. As a result, clock validation for the h7 variant is
> silently skipped. Correct the compatible string to "st,stm32h7-sai".
> 
> Fixes: 8509bb1f11a1f ("ASoC: dt-bindings: add stm32mp25 support for sai")
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
> ---
>   Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> index 4a7129d0b157..551edf39e766 100644
> --- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> @@ -164,7 +164,7 @@ allOf:
>         properties:
>           compatible:
>             contains:
> -            const: st,stm32mph7-sai
> +            const: st,stm32h7-sai
>       then:
>         properties:
>           clocks:

Reviewed-by: Olivier Moysan <olivier.moysan@foss.st.com>

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match
  2026-03-21  1:20 [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match Jihed Chaibi
  2026-03-23 13:47 ` Mark Brown
  2026-03-24 12:54 ` Olivier MOYSAN
@ 2026-03-24 12:58 ` Mark Brown
  2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2026-03-24 12:58 UTC (permalink / raw)
  To: olivier.moysan, arnaud.pouliquen, mcoquelin.stm32,
	alexandre.torgue, Jihed Chaibi
  Cc: lgirdwood, krzk+dt, robh, conor+dt, devicetree, linux-sound,
	linux-stm32, linux-kernel, linux-arm-kernel

On Sat, 21 Mar 2026 02:20:11 +0100, Jihed Chaibi wrote:
> ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.0

Thanks!

[1/1] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match
      https://git.kernel.org/broonie/sound/c/91049ec2e183

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-03-24 19:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21  1:20 [PATCH] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match Jihed Chaibi
2026-03-23 13:47 ` Mark Brown
2026-03-24 12:49   ` Olivier MOYSAN
2026-03-24 12:54 ` Olivier MOYSAN
2026-03-24 12:58 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox