From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F9412D6401; Sat, 21 Mar 2026 12:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774096965; cv=none; b=O37KfKHGf4oNL9nomfU/wESLpjmVLKofjjhUedvuYRhJ4KXQx6J9xkqakFFoKNHdwo4WB/pSRbJlrcdHXnSEwmpR27Cs50vdG4QnoBJvIfQKdUtk3TKk7TT5HWzpY1tHdNGO4/7xxMf7URYQtx36Dtj9ohK72dvcl4EsJCMTfi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774096965; c=relaxed/simple; bh=MjYkdz9+L0pyMEt2KrtErEE8PXR6dETfF3AbkkP3hG0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VL6u9KdM70mxAd9GHW5W2nwbtHXo7v27sDed9O+L0jC/SiIU5+Clgp8pbdHlFKOi66TqKrJ8pgRo11vSJarvmcmEqmQh0RfWTOM0SWLeUrJhyrxokVex3/cRaUp/AyPU9+XJM1DmlOn7wq4WnSvJcfQPp3wPI1rkQoNyxJ3ejYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i7ipOjvg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i7ipOjvg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03A1BC19421; Sat, 21 Mar 2026 12:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774096965; bh=MjYkdz9+L0pyMEt2KrtErEE8PXR6dETfF3AbkkP3hG0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i7ipOjvgSojBhyyQqFGUVKqo+FjYzHwF0TFIW5V+Wk2gTo85vTsLXCIjtTI9eDx4p ZYpbMgBAWf1eFANJ8Ngy7a8iPkRtkoHDQyOyN69enJXQo4+rtAjQ0723PYTYducVf0 A29FpB4iZm+YL8iKb5/2o960t/mFyE8ukAklHkSdTrhCaLnuGL2ql40bzWiAYTowAP vd2AK+Sex0Mtu6gezG5bAp/DkUxFSW77SYgEAALPd4i65qwZz/jguxtAQAnxz6JSn8 cXrjUTXtgrZC7k3+zNuOkV6C2dKbFf1gqAYXn63aJzqqIvDmRJXrByy2vzX0kiU1D0 M2VyVOMD6v/XA== Date: Sat, 21 Mar 2026 12:42:35 +0000 From: Jonathan Cameron To: Erikas Bitovtas Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [PATCH v6 1/8] dt-bindings: iio: light: vcnl4000: add regulators Message-ID: <20260321124235.1d07d486@jic23-huawei> In-Reply-To: <20260320-vcnl4000-regulators-v6-1-0d24d20b1a5b@gmail.com> References: <20260320-vcnl4000-regulators-v6-0-0d24d20b1a5b@gmail.com> <20260320-vcnl4000-regulators-v6-1-0d24d20b1a5b@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Mar 2026 18:45:36 +0200 Erikas Bitovtas wrote: > These sensors can accept 2 supplies - one for the sensor and one for IR > LED [1]. Add supply properties for the sensor - 2 for the sensors and > one external, for their open drain interrupt line, to ensure the sensor > is powered on before proceeding with setup. > > [1] https://www.vishay.com/docs/84274/vcnl4040.pdf > > Reviewed-by: David Lechner > Signed-off-by: Erikas Bitovtas > --- > .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml > index 2ba4d5de4ec4..516afef7a545 100644 > --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml > +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml > @@ -33,6 +33,17 @@ properties: > interrupts: > maxItems: 1 > > + vdd-supply: > + description: Regulator providing power to the "VDD" pin. > + > + vio-supply: > + description: Regulator providing power for pull-up of the I/O lines. > + Does not connect to the sensor directly, but is needed for the > + correct operation of the I2C and interrupt lines. It's optional so I guess it doesn't matter, but whether this supply is needed of not is down to whether the SoC allows for pull up on the interrupt and I2C lines. Some SoCs provide this (though it's been a while since I used one that did.). In other cases an external pull up is needed. It would feel odd to provide a supply for the pull up it was all hidden in the SoC. Anyhow, optional so we aren't forcing this anyway. Jonathan > + > + vled-supply: > + description: Regulator providing power to the IR anode pin. > + > reg: > maxItems: 1 > > @@ -54,6 +65,9 @@ examples: > compatible = "vishay,vcnl4200"; > reg = <0x51>; > proximity-near-level = <220>; > + vdd-supply = <®_vdd>; > + vio-supply = <®_vio>; > + vled-supply = <®_vled>; > }; > }; > ... >