From: kernel test robot <lkp@intel.com>
To: "Radu Sabau via B4 Relay"
<devnull+radu.sabau.analog.com@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: oe-kbuild-all@lists.linux.dev, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
Radu Sabau <radu.sabau@analog.com>
Subject: Re: [PATCH v4 4/4] iio: adc: ad4691: add SPI offload support
Date: Sun, 22 Mar 2026 11:05:31 +0800 [thread overview]
Message-ID: <202603221011.rzczUvUN-lkp@intel.com> (raw)
In-Reply-To: <20260320-ad4692-multichannel-sar-adc-driver-v4-4-052c1050507a@analog.com>
Hi Radu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 11439c4635edd669ae435eec308f4ab8a0804808]
url: https://github.com/intel-lab-lkp/linux/commits/Radu-Sabau-via-B4-Relay/dt-bindings-iio-adc-add-AD4691-family/20260321-120718
base: 11439c4635edd669ae435eec308f4ab8a0804808
patch link: https://lore.kernel.org/r/20260320-ad4692-multichannel-sar-adc-driver-v4-4-052c1050507a%40analog.com
patch subject: [PATCH v4 4/4] iio: adc: ad4691: add SPI offload support
config: nios2-randconfig-r122-20260322 (https://download.01.org/0day-ci/archive/20260322/202603221011.rzczUvUN-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260322/202603221011.rzczUvUN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603221011.rzczUvUN-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/iio/adc/ad4691.c:954:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/iio/adc/ad4691.c:954:39: sparse: expected unsigned int
drivers/iio/adc/ad4691.c:954:39: sparse: got restricted __be32 [usertype]
drivers/iio/adc/ad4691.c:970:31: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/iio/adc/ad4691.c:970:31: sparse: expected unsigned int
drivers/iio/adc/ad4691.c:970:31: sparse: got restricted __be32 [usertype]
drivers/iio/adc/ad4691.c:1059:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int @@ got restricted __be32 [usertype] @@
drivers/iio/adc/ad4691.c:1059:39: sparse: expected unsigned int
drivers/iio/adc/ad4691.c:1059:39: sparse: got restricted __be32 [usertype]
>> drivers/iio/adc/ad4691.c:1072:30: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] offload_tx_reset @@ got restricted __be32 [usertype] @@
drivers/iio/adc/ad4691.c:1072:30: sparse: expected unsigned int [usertype] offload_tx_reset
drivers/iio/adc/ad4691.c:1072:30: sparse: got restricted __be32 [usertype]
vim +954 drivers/iio/adc/ad4691.c
927
928 static int ad4691_manual_offload_buffer_postenable(struct iio_dev *indio_dev)
929 {
930 struct ad4691_state *st = iio_priv(indio_dev);
931 struct device *dev = regmap_get_device(st->regmap);
932 struct spi_device *spi = to_spi_device(dev);
933 struct spi_offload_trigger_config config = {
934 .type = SPI_OFFLOAD_TRIGGER_PERIODIC,
935 };
936 unsigned int bit, k;
937 int ret;
938
939 ret = ad4691_enter_conversion_mode(st);
940 if (ret)
941 return ret;
942
943 memset(st->offload_xfer, 0, sizeof(st->offload_xfer));
944
945 /*
946 * N+1 transfers for N channels. Each CS-low period triggers
947 * a conversion AND returns the previous result (pipelined).
948 * TX: [AD4691_ADC_CHAN(n), 0x00, 0x00, 0x00]
949 * RX: [data_hi, data_lo, 0x00, 0x00] (shift=16)
950 * Transfer 0 RX is garbage; transfers 1..N carry real data.
951 */
952 k = 0;
953 iio_for_each_active_channel(indio_dev, bit) {
> 954 st->offload_tx_cmd[k] =
955 cpu_to_be32(FIELD_PREP(AD4691_MSG_ADDR_HI,
956 AD4691_ADC_CHAN(bit)));
957 st->offload_xfer[k].tx_buf = &st->offload_tx_cmd[k];
958 st->offload_xfer[k].len = sizeof(u32);
959 st->offload_xfer[k].bits_per_word = AD4691_OFFLOAD_BITS_PER_WORD;
960 st->offload_xfer[k].cs_change = 1;
961 st->offload_xfer[k].cs_change_delay.value = AD4691_CNV_HIGH_TIME_NS;
962 st->offload_xfer[k].cs_change_delay.unit = SPI_DELAY_UNIT_NSECS;
963 /* First transfer RX is garbage — skip it. */
964 if (k > 0)
965 st->offload_xfer[k].offload_flags = SPI_OFFLOAD_XFER_RX_STREAM;
966 k++;
967 }
968
969 /* Final NOOP to flush pipeline and capture last channel. */
970 st->offload_tx_cmd[k] =
971 cpu_to_be32(FIELD_PREP(AD4691_MSG_ADDR_HI, AD4691_NOOP));
972 st->offload_xfer[k].tx_buf = &st->offload_tx_cmd[k];
973 st->offload_xfer[k].len = sizeof(u32);
974 st->offload_xfer[k].bits_per_word = AD4691_OFFLOAD_BITS_PER_WORD;
975 st->offload_xfer[k].offload_flags = SPI_OFFLOAD_XFER_RX_STREAM;
976 k++;
977
978 spi_message_init_with_transfers(&st->offload_msg, st->offload_xfer, k);
979 st->offload_msg.offload = st->offload;
980
981 ret = spi_optimize_message(spi, &st->offload_msg);
982 if (ret)
983 goto err_exit_conversion;
984
985 config.periodic.frequency_hz = st->offload_trigger_hz;
986 ret = spi_offload_trigger_enable(st->offload, st->offload_trigger, &config);
987 if (ret)
988 goto err_unoptimize;
989
990 return 0;
991
992 err_unoptimize:
993 spi_unoptimize_message(&st->offload_msg);
994 err_exit_conversion:
995 ad4691_exit_conversion_mode(st);
996 return ret;
997 }
998
999 static int ad4691_manual_offload_buffer_predisable(struct iio_dev *indio_dev)
1000 {
1001 struct ad4691_state *st = iio_priv(indio_dev);
1002
1003 spi_offload_trigger_disable(st->offload, st->offload_trigger);
1004 spi_unoptimize_message(&st->offload_msg);
1005
1006 return ad4691_exit_conversion_mode(st);
1007 }
1008
1009 static const struct iio_buffer_setup_ops ad4691_manual_offload_buffer_setup_ops = {
1010 .postenable = &ad4691_manual_offload_buffer_postenable,
1011 .predisable = &ad4691_manual_offload_buffer_predisable,
1012 };
1013
1014 static int ad4691_cnv_burst_offload_buffer_postenable(struct iio_dev *indio_dev)
1015 {
1016 struct ad4691_state *st = iio_priv(indio_dev);
1017 struct device *dev = regmap_get_device(st->regmap);
1018 struct spi_device *spi = to_spi_device(dev);
1019 struct spi_offload_trigger_config config = {
1020 .type = SPI_OFFLOAD_TRIGGER_DATA_READY,
1021 };
1022 unsigned int n_active = hweight_long(*indio_dev->active_scan_mask);
1023 unsigned int bit, k;
1024 int ret;
1025
1026 ret = regmap_write(st->regmap, AD4691_ACC_MASK_REG,
1027 (u16)~(*indio_dev->active_scan_mask));
1028 if (ret)
1029 return ret;
1030
1031 ret = regmap_write(st->regmap, AD4691_STD_SEQ_CONFIG,
1032 *indio_dev->active_scan_mask);
1033 if (ret)
1034 return ret;
1035
1036 iio_for_each_active_channel(indio_dev, bit) {
1037 ret = regmap_write(st->regmap, AD4691_ACC_COUNT_LIMIT(bit),
1038 AD4691_ACC_COUNT_VAL);
1039 if (ret)
1040 return ret;
1041 }
1042
1043 ret = ad4691_enter_conversion_mode(st);
1044 if (ret)
1045 return ret;
1046
1047 memset(st->offload_xfer, 0, sizeof(st->offload_xfer));
1048
1049 /*
1050 * N transfers to read N AVG_IN registers plus one state-reset
1051 * transfer (no RX) to re-arm DATA_READY.
1052 * TX: [reg_hi | 0x80, reg_lo, 0x00, 0x00]
1053 * RX: [0x00, 0x00, data_hi, data_lo] (shift=0)
1054 */
1055 k = 0;
1056 iio_for_each_active_channel(indio_dev, bit) {
1057 unsigned int reg = AD4691_AVG_IN(bit);
1058
1059 st->offload_tx_cmd[k] =
1060 cpu_to_be32(((reg >> 8 | 0x80) << 24) |
1061 ((reg & 0xFF) << 16));
1062 st->offload_xfer[k].tx_buf = &st->offload_tx_cmd[k];
1063 st->offload_xfer[k].len = sizeof(u32);
1064 st->offload_xfer[k].bits_per_word = AD4691_OFFLOAD_BITS_PER_WORD;
1065 st->offload_xfer[k].offload_flags = SPI_OFFLOAD_XFER_RX_STREAM;
1066 if (k < n_active - 1)
1067 st->offload_xfer[k].cs_change = 1;
1068 k++;
1069 }
1070
1071 /* State reset to re-arm DATA_READY for the next scan. */
> 1072 st->offload_tx_reset =
1073 cpu_to_be32(((AD4691_STATE_RESET_REG >> 8) << 24) |
1074 ((AD4691_STATE_RESET_REG & 0xFF) << 16) |
1075 (AD4691_STATE_RESET_ALL << 8));
1076 st->offload_xfer[k].tx_buf = &st->offload_tx_reset;
1077 st->offload_xfer[k].len = sizeof(u32);
1078 st->offload_xfer[k].bits_per_word = AD4691_OFFLOAD_BITS_PER_WORD;
1079 k++;
1080
1081 spi_message_init_with_transfers(&st->offload_msg, st->offload_xfer, k);
1082 st->offload_msg.offload = st->offload;
1083
1084 ret = spi_optimize_message(spi, &st->offload_msg);
1085 if (ret)
1086 goto err_exit_conversion;
1087
1088 ret = ad4691_sampling_enable(st, true);
1089 if (ret)
1090 goto err_unoptimize;
1091
1092 ret = spi_offload_trigger_enable(st->offload, st->offload_trigger, &config);
1093 if (ret)
1094 goto err_sampling_disable;
1095
1096 return 0;
1097
1098 err_sampling_disable:
1099 ad4691_sampling_enable(st, false);
1100 err_unoptimize:
1101 spi_unoptimize_message(&st->offload_msg);
1102 err_exit_conversion:
1103 ad4691_exit_conversion_mode(st);
1104 return ret;
1105 }
1106
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-03-22 3:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 11:03 [PATCH v4 0/4] iio: adc: ad4691: add driver for AD4691 multichannel SAR ADC family Radu Sabau via B4 Relay
2026-03-20 11:03 ` [PATCH v4 1/4] dt-bindings: iio: adc: add AD4691 family Radu Sabau via B4 Relay
2026-03-20 12:26 ` Rob Herring (Arm)
2026-03-21 14:35 ` Jonathan Cameron
2026-03-21 16:11 ` David Lechner
2026-03-20 11:03 ` [PATCH v4 2/4] iio: adc: ad4691: add initial driver for " Radu Sabau via B4 Relay
2026-03-20 15:16 ` Andy Shevchenko
2026-03-21 14:48 ` Jonathan Cameron
2026-03-23 11:44 ` Nuno Sá
2026-03-20 11:03 ` [PATCH v4 3/4] iio: adc: ad4691: add triggered buffer support Radu Sabau via B4 Relay
2026-03-20 16:14 ` Uwe Kleine-König
2026-03-21 15:16 ` Jonathan Cameron
2026-03-23 9:03 ` Sabau, Radu bogdan
2026-03-24 12:22 ` Nuno Sá
2026-03-25 12:47 ` Sabau, Radu bogdan
2026-03-25 13:12 ` Nuno Sá
2026-03-20 11:03 ` [PATCH v4 4/4] iio: adc: ad4691: add SPI offload support Radu Sabau via B4 Relay
2026-03-20 17:07 ` Andy Shevchenko
2026-03-21 15:28 ` Jonathan Cameron
2026-03-22 3:05 ` kernel test robot [this message]
2026-03-23 13:06 ` kernel test robot
2026-03-25 11:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202603221011.rzczUvUN-lkp@intel.com \
--to=lkp@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+radu.sabau.analog.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=radu.sabau@analog.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox