From: Jonathan Cameron <jic23@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Jander" <david@protonic.nl>
Subject: Re: [PATCH v6 03/12] iio: dac: ds4424: sort headers alphabetically
Date: Sun, 22 Mar 2026 12:43:10 +0000 [thread overview]
Message-ID: <20260322124310.08e0541e@jic23-huawei> (raw)
In-Reply-To: <20260210135110.2027073-4-o.rempel@pengutronix.de>
On Tue, 10 Feb 2026 14:51:01 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Sort the header inclusions alphabetically. This improves readability and
> simplifies adding new includes in the future.
>
> Group subsystem-specific headers (linux/iio/*) separately at the end
> to clarify subsystem context.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
I applied this one by hand as iio/consumer.h isn't used and another
series had removed it in the meantime.
Thanks,
Jonathan
> ---
> changes v6:
> - no changes
> changes v5:
> - no changes
> changes v4:
> - no changes
> changes v3:
> - Keep linux/iio/* headers in a separate group at the end of the includes.
> changes v2:
> - new patch
> ---
> drivers/iio/dac/ds4424.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 36286e4923af..c03051dc763e 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -6,16 +6,17 @@
> */
>
> #include <linux/bits.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/i2c.h>
> #include <linux/regulator/consumer.h>
> -#include <linux/err.h>
> -#include <linux/delay.h>
> -#include <linux/iio/iio.h>
> +
> +#include <linux/iio/consumer.h>
> #include <linux/iio/driver.h>
> +#include <linux/iio/iio.h>
> #include <linux/iio/machine.h>
> -#include <linux/iio/consumer.h>
>
> #define DS4422_MAX_DAC_CHANNELS 2
> #define DS4424_MAX_DAC_CHANNELS 4
next prev parent reply other threads:[~2026-03-22 12:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 13:50 [PATCH v6 00/12] iio: dac: ds4424: add DS4402/DS4404 support and scale Oleksij Rempel
2026-02-10 13:50 ` [PATCH v6 01/12] iio: dac: ds4424: refactor raw access to use bitwise operations Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 02/12] iio: dac: ds4424: ratelimit read errors and use device context Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 03/12] iio: dac: ds4424: sort headers alphabetically Oleksij Rempel
2026-03-22 12:43 ` Jonathan Cameron [this message]
2026-02-10 13:51 ` [PATCH v6 04/12] iio: dac: ds4424: rename iio_info struct to avoid ambiguity Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 05/12] iio: dac: ds4424: use device match data for chip info Oleksij Rempel
2026-02-10 14:50 ` Andy Shevchenko
2026-02-10 13:51 ` [PATCH v6 06/12] iio: dac: ds4424: use fsleep() instead of usleep_range() Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 07/12] dt-bindings: iio: dac: maxim,ds4424: add ds4402/ds4404 Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 08/12] iio: dac: ds4424: add DS4402/DS4404 device IDs Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 09/12] iio: dac: ds4424: support per-variant output range limits Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 10/12] iio: dac: ds4424: convert to regmap Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 11/12] dt-bindings: iio: dac: maxim,ds4424: add maxim,rfs-ohms property Oleksij Rempel
2026-02-10 13:51 ` [PATCH v6 12/12] iio: dac: ds4424: add Rfs-based scale and per-variant limits Oleksij Rempel
2026-02-26 8:42 ` [PATCH v6 00/12] iio: dac: ds4424: add DS4402/DS4404 support and scale Oleksij Rempel
2026-02-26 10:08 ` Jonathan Cameron
2026-03-22 12:45 ` Jonathan Cameron
2026-03-22 17:22 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260322124310.08e0541e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox