From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B19311D86DC; Sun, 22 Mar 2026 16:53:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774198385; cv=none; b=EhV+TASuY7i+CPcxVXLiitzJ2rGqDaafD1m6aOQvKm641OUtoH6PJfgYnx3hAAiPhwGY5N6xgIbRUf5sc30eI2RT13rewxbFTKCP4U+Z7f6wYj/z0o5XMRQxaLxLGTyuzXLgYot2BbvB4vOn4NoTrJqnZ+Y79VUWVYuezNQWTXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774198385; c=relaxed/simple; bh=6uFgRQK3htx5s9x552LsldfqICu02lfafBPLNW3diBE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Kd3S9LNsZTcZXSNM27dc7szVlgZL+bSlMUufpCzfyYCHkxlWy+uoxoR9JD1Dmoe6JhRUbEFVoBzfXUHiwkbBYbNZA/shzpN5pwipJjXh6LQQsR/vB6OVtVy3FlB5CdWW2DfAHUo2LLtzLWKa968kn6BiIRsyGHkvx/0HHCchlrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cKTpF6SZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cKTpF6SZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 871CAC19424; Sun, 22 Mar 2026 16:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774198385; bh=6uFgRQK3htx5s9x552LsldfqICu02lfafBPLNW3diBE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cKTpF6SZxL6mlaqynT2XAz4tBtqqBoObe+Vk6rxSs6iIKTMF7RPzOH0puZVKBE2Ir FVPLM5fNZH9heHwR5NSTSokrliDeDwmBkBXyi9GiVeg8Fp2GFpcv3V2rRmh1Gh4KfY dwpGeNyb29xuaItZkJB0lED0MAgzYDj1Jo903gIAel8sgc1R8NX4zBS/G/IH1pikv5 lkEYkeCxznuNnEcmDheh/MH4OaSBv7/fju/5hVLAtpCJXwxB64PascAdMmCruIs8hK rmg+hamtZEsXb1bJoKUCLRbORINwSB4FariloSgG0zf1pY/GSxZhQkTpdL8NMSrVR4 ZyKc1Dv4ADOxg== Date: Sun, 22 Mar 2026 16:52:53 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan Subject: Re: [PATCH RFC v2 3/9] iio: frequency: ad9910: add simple parallel port mode support Message-ID: <20260322165253.56172dd9@jic23-huawei> In-Reply-To: References: <20260318-ad9910-iio-driver-v2-0-e79f93becf11@analog.com> <20260318-ad9910-iio-driver-v2-3-e79f93becf11@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 18 Mar 2026 20:28:34 +0200 Andy Shevchenko wrote: > On Wed, Mar 18, 2026 at 05:56:03PM +0000, Rodrigo Alencar via B4 Relay wrote: > > > Add parallel port channel with frequency scale, frequency offset, phase > > offset, and amplitude offset extended attributes for configuring the > > parallel data path. > > ... > > > + ret = iio_str_to_fixpoint(buf, MICRO / 10, &val, &val2); > > I think here we just use 100000 as it's in so many drivers de facto use. > ideally this should be fixed on API level. I wouldn't mind a series tidying this up, but if anyone proposes to do that we'll want to not use the same naming so it is obvious if any new drivers assume the old scaling. I can't really remember why we ended up with the odd interface :( Jonathan