From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBD836C5BB for ; Mon, 23 Mar 2026 20:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774298285; cv=none; b=TfF8qHbjEqcee9O/X6Fs4BERLGMGVP65bPXMuFchzOgXAnpblOTjFZPvN6P029DQ/W5jPuau9H5DsuEkjJFLhAtHa3zuZ2dSD6sHhAfGNZkR53wVkph8QMtno3/2qB43i/b3s/pqvHFywBL23AUKcJqAZm4qhwuRVDN//7g8ir0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774298285; c=relaxed/simple; bh=Yt7USsk3cuGUzCm1y+OZ6JKq00IJQcMuuHfBv45NCGI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jjodeea5QqstculBlLu+Fk2uQKD30t22ofSGsLuyuKuweMd9Vs5K0Sc/Rf2qb9PrEgO+EgpVu66TaFjcB9yc91ReSWrHGc8IehzkuyRG1Z6d1Ul/P6nwd5CEUtHMUcI8gtn5D5p7OcnZT5tSXbz32b/SU9TR7xbW2y0fEQpuX5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w4m1e-00032Q-TH; Mon, 23 Mar 2026 21:37:26 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w4m1e-001mnM-0D; Mon, 23 Mar 2026 21:37:26 +0100 Received: from pengutronix.de (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id B4BBC50B02C; Mon, 23 Mar 2026 20:37:25 +0000 (UTC) Date: Mon, 23 Mar 2026 21:37:24 +0100 From: Marc Kleine-Budde To: Conor Dooley Cc: Viken Dadhaniya , mani@kernel.org, thomas.kopp@microchip.com, mailhol@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linusw@kernel.org, brgl@kernel.org, linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, anup.kulkarni@oss.qualcomm.com Subject: Re: [PATCH v3 1/2] dt-bindings: can: mcp251xfd: add microchip,xstbyen property Message-ID: <20260323-artificial-ecstatic-collie-047169-mkl@pengutronix.de> X-AI: stop_reason: "refusal" References: <20260321135031.3107408-1-viken.dadhaniya@oss.qualcomm.com> <20260321135031.3107408-2-viken.dadhaniya@oss.qualcomm.com> <20260323-bonded-ranging-c9f9c4d0aacf@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mj7lxv6n5m3i3nve" Content-Disposition: inline In-Reply-To: <20260323-bonded-ranging-c9f9c4d0aacf@spud> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org --mj7lxv6n5m3i3nve Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 1/2] dt-bindings: can: mcp251xfd: add microchip,xstbyen property MIME-Version: 1.0 On 23.03.2026 19:30:00, Conor Dooley wrote: > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp251= xfd.yaml b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.ya= ml > > index 2d13638ebc6a..28e494262cd9 100644 > > --- a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml > > @@ -44,6 +44,14 @@ properties: > > signals a pending RX interrupt. > > maxItems: 1 > > > > + microchip,xstbyen: > > + type: boolean > > + description: > > + If present, configure the INT0/GPIO0/XSTBY pin as transceiver st= andby > > + control. The pin is driven low when the controller is active and= high > > + when it enters Sleep mode, allowing automatic standby control of= an > > + external CAN transceiver connected to this pin. > > What I don't understand from this patch is why a property for this is > required. > Why can't this mode be implied from the lack of rx-int-gpios or > interrupts? The mcp251xfd has 2 GPIO pins. "rx-int-gpios" is for the other pin: INT1/GPIO1. Also by default I don't want the controller to drive a pin in a certain direction. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --mj7lxv6n5m3i3nve Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSl+MghEFFAdY3pYJLMOmT6rpmt0gUCacGkfQAKCRDMOmT6rpmt 0lw8AP4hL8Ju237y3P6/SPoa8sYRa5wDdt5saifjrXPVIRURYgD+Nk36Nzd9OCQh mZ9s0Zw8dTT8RbvjyTcZSzMvAG3mMQ8= =PjbA -----END PGP SIGNATURE----- --mj7lxv6n5m3i3nve--