Re: [PATCH 1/3] dt-bindings: hwmon: Add support for NXP P3T1084UK temperature sensor

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2503 bytes --]

On Mon, Mar 23, 2026 at 09:52:50PM +0530, Anshika Gupta wrote:
> The P3T1084UK is an NXP digital temperature sensor compatible with the
> Texas Instruments TMP108 register and protocol specification. This patch

Then why is tmp108 not used as a fallback compatible? Looks from the
driver patch like it would be suitable.

> extends the existing DT binding for "ti,tmp108" to document the
> compatible string for P3T1084UK so that the hwmon TMP108 driver can
> bind to this device.
> 
> Signed-off-by: Lakshay Piplani <lakshaypiplani77@gmail.com>

What did Lakshay do? You're author and submitter, but their sign-off is
here. Are you missing a co-developed-by?

> Signed-off-by: Anshika Gupta <guptaanshika.ag@gmail.com>
> ---
>  Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> index 9f6c9f6fa561..47714df5aaff 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> @@ -4,20 +4,21 @@
>  $id: http://devicetree.org/schemas/hwmon/ti,tmp108.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: TMP108/P3T1035/P3T1085/P3T2030 temperature sensor
> +title: TMP108/P3T1035/P3T1084/P3T1085/P3T2030 temperature sensor
>  
>  maintainers:
>    - Krzysztof Kozlowski <krzk@kernel.org>
>  
>  description: |
> -  The TMP108 or NXP P3T Family (P3T1035, P3T1085 and P3T2030) is a digital-
> +  The TMP108 or NXP P3T Family (P3T1035, P3T1084, P3T1085 and P3T2030) is a digital-
>    output temperature sensor with a dynamically-programmable limit window,
>    and under- and over-temperature alert functions.
>  
> -  NXP P3T Family (P3T1035, P3T1085 and P3T2030) supports I3C.
> +  NXP P3T Family (P3T1035, P3T1084, P3T1085 and P3T2030) supports I3C.
>  
>    Datasheets:
>      https://www.ti.com/product/TMP108
> +    https://www.nxp.com/docs/en/data-sheet/P3T1084UK.pdf
>      https://www.nxp.com/docs/en/data-sheet/P3T1085UK.pdf
>      https://www.nxp.com/docs/en/data-sheet/P3T1035XUK_P3T2030XUK.pdf
>  
> @@ -28,6 +29,7 @@ properties:
>            - const: nxp,p3t2030
>            - const: nxp,p3t1035
>        - const: nxp,p3t1035
> +      - const: nxp,p3t1084
>        - const: nxp,p3t1085
>        - const: ti,tmp108
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]