From: Conor Dooley <conor@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
mani@kernel.org, thomas.kopp@microchip.com, mailhol@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konradybcio@kernel.org, linusw@kernel.org,
brgl@kernel.org, linux-can@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
mukesh.savaliya@oss.qualcomm.com, anup.kulkarni@oss.qualcomm.com
Subject: Re: [PATCH v3 1/2] dt-bindings: can: mcp251xfd: add microchip,xstbyen property
Date: Mon, 23 Mar 2026 21:30:24 +0000 [thread overview]
Message-ID: <20260323-surname-osmosis-3cceca19c824@spud> (raw)
In-Reply-To: <20260323-artificial-ecstatic-collie-047169-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
On Mon, Mar 23, 2026 at 09:37:24PM +0100, Marc Kleine-Budde wrote:
> On 23.03.2026 19:30:00, Conor Dooley wrote:
> > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> > > index 2d13638ebc6a..28e494262cd9 100644
> > > --- a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> > > @@ -44,6 +44,14 @@ properties:
> > > signals a pending RX interrupt.
> > > maxItems: 1
> > >
> > > + microchip,xstbyen:
> > > + type: boolean
> > > + description:
> > > + If present, configure the INT0/GPIO0/XSTBY pin as transceiver standby
> > > + control. The pin is driven low when the controller is active and high
> > > + when it enters Sleep mode, allowing automatic standby control of an
> > > + external CAN transceiver connected to this pin.
> >
> > What I don't understand from this patch is why a property for this is
> > required.
> > Why can't this mode be implied from the lack of rx-int-gpios or
> > interrupts?
>
> The mcp251xfd has 2 GPIO pins. "rx-int-gpios" is for the other pin:
> INT1/GPIO1. Also by default I don't want the controller to drive a pin
> in a certain direction.
Oke.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-23 21:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 13:50 [PATCH v3 0/2] can: mcp251xfd: add XSTBYEN transceiver standby control Viken Dadhaniya
2026-03-21 13:50 ` [PATCH v3 1/2] dt-bindings: can: mcp251xfd: add microchip,xstbyen property Viken Dadhaniya
2026-03-23 10:41 ` Marc Kleine-Budde
2026-03-23 19:30 ` Conor Dooley
2026-03-23 20:37 ` Marc Kleine-Budde
2026-03-23 21:30 ` Conor Dooley [this message]
2026-03-31 6:45 ` Viken Dadhaniya
2026-03-31 7:10 ` Marc Kleine-Budde
2026-03-21 13:50 ` [PATCH v3 2/2] can: mcp251xfd: add support for XSTBYEN transceiver standby control Viken Dadhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323-surname-osmosis-3cceca19c824@spud \
--to=conor@kernel.org \
--cc=andersson@kernel.org \
--cc=anup.kulkarni@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mani@kernel.org \
--cc=mkl@pengutronix.de \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=thomas.kopp@microchip.com \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox