[PATCH v4 0/4] hwmon: (sht3x) Add support for GXCAS GXHT30

[PATCH v4 0/4] hwmon: (sht3x) Add support for GXCAS GXHT30

[Zaixiang Xu]

This series adds support for the GXCAS GXHT30 humidity and temperature 
sensor. The GXHT30 is software compatible with the Sensirion SHT30 series.

This series also introduces the missing YAML binding schema for the
Sensirion SHT30 family, replacing wildcards with specific model names.

Changes in v4:
- Use match data (.data) to correctly distinguish between SHT (humidity/
  temperature) and STS (temperature-only) sensors in the driver, fixing
  a logic error where STS sensors would report bogus humidity
  (suggested by Guenter Roeck and AI review).
- Update YAML bindings to use fallback compatibles for compatible chips
  and add optional 'interrupts' and 'vdd-supply' properties
  (suggested by Guenter Roeck and AI review).
- Simplified of_match_table to only include base models due to the 
  newly added fallback mechanism.
- Renamed binding file from sensirion,sht3x.yaml to sensirion,sht30.yaml.
- Include Conor's Acked-by for the vendor-prefix patch.

Changes in v3:
- Split driver changes into two patches: one for DT framework and one 
  for adding GXHT30 (suggested by Guenter Roeck).
- Fixed commit message line lengths (suggested by Guenter Roeck).
- Removed wildcards 'x' from compatibles and used specific model names
  (suggested by Conor Dooley).
- Added manufacturer website to vendor-prefix patch (suggested by Conor Dooley).
- Fixed missing newline at end of YAML file (reported by kernel test robot).

Changes in v2:
- Fix placeholder "Your Name" in MODULE_AUTHOR.


Zaixiang Xu (4):
  dt-bindings: vendor-prefixes: Add GXCAS Technology
  dt-bindings: hwmon: Add Sensirion SHT30 series
  hwmon: (sht3x) Add devicetree support
  hwmon: (sht3x) Add support for GXCAS GXHT30

 .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 drivers/hwmon/sht3x.c                         | 16 +++++-
 3 files changed, 67 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml

-- 
2.34.1

[PATCH v4 1/4] dt-bindings: vendor-prefixes: Add GXCAS Technology

[Zaixiang Xu]

Add vendor prefix for Beijing Galaxy-CAS Technology Co., Ltd. (GXCAS).
The prefix was confirmed from the manufacturer's website:
https://www.gxcas.com/en/index.html

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index ee7fd3cfe203..354836eb8e72 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -676,6 +676,8 @@ patternProperties:
     description: Gateworks Corporation
                  use "gateworks" vendor prefix
     deprecated: true
+  "^gxcas,.*":
+    description: Beijing Galaxy-CAS Technology Co., Ltd.
   "^hannstar,.*":
     description: HannStar Display Corporation
   "^haochuangyi,.*":
-- 
2.34.1

[PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Zaixiang Xu]

Add YAML devicetree binding schema for Sensirion SHT30 series.
Use fallback compatibles for compatible chips and add optional
interrupts and vdd-supply properties.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
---
 .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
new file mode 100644
index 000000000000..1b5ce822b37b
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
+$schema: http://devicetree.org/meta-schema.yaml#
+
+title: Sensirion SHT30 Humidity and Temperature Sensor
+
+maintainers:
+  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
+
+description: |
+  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
+  Compatible sensors like the GXCAS GXHT30 are also supported.
+
+properties:
+  compatible:
+    enum:
+      - gxcas,gxht30
+      - sensirion,sht30
+      - sensirion,sht31
+      - sensirion,sht35
+      - sensirion,sht85
+      - sensirion,sts30
+      - sensirion,sts31
+      - sensirion,sts32
+      - sensirion,sts35
+
+  reg:
+    maxItems: 1
+    description: I2C address (usually 0x44 or 0x45)
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@44 {
+            compatible = "gxcas,gxht30";
+            reg = <0x44>;
+        };
+    };
+
-- 
2.34.1

[PATCH v4 3/4] hwmon: (sht3x) Add devicetree support

[Zaixiang Xu]

Add of_match_table to support devicetree based instantiation.
Specific match data is used to distinguish between temperature/humidity
(SHT) and temperature-only (STS) sensors.

Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
---
 drivers/hwmon/sht3x.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
index 08306ccb6d0b..f2b1d3b8eb23 100644
--- a/drivers/hwmon/sht3x.c
+++ b/drivers/hwmon/sht3x.c
@@ -939,8 +939,19 @@ static const struct i2c_device_id sht3x_ids[] = {
 
 MODULE_DEVICE_TABLE(i2c, sht3x_ids);
 
+static const struct of_device_id sht3x_of_match[] = {
+	{ .compatible = "sensirion,sht30", .data = (void *)sht3x },
+	{ .compatible = "sensirion,sts30", .data = (void *)sts3x },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(of, sht3x_of_match);
+
 static struct i2c_driver sht3x_i2c_driver = {
-	.driver.name = "sht3x",
+	.driver = {
+		.name = "sht3x",
+		.of_match_table = sht3x_of_match,
+	},
 	.probe       = sht3x_probe,
 	.id_table    = sht3x_ids,
 };
-- 
2.34.1

[PATCH v4 4/4] hwmon: (sht3x) Add support for GXCAS GXHT30

[Zaixiang Xu]

Add support for the GXCAS GXHT30 humidity and temperature sensor.
The GXHT30 is software compatible with the Sensirion SHT30.

Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
---
 drivers/hwmon/sht3x.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
index f2b1d3b8eb23..1561c0f46f75 100644
--- a/drivers/hwmon/sht3x.c
+++ b/drivers/hwmon/sht3x.c
@@ -934,6 +934,7 @@ static const struct i2c_device_id sht3x_ids[] = {
 	{"sht3x", sht3x},
 	{"sts3x", sts3x},
 	{"sht85", sht3x},
+	{"gxht30", sht3x},
 	{}
 };
 
@@ -942,6 +943,7 @@ MODULE_DEVICE_TABLE(i2c, sht3x_ids);
 static const struct of_device_id sht3x_of_match[] = {
 	{ .compatible = "sensirion,sht30", .data = (void *)sht3x },
 	{ .compatible = "sensirion,sts30", .data = (void *)sts3x },
+	{ .compatible = "gxcas,gxht30", .data = (void *)sht3x },
 	{ }
 };
 
@@ -959,5 +961,6 @@ module_i2c_driver(sht3x_i2c_driver);
 
 MODULE_AUTHOR("David Frey <david.frey@sensirion.com>");
 MODULE_AUTHOR("Pascal Sachs <pascal.sachs@sensirion.com>");
+MODULE_AUTHOR("Zaixiang Xu <zaixiang.xu.dev@gmail.com>");
 MODULE_DESCRIPTION("Sensirion SHT3x humidity and temperature sensor driver");
 MODULE_LICENSE("GPL");
-- 
2.34.1

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]

On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> Add YAML devicetree binding schema for Sensirion SHT30 series.
> Use fallback compatibles for compatible chips and add optional
> interrupts and vdd-supply properties.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/

The robot did not report that this binding was missing.
It also told you not to add these tags.

You also ignored my and Krzysztof's reviews.

NAK.

pw-bot: changes-requested

> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> ---
>  .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> new file mode 100644
> index 000000000000..1b5ce822b37b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
> +$schema: http://devicetree.org/meta-schema.yaml#
> +
> +title: Sensirion SHT30 Humidity and Temperature Sensor
> +
> +maintainers:
> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> +
> +description: |
> +  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
> +  Compatible sensors like the GXCAS GXHT30 are also supported.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - gxcas,gxht30
> +      - sensirion,sht30
> +      - sensirion,sht31
> +      - sensirion,sht35
> +      - sensirion,sht85
> +      - sensirion,sts30
> +      - sensirion,sts31
> +      - sensirion,sts32
> +      - sensirion,sts35
> +
> +  reg:
> +    maxItems: 1
> +    description: I2C address (usually 0x44 or 0x45)
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@44 {
> +            compatible = "gxcas,gxht30";
> +            reg = <0x44>;
> +        };
> +    };
> +
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Guenter Roeck]

On 3/25/26 11:20, Conor Dooley wrote:
> On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
>> Add YAML devicetree binding schema for Sensirion SHT30 series.
>> Use fallback compatibles for compatible chips and add optional
>> interrupts and vdd-supply properties.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> 
> The robot did not report that this binding was missing.
> It also told you not to add these tags.
> 
> You also ignored my and Krzysztof's reviews.
> 
> NAK.
> 

Maybe we should just point to AI feedback:

https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com

and only get involved after AI does not report any problems.

Guenter

> pw-bot: changes-requested
> 
>> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
>> ---
>>   .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>> new file mode 100644
>> index 000000000000..1b5ce822b37b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
>> +$schema: http://devicetree.org/meta-schema.yaml#
>> +
>> +title: Sensirion SHT30 Humidity and Temperature Sensor
>> +
>> +maintainers:
>> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
>> +
>> +description: |
>> +  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
>> +  Compatible sensors like the GXCAS GXHT30 are also supported.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - gxcas,gxht30
>> +      - sensirion,sht30
>> +      - sensirion,sht31
>> +      - sensirion,sht35
>> +      - sensirion,sht85
>> +      - sensirion,sts30
>> +      - sensirion,sts31
>> +      - sensirion,sts32
>> +      - sensirion,sts35
>> +
>> +  reg:
>> +    maxItems: 1
>> +    description: I2C address (usually 0x44 or 0x45)
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        sensor@44 {
>> +            compatible = "gxcas,gxht30";
>> +            reg = <0x44>;
>> +        };
>> +    };
>> +
>> -- 
>> 2.34.1
>>

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> On 3/25/26 11:20, Conor Dooley wrote:
> > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > Use fallback compatibles for compatible chips and add optional
> > > interrupts and vdd-supply properties.
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > 
> > The robot did not report that this binding was missing.
> > It also told you not to add these tags.
> > 
> > You also ignored my and Krzysztof's reviews.
> > 
> > NAK.
> > 
> 
> Maybe we should just point to AI feedback:
> 
> https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> 
> and only get involved after AI does not report any problems.
> 

The presentation of info in that is weird, it creates a pseudo-commit
message, and then goes on to talk about things that the pseudo-commit
message has had culled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > On 3/25/26 11:20, Conor Dooley wrote:
> > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > Use fallback compatibles for compatible chips and add optional
> > > > interrupts and vdd-supply properties.
> > > > 
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > > 
> > > The robot did not report that this binding was missing.
> > > It also told you not to add these tags.
> > > 
> > > You also ignored my and Krzysztof's reviews.
> > > 
> > > NAK.
> > > 
> > 
> > Maybe we should just point to AI feedback:
> > 
> > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> > 
> > and only get involved after AI does not report any problems.
> > 
> 
> The presentation of info in that is weird, it creates a pseudo-commit
> message, and then goes on to talk about things that the pseudo-commit
> message has had culled.

How good is this LLM stuff at figuring out if previous review feedback
has been resolved? Or is it not capable of looking at earlier revisions?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Guenter Roeck]

On 3/26/26 10:45, Conor Dooley wrote:
> On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
>> On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
>>> On 3/25/26 11:20, Conor Dooley wrote:
>>>> On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
>>>>> Add YAML devicetree binding schema for Sensirion SHT30 series.
>>>>> Use fallback compatibles for compatible chips and add optional
>>>>> interrupts and vdd-supply properties.
>>>>>
>>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
>>>>
>>>> The robot did not report that this binding was missing.
>>>> It also told you not to add these tags.
>>>>
>>>> You also ignored my and Krzysztof's reviews.
>>>>
>>>> NAK.
>>>>
>>>
>>> Maybe we should just point to AI feedback:
>>>
>>> https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
>>>
>>> and only get involved after AI does not report any problems.
>>>
>>
>> The presentation of info in that is weird, it creates a pseudo-commit
>> message, and then goes on to talk about things that the pseudo-commit
>> message has had culled.
> 
> How good is this LLM stuff at figuring out if previous review feedback
> has been resolved? Or is it not capable of looking at earlier revisions?


Both are interesting questions. For the first one, I had noticed that, but
to me it seemed that the pseudo-commit message is an attempt to create a concise
version of the commit message, and I have not seen evidence that the later
comments did not also apply to the real commit message.

Anyway, copying Roman for feedback on both.

Thanks,
Guenter

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]

On Thu, Mar 26, 2026 at 04:55:39PM -0700, Guenter Roeck wrote:
> On 3/26/26 10:45, Conor Dooley wrote:
> > On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> > > On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > > > On 3/25/26 11:20, Conor Dooley wrote:
> > > > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > > > Use fallback compatibles for compatible chips and add optional
> > > > > > interrupts and vdd-supply properties.
> > > > > > 
> > > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > > > > 
> > > > > The robot did not report that this binding was missing.
> > > > > It also told you not to add these tags.
> > > > > 
> > > > > You also ignored my and Krzysztof's reviews.
> > > > > 
> > > > > NAK.
> > > > > 
> > > > 
> > > > Maybe we should just point to AI feedback:
> > > > 
> > > > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> > > > 
> > > > and only get involved after AI does not report any problems.
> > > > 
> > > 
> > > The presentation of info in that is weird, it creates a pseudo-commit
> > > message, and then goes on to talk about things that the pseudo-commit
> > > message has had culled.
> > 
> > How good is this LLM stuff at figuring out if previous review feedback
> > has been resolved? Or is it not capable of looking at earlier revisions?
> 
> 
> Both are interesting questions. For the first one, I had noticed that, but
> to me it seemed that the pseudo-commit message is an attempt to create a concise
> version of the commit message, and I have not seen evidence that the later
> comments did not also apply to the real commit message.

Yeah, the comments did apply to the real commit message. I was just
confusing to me to see what looked to me like a commit message not
contain the info that was being referred to later on. I thought that the
LLM was hallucinating the comments until I went back to this mail and
realised the text was here.

> 
> Anyway, copying Roman for feedback on both.
> 
> Thanks,
> Guenter
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Roman Gushchin]

Hello,

The pseudo-commit message is intentional, Chris Mason initially
prompted it, and I'm honestly just using his format. The intention
here is to ensure the LLM reviews the correct commit and at least
understands what it's doing. Idk if it's really useful with Sashiko,
but it's there and hopefully not too distracting.

Re previous versions: it's not implemented yet, but I plan to add this
eventually.

Thanks!


On Thu, Mar 26, 2026 at 5:03 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Mar 26, 2026 at 04:55:39PM -0700, Guenter Roeck wrote:
> > On 3/26/26 10:45, Conor Dooley wrote:
> > > On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> > > > On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > > > > On 3/25/26 11:20, Conor Dooley wrote:
> > > > > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > > > > Use fallback compatibles for compatible chips and add optional
> > > > > > > interrupts and vdd-supply properties.
> > > > > > >
> > > > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > > > > >
> > > > > > The robot did not report that this binding was missing.
> > > > > > It also told you not to add these tags.
> > > > > >
> > > > > > You also ignored my and Krzysztof's reviews.
> > > > > >
> > > > > > NAK.
> > > > > >
> > > > >
> > > > > Maybe we should just point to AI feedback:
> > > > >
> > > > > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> > > > >
> > > > > and only get involved after AI does not report any problems.
> > > > >
> > > >
> > > > The presentation of info in that is weird, it creates a pseudo-commit
> > > > message, and then goes on to talk about things that the pseudo-commit
> > > > message has had culled.
> > >
> > > How good is this LLM stuff at figuring out if previous review feedback
> > > has been resolved? Or is it not capable of looking at earlier revisions?
> >
> >
> > Both are interesting questions. For the first one, I had noticed that, but
> > to me it seemed that the pseudo-commit message is an attempt to create a concise
> > version of the commit message, and I have not seen evidence that the later
> > comments did not also apply to the real commit message.
>
> Yeah, the comments did apply to the real commit message. I was just
> confusing to me to see what looked to me like a commit message not
> contain the info that was being referred to later on. I thought that the
> LLM was hallucinating the comments until I went back to this mail and
> realised the text was here.
>
> >
> > Anyway, copying Roman for feedback on both.
> >
> > Thanks,
> > Guenter
> >