From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D13173CA488 for ; Wed, 25 Mar 2026 11:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436955; cv=none; b=GPWvEmKqTISXpHEPEB8gYUUzxD5bNapJGdGoc6U/YR+BU0iKqk15K53QR86Bak/lH0mxgqo5N5pTI3vGovbcwuktHJlUro2bTC9VlZDgLNjyYx/pn/l5ons9rWZGhdrMyZFABjlG/N7zqx09QPP+ceLSy05NPFoydaag9MoO3Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774436955; c=relaxed/simple; bh=b8dYo16XmJ2xon8GV97URYfm4xZzwK4rrsPqdHa33Kk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=lK8hde0hvgRCsclAZRdXRjCbN2NZLx8mnicnZ/Wmtu+kzyd6N47JZyftboxvi8wEGy6zEMaq3wXa9Th5cZfJcLyAYNMLd6kpGGQeYHtGwiZbcRIjRisyuGUamuDcaGS7iHc7ouedUns1nWiu3ITl5AXUQfZy7+6a9AUpdC5QZaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TiMEGExk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iWGegbea; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TiMEGExk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iWGegbea" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PAQSJ22884698 for ; Wed, 25 Mar 2026 11:09:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=0xsjrEryjWzRb9dOuIF+d8 yzYCspWSHX+0TlzKhGxRo=; b=TiMEGExkVM9gpL8cmTL1Y1MM+EHGdJ2UifJ7G9 +3eMUGbdKh5bKay+aRyF7hZyOgk2/v+Ic8E2ObTbeV+5jRc5ljbjfAM366mDRq8Q p/c6wKlT8DwRmmdjtytX4aZYLV7FsCQbrWiFiGIpvpHTlh5XQb3KFsSTaCfYpqqM 1rCSphJtlm6zmKIuCrM6PhQAdSYH04ZNY7qyz3M6fxBj7kufweRkpHTvNuLf3B1e yNKDTM6ys0BdHBaZOEU0o7H9qmFXjVMSR5+KcOCSliemYOsSFSJRINAtb+096EuP x2tFAR5Nr6nKw8fI7XAcvpCn1JBCNK7ldq+j0SS2gOpp6XTw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d4dy4g51g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 11:09:11 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82c245a88a5so717667b3a.1 for ; Wed, 25 Mar 2026 04:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774436951; x=1775041751; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=0xsjrEryjWzRb9dOuIF+d8yzYCspWSHX+0TlzKhGxRo=; b=iWGegbeaT2N5IbcZwrZhtLMCZlGYGkchSAA+ixsXXyZnY4azN4np8Gnom5KyiCQ+Wq NbJMG5zpAeFUFy+lJlZ3I/lojlMUbeMcCvBoMK9Bd2AdlMzHW151kmQQNWByQos1CQ7H SIIuKLcXn9472dnVcl+dzswHAFydK2H7IhUhV3Bsc1mnhuKTtlR//FUfWZxxbGdNflcD k/G7F7prkFE9IDFqm3KtVhN8yPzYNx6IPWNHjfn0fulQ9KxwBWAhf+GwU6/Dyq+t42o5 ErV8fCEcTA119eJnM9b0aGNHmnLqL2DbEmvBUqeQv2NAm6xhxrFucSUZcq00DkonyIYe WIKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774436951; x=1775041751; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0xsjrEryjWzRb9dOuIF+d8yzYCspWSHX+0TlzKhGxRo=; b=MAcC5uM43ngAbef7QBsaCwx3h/4Ki+/hl4/6fjgDhCWIo144DzQhHa3tXpVJ0vsZQh mzlCB/Y0MUbE0Be3rYlx102n7rlQvqdd4hG20qYpF8/lr/pLNAp36nwyh3qhe+alNiXm rDYEkrRgZ/ec3s/phqx54Iu9bL6WleqRml1HYHa4UOh04sbeAq5kC0TMbWxaLsJGMVEr a5a5Kkt09Vq8Ky3GR7/MGPq5fanGkYbY79LJ7u4dYEnD+9qfOkImf7US4WrfSxj93b0u 7cEPQgP8vD59u78S5SNcnf63xG/Wp+RfH4Q8tJFG1YizdeIdymR2J6LcGa3gV+IAVlTq +umg== X-Forwarded-Encrypted: i=1; AJvYcCUU0mlaXKsWe4ImsRR4AkTbc4K/kR4XAZxrjlJ3ka14aSQaOf3WcpQViVmV5/RlvlvHCZURz/+wSug0@vger.kernel.org X-Gm-Message-State: AOJu0YxwjQlNh7WqmYSC62gbWEk8VljS5guGisHE5PHIFyB2Cg1VoKab udY2tIXfDwPruJQHzCY/fVuj3aP3iYyeeb2JZ8Inbtu+QJCfg+pTwGh0yrW1+ohk29ilYrzhi/t G2KSYPU2EXJAes8O4b62CB8eHKV1T97Xk5FuYnTEDU1fCUKrP23paAkRTGCuTb1eK X-Gm-Gg: ATEYQzy2WDugamHfYl+/sQhS1PB18L4IxTJjRCFUfD1x4TD7NPWIYJV9Sjy4FujcfPH n3NLE132Ft6kNlaUtbBXFX57i8BdUTWbTaELAYFZZROkq3kqPjBZ3a8fcAtQnoTgtPCFjghkVa5 6rwpwdkC1rCE5vT687tAIN+4Jzst2WCjIt6vuXfBnu6LiefrhMjfXhOWyD9oQYLThJVYiQcojoZ s45IugdvQ50rlLWi/0LBKk/dkoTtxqiN7D6mCwPbq6BYJ/wy9Jd/WMkR94qWGYm3ezbUKAZ5dwD n3B6nRGLSUllCqTOAGlcj0Wk1Wem5mnF8rnNZACHJfTB0yBj4itcff5jGI4H7y0KBm5OlnDrFfe Ht27TgDzYKRTIlHd2nvGrnQ7X4QOtwko80jfNUUi6L6LOc119g4y3lfRy X-Received: by 2002:a05:6a00:1787:b0:827:2ee7:baaf with SMTP id d2e1a72fcca58-82c6d88a70emr3157413b3a.12.1774436950328; Wed, 25 Mar 2026 04:09:10 -0700 (PDT) X-Received: by 2002:a05:6a00:1787:b0:827:2ee7:baaf with SMTP id d2e1a72fcca58-82c6d88a70emr3157358b3a.12.1774436949724; Wed, 25 Mar 2026 04:09:09 -0700 (PDT) Received: from hu-vjitta-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040da7besm14615911b3a.49.2026.03.25.04.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 04:09:09 -0700 (PDT) From: Vijayanand Jitta Subject: [PATCH v11 0/3] of: parsing of multi #{iommu,msi}-cells in maps Date: Wed, 25 Mar 2026 16:38:21 +0530 Message-Id: <20260325-parse_iommu_cells-v11-0-1fefa5c0e82c@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACXCw2kC/33NwQ6CMAwG4FchOzuygiB48j2MIaUUWYIMN1k0h Hd3cPJAvDT5/7RfZ+HYanbiHM3CstdOmyEEgEMkqMPhzlI3oRCJSnKVKpAjWseVNo/HVBH3vZN AaXrKC+S6RhHuRsutfm/o9RZyp93L2M/2w5dr+0/zpVTy2EBNzEQZw8U4Fz8n7ClsxWGIFfWgf qVyTwIVKMqTlhAzhKbYoZZl+QLpzPWgBQEAAA== To: Nipun Gupta , Nikhil Agarwal , Joerg Roedel , Will Deacon , Robin Murphy , Marc Zyngier , Lorenzo Pieralisi , Thomas Gleixner , Saravana Kannan , Richard Zhu , Lucas Stach , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dmitry Baryshkov , Konrad Dybcio , Bjorn Andersson , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Prakash Gupta , Vikash Garodia Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, xen-devel@lists.xenproject.org, linux-arm-msm@vger.kernel.org, Vijayanand Jitta , Charan Teja Kalla X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774436938; l=5530; i=vijayanand.jitta@oss.qualcomm.com; s=20260301; h=from:subject:message-id; bh=b8dYo16XmJ2xon8GV97URYfm4xZzwK4rrsPqdHa33Kk=; b=J08zhEYoQn9e6bd4Kdzzm/0wjHfQUzVEJmTADcUj7e0wpazI3gC2Wl0RNNsNRBF8E/PVwFYJS bUPHaafLLEtCBMQtzU4gcpBawAiyPFytdIVdxsjxMVtFcpymsXi/9KL X-Developer-Key: i=vijayanand.jitta@oss.qualcomm.com; a=ed25519; pk=Lpi7Cs3wHe8KZtqvyci7FTOLzsKpEHKGCaPNZw+1zRI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA3OSBTYWx0ZWRfX5OMtQkWMXeYN dKtq+rK6XPRsnWWPz5PHAo+FHE0Q/+5OSYjQQ5MYvU1wwUEXwrRtotSM9f7N/ef0Ra89AUIH+E9 6N5OgP0v4CpbuN1lbVOF+vmBqM3uietGZTp+UOHeHiccMU3SJWtWk55k9lH7rbodhlsGs9kmIX3 HUqS8jH8U2te0rXMypquniJzj6LzDghL/JlpZsRepV478FucH1o0KWXNlaO14dKMEBqw38c/RDY 4/NbS3vAIBmRT5XUIJ77mGUu9NJT9QF0cCb+Z1FXjk9OKodJXSbCVazQAyeaRS8hVmQBJe35Mwb vZzcMe0DA1Sogatn9E2Xi1gDZl6fKc704cBW2TtjwjCf384wDKq2riCWQ2+6UPqw8++AzhVHTpO Qe6ga8E3CDk5jB8WqrDG08Xq5DnlnFxUyibm9oIe5y3npxQGlTshDufHaimGUo3ou8Nk5eGYfU7 v5tuAXG5cgbUJ/q3KLw== X-Proofpoint-ORIG-GUID: ZONGAqqhqgRddDGAqVvcmHDDuPAokOsO X-Proofpoint-GUID: ZONGAqqhqgRddDGAqVvcmHDDuPAokOsO X-Authority-Analysis: v=2.4 cv=eeUwvrEH c=1 sm=1 tr=0 ts=69c3c257 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=w9jVfKxUgDq0yQD5sDkA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250079 So far our parsing of {iommu,msi}-map properties has always blindly assumed that the output specifiers will always have exactly 1 cell. This typically does happen to be the case, but is not actually enforced (and the PCI msi-map binding even explicitly states support for 0 or 1 cells) - as a result we've now ended up with dodgy DTs out in the field which depend on this behaviour to map a 1-cell specifier for a 2-cell provider, despite that being bogus per the bindings themselves. Since there is some potential use[1] in being able to map at least single input IDs to multi-cell output specifiers (and properly support 0-cell outputs as well), add support for properly parsing and using the target nodes' #cells values, albeit with the unfortunate complication of still having to work around expectations of the old behaviour too. -- Robin. Unlike single #{}-cell, it is complex to establish a linear relation between input 'id' and output specifier for multi-cell properties, thus it is always expected that len never going to be > 1. These changes have been tested on QEMU for the arm64 architecture. Since, this would also need update in dt-schema, raised PR[2] for the same. [1] https://lore.kernel.org/all/20250627-video_cb-v3-0-51e18c0ffbce@quicinc.com/ [2] PR for iommu-map dtschema: https://github.com/devicetree-org/dt-schema/pull/184 V11: - Added explicit filter_np parameter to of_map_id() and of_map_msi_id() per Dmitry Baryshkov's review feedback, making the filter explicit instead of overloading arg->np as both input filter and output parameter. - Removed of_node_put() from inside of_map_id(), making the caller responsible for reference management. Updated of_msi_xlate() to properly handle reference counting. - Collected ACKed by tags, and fixed minor typos. Link to v10: https://lore.kernel.org/r/20260309-parse_iommu_cells-v10-0-c62fcaa5a1d8@oss.qualcomm.com V10: - Move of_map_iommu_id()/of_map_msi_id() from include/linux/of.h to drivers/of/base.c as out-of-line helpers per feedback from Marc Zyngier and Rob Herring. - Add kernel-doc to document both helpers for discoverability and usage clarity. - Fix of_map_msi_id() wrapper and all its callers (cdx_msi.c, irq-gic-its-msi-parent.c, drivers/of/irq.c) to correctly use the new struct of_phandle_args-based API with proper of_node_put() handling as per feeback from Dmitry. Link to v9: https://lore.kernel.org/r/20260301-parse_iommu_cells-v9-0-4d1bceecc5e1@oss.qualcomm.com V9: - Updated TO/CC list based on feedback to include all relevant maintainers. - No functional changes to the patches themselves. Link to V8: https://lore.kernel.org/all/20260226074245.3098486-1-vijayanand.jitta@oss.qualcomm.com/ V8: - Removed mentions of of_map_args from commit message to match code. Link to V7: https://lore.kernel.org/all/20260210101157.2145113-1-vijayanand.jitta@oss.qualcomm.com/ V7: - Removed of_map_id_args structure and replaced it with of_phandle_args as suggested by Dmitry. Link to V6: https://lore.kernel.org/all/20260121055400.937856-1-vijayanand.jitta@oss.qualcomm.com/ V6: - Fixed build error reported by kernel test bot. Link to V5: https://lore.kernel.org/all/20260118181125.1436036-1-vijayanand.jitta@oss.qualcomm.com/ V5: - Fixed Build Warnings. - Raised PR for iommu-map dtschema: https://github.com/devicetree-org/dt-schema/pull/184 Link to V4: https://lore.kernel.org/all/20251231114257.2382820-1-vijayanand.jitta@oss.qualcomm.com/ V4: - Added Reviewed-by tag. - Resolved warnings reported by kernel test bot, minor code reorganization. Link to V3: https://lore.kernel.org/all/20251221213602.2413124-1-vijayanand.jitta@oss.qualcomm.com/ V3: - Added Reviewed-by tag. - Updated of_map_id_args struct as a wrapper to of_phandle_args and added comment description as suggested by Rob Herring. Link to V2: https://lore.kernel.org/all/20251204095530.8627-1-vijayanand.jitta@oss.qualcomm.com/ V2: - Incorporated the patches from Robin that does the clean implementation. - Dropped the patches the were adding multi-map support from this series as suggested. V1: https://lore.kernel.org/all/cover.1762235099.git.charan.kalla@oss.qualcomm.com/ RFC: https://lore.kernel.org/all/20250928171718.436440-1-charan.kalla@oss.qualcomm.com/#r Signed-off-by: Vijayanand Jitta --- --- Charan Teja Kalla (1): of: Factor arguments passed to of_map_id() into a struct Robin Murphy (2): of: Add convenience wrappers for of_map_id() of: Respect #{iommu,msi}-cells in maps drivers/cdx/cdx_msi.c | 8 +- drivers/iommu/of_iommu.c | 6 +- drivers/irqchip/irq-gic-its-msi-parent.c | 11 +- drivers/of/base.c | 213 ++++++++++++++++++++++++------- drivers/of/irq.c | 11 +- drivers/pci/controller/dwc/pci-imx6.c | 18 ++- drivers/pci/controller/pcie-apple.c | 6 +- drivers/xen/grant-dma-ops.c | 5 +- include/linux/of.h | 30 ++++- 9 files changed, 237 insertions(+), 71 deletions(-) --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260301-parse_iommu_cells-1c33768aebba Best regards, -- Vijayanand Jitta