public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
	Rodrigo Alencar via B4 Relay
	<devnull+rodrigo.alencar.analog.com@kernel.org>,
	rodrigo.alencar@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	David Lechner <dlechner@baylibre.com>,
	Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support
Date: Wed, 25 Mar 2026 19:19:53 +0000	[thread overview]
Message-ID: <20260325191953.290a204f@jic23-huawei> (raw)
In-Reply-To: <20260325-possibly-deploy-3ff69076a6e9@spud>

On Wed, 25 Mar 2026 18:13:45 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Wed, Mar 25, 2026 at 12:46:27PM +0000, Jonathan Cameron wrote:
> > On Wed, 25 Mar 2026 11:12:02 +0000
> > Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> >   
> > > From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > 
> > > Add compatible entries for ADRF5702 and ADRF5703 Digital Attenuators.  
> > 
> > Explain how they are different from the existing supported devices.
> > 
> > Something simple like the "Each device has its own gain range and step,
> > hence no fallback compatibles are used." that you had in the original patch
> > is what we need here.  
> 
> Which means that this is a v2 that doesn't say it is a v2, or explain
> what has changed?

I meant the original driver - which only landed recently and answered
the question of difference nicely.

This is adding more parts to that - but I believe is a v1.

J
> 
> >   
> > > 
> > > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > > index 2719de1166a1..065637ce33a5 100644
> > > --- a/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ad8366.yaml
> > > @@ -20,6 +20,8 @@ properties:
> > >        - adi,ad8366
> > >        - adi,ada4961
> > >        - adi,adl5240
> > > +      - adi,adrf5702
> > > +      - adi,adrf5703
> > >        - adi,adrf5720
> > >        - adi,adrf5730
> > >        - adi,adrf5731
> > > @@ -66,6 +68,8 @@ allOf:
> > >                anyOf:
> > >                  - const: adi,ad8366
> > >                  - const: adi,ada4961
> > > +                - const: adi,adrf5702
> > > +                - const: adi,adrf5703
> > >                  - const: adi,adrf5720
> > >                  - const: adi,adrf5730
> > >                  - const: adi,adrf5731
> > >   
> >   
> 
> pw-bot: changes-requested


  reply	other threads:[~2026-03-25 19:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 11:12 [PATCH 0/2] ADRF5702/ADRF5703 Digital Attenuator support Rodrigo Alencar via B4 Relay
2026-03-25 11:12 ` [PATCH 1/2] dt-bindings: iio: amplifiers: ad8366: add adrf5702/3 support Rodrigo Alencar via B4 Relay
2026-03-25 12:46   ` Jonathan Cameron
2026-03-25 18:13     ` Conor Dooley
2026-03-25 19:19       ` Jonathan Cameron [this message]
2026-03-26 17:46         ` Conor Dooley
2026-03-25 11:12 ` [PATCH 2/2] iio: amplifiers: ad8366: add support for adrf5702/3 Rodrigo Alencar via B4 Relay
2026-03-25 12:28 ` [PATCH 0/2] ADRF5702/ADRF5703 Digital Attenuator support Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325191953.290a204f@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+rodrigo.alencar.analog.com@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rodrigo.alencar@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox