From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EACED3B38AE; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; cv=none; b=R9Xs8N9ls8+9I8fYhlA9LA9ajwMjiaBve2EEMUraNly5HATZjSUviUdvFUzhDbinDYB0d0IL5w9fZhshWNVZf0WxhKH1uvgSn1/hbcHB91C++rTSn/LvXF05OqXcx11SKqecDPyLdKBsH+3HxuWOu4cmkLUlIb24GUqqkw8Jiw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; c=relaxed/simple; bh=RlIM0MUSwd5wz+8XPIpqDDZrKwpihhE+hECNmip7gPI=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Dt5SpCQnlJfj7gy6Mbc0kwv4lBVote4LX6Ih9I8jk69/Hz6nMw73JE48nQ60PrFUUDs4cMlG7YFhbR6L68kGMkxovqDPxPo4oP7l/RhB1sO2ouRap/AnKcwZ0zRoLC9gmcAF2by2P/TfZYdL6MBXuyYIXvmhAmoo8fGVYZ1A8ig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P7SHwOxr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7SHwOxr" Received: by smtp.kernel.org (Postfix) with ESMTPS id BF323C116C6; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774511852; bh=RlIM0MUSwd5wz+8XPIpqDDZrKwpihhE+hECNmip7gPI=; h=From:Subject:Date:To:Cc:Reply-To:From; b=P7SHwOxrRy2qbwV51TFmQT47oevjRaSaRZ38/VBFqLvc7EPEo9xyJG1Uzv2oPKxCD EvWHN4w+D1AzpZwmVUlnmqBmrfjgcaCYibN51ut/VKN8pkMaZtB8h27ftrbExy57Q0 YorJF3eI3cznHWKdRco6+7f+nKQyLJvFY/vBLhiB6iLtf8Z3/njf+jZnM0kkJIYAN1 zVwBDRKDPmUkernKsiKGukyXbN/5nSZ45eWxUeH1U/WiL/vNFxW22h6enGxS9QR/1w 0MxSW1hr9yA2HvXcoyxJGYDDhrvURQMqR6sGlCW++S3R+7GhOT3gdJb6H2ZKOwq8c9 4ZjKInI6rJFUg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFCA106F2E9; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Subject: [PATCH v3 0/3] Samsung Expressatt: Camera Flash Date: Thu, 26 Mar 2026 00:57:30 -0700 Message-Id: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAOrmxGkC/4WPy2rDMBBFf8VoXQU9bLkypeQ/Sgmjh2PRKG4kR SQE/3tlZVFvSpnVHWbO4T5QtMHZiIbmgYLNLrr5XAJ/aZCe4Hy02JmSESNMEE4EtrfvYGOElA4 avA1wGE8QJ0y5ph30LesBUPkuV6O7VfLH5zMHe7kWQXoukV8xVTA0b4XfUUa6DR+n+aqnL3vHm eIybdsqyXotR74/enCnnZ79++pSEC0uwbs0NFnsqESrcnIxzeFeu2Vanf/WKCqCFZVSjL02ozG /qsrMbMOhr39zWOF0mikJgnGj1ZazLMsPaB6EDXkBAAA= X-Change-ID: 20260306-expressatt_camera_flash-13c15a7427aa To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Conor Dooley , David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774511852; l=3372; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=RlIM0MUSwd5wz+8XPIpqDDZrKwpihhE+hECNmip7gPI=; b=zbdwGQMdwTftPx42S7rTi4MPfe2+CYew1vD4HdwzXJiO6y16XrYpftcKvYRpJEiv2dkXaxRO/ rmGccPAbWtyBFvtr0rcTlEfdCkM1b1pNLzUAfaFIqGyJmtq2wNaznid X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com This small series adds camera flash to an existing similar mainline driver and adds it to the Samsung Expressatt's DTS // Tests // # Navigate to LED sudo su cd /sys/class/leds/white:flash // # Should stay at dim brightness echo 1 > brightness echo 1 > brightness echo 1 > brightness echo 1 > brightness echo 0 > brightness # LED_OFF // # Max Brightness echo 50 > brightness echo 0 > brightness # LED_OFF echo 99 > brightness echo 0 > brightness # LED_OFF echo 1000 > brightness echo 0 > brightness # LED_OFF echo 100 > brightness echo 0 > brightness # LED_OFF // # Should increase in brightness for i in $(seq 1 16); do echo $i > brightness; sleep 1; done echo 0 > brightness # LED_OFF // # Test flash strobe (rt8515_led_flash_strobe_set) cat max_flash_timeout # check max echo 200000 > flash_timeout # 200ms echo 1 > flash_strobe # strobe ON → brightness_commit + timer cat flash_strobe # should read 1, then 0 after timeout sleep 1 cat flash_strobe # should be 0 (timer fired) // # Test manual strobe cancel echo 1 > flash_strobe ; echo 0 > flash_strobe # immediate off // # Check regulator error handling dmesg | tail -20 # look for any "failed to turn off LED" msgs Downstream reference: Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/drivers/leds/Makefile#L51 Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 Signed-off-by: Rudraksha Gupta --- Changes in v3: - DTS: - Renamed and reordered nodes - Driver: - Use regulator_is_enabled() instead of reg_enabled - remove ent xor vin check - remove rt->reg == -ENODEV check - rename functions to reflect what they do and added ret's - Fixed: LED was increasing in brightness when setting the same brightness multiple times - Link to v2: https://lore.kernel.org/r/20260318-expressatt_camera_flash-v2-0-5c2b9a623dcb@gmail.com Changes in v2: - dt-bindings: Explain the hardware and not the driver - **/*: Use vin-supply instead of unlock-gpio - expressatt DTS: Reorder pinctrl-* - expressatt DTS: Define rfs-ohms to a default (couldn't find information about this) - Link to v1: https://lore.kernel.org/r/20260306-expressatt_camera_flash-v1-0-b1996f7cdfdd@gmail.com --- Rudraksha Gupta (3): dt-bindings: leds: rt8515: Support single-GPIO flash ICs with vin supply leds: flash: rt8515: Support single-GPIO flash ICs with vin supply ARM: dts: qcom: msm8960: expressatt: Add camera flash .../devicetree/bindings/leds/richtek,rt8515.yaml | 34 +++++++- .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 43 +++++++++++ drivers/leds/flash/leds-rt8515.c | 90 +++++++++++++++++----- 3 files changed, 148 insertions(+), 19 deletions(-) --- base-commit: e9ec05addd1a067fc7cb218f20ecdc1b1b0898c0 change-id: 20260306-expressatt_camera_flash-13c15a7427aa prerequisite-message-id: <20251205-expressatt-touchkey-v1-1-1444b927c9f3@gmail.com> prerequisite-patch-id: 8de4de7909722ccaf385c4224f25a623eaa72c28 Best regards, -- Rudraksha Gupta