From: Conor Dooley <conor@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Zaixiang Xu <zaixiang.xu.dev@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series
Date: Thu, 26 Mar 2026 17:45:33 +0000 [thread overview]
Message-ID: <20260326-opposing-footsie-33a0deb2ba90@spud> (raw)
In-Reply-To: <20260326-lullaby-elevator-3a3d25e9a6c0@spud>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
On Thu, Mar 26, 2026 at 05:42:30PM +0000, Conor Dooley wrote:
> On Wed, Mar 25, 2026 at 06:05:22PM -0700, Guenter Roeck wrote:
> > On 3/25/26 11:20, Conor Dooley wrote:
> > > On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > > > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > > > Use fallback compatibles for compatible chips and add optional
> > > > interrupts and vdd-supply properties.
> > > >
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@intel.com/
> > >
> > > The robot did not report that this binding was missing.
> > > It also told you not to add these tags.
> > >
> > > You also ignored my and Krzysztof's reviews.
> > >
> > > NAK.
> > >
> >
> > Maybe we should just point to AI feedback:
> >
> > https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com
> >
> > and only get involved after AI does not report any problems.
> >
>
> The presentation of info in that is weird, it creates a pseudo-commit
> message, and then goes on to talk about things that the pseudo-commit
> message has had culled.
How good is this LLM stuff at figuring out if previous review feedback
has been resolved? Or is it not capable of looking at earlier revisions?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-26 17:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 9:08 [PATCH v4 0/4] hwmon: (sht3x) Add support for GXCAS GXHT30 Zaixiang Xu
2026-03-25 9:08 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add GXCAS Technology Zaixiang Xu
2026-03-25 9:08 ` [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series Zaixiang Xu
2026-03-25 18:20 ` Conor Dooley
2026-03-26 1:05 ` Guenter Roeck
2026-03-26 17:42 ` Conor Dooley
2026-03-26 17:45 ` Conor Dooley [this message]
2026-03-26 23:55 ` Guenter Roeck
2026-03-27 0:03 ` Conor Dooley
2026-03-27 0:46 ` Roman Gushchin
2026-03-25 9:08 ` [PATCH v4 3/4] hwmon: (sht3x) Add devicetree support Zaixiang Xu
2026-03-25 9:08 ` [PATCH v4 4/4] hwmon: (sht3x) Add support for GXCAS GXHT30 Zaixiang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326-opposing-footsie-33a0deb2ba90@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=zaixiang.xu.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox