From: Jonathan Cameron <jic23@kernel.org>
To: "Jones, Carlos jr" <Carlosjr.Jones@analog.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
David Lechner <dlechner@baylibre.com>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Liam Beguin <liambeguin@gmail.com>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
Andy Shevchenko <andy@kernel.org>,
Tobias Sperling <tobias.sperling@softing.com>,
"Marques, Jorge" <Jorge.Marques@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kyle Hsieh <kylehsieh1995@gmail.com>
Subject: Re: [PATCH v2 0/4] Add support for LTC2305
Date: Thu, 26 Mar 2026 08:17:08 +0000 [thread overview]
Message-ID: <20260326081708.05b50999@jic23-huawei> (raw)
In-Reply-To: <SJ0PR03MB5854559AD0D2624A6251ED6FF456A@SJ0PR03MB5854.namprd03.prod.outlook.com>
On Thu, 26 Mar 2026 02:21:28 +0000
"Jones, Carlos jr" <Carlosjr.Jones@analog.com> wrote:
> > On Tue, 24 Mar 2026 15:13:27 +0800
> > Carlos Jones Jr <carlosjr.jones@analog.com> wrote:
> >
> > > The LTC2305 is a 2-channel, 12-bit, fast ADC with an I2C interface,
> > > compatible with the LTC2309 (which has 8 channels).
> > >
> > > This patch adds support for the LTC2305 by introducing a chip_info
> > > structure to handle the different channel configurations between the
> > > two variants. The LTC2305 exposes 2 single-ended channels and 2
> > > differential combinations.
> > >
> > > Also updates the device tree bindings to include the lltc,ltc2305
> > > compatible string and documents it in the Kconfig.
> > > ---
> >
> > Whilst checking for what comments were in v1, I realized we have two
> > different people looking at the same thing within a few weeks of each other.
> > +cc Kyle.
> >
> > https://urldefense.com/v3/__https://lore.kernel.org/all/20260325-
> > add_ltc2305_driver-v5-0-
> > e0d29daa54f9@gmail.com/*r__;Iw!!A3Ni8CS0y2Y!6jxk_dJQLHUO4PVi3Oca_
> > VzVHN-qeFu-y2tE5xXMwuy-
> > x2UFG5Fn3KO4Cw15QcDsqTCgFXQQLLRQrdgokg$
> >
> > I guess this is just a case of neither noticing on the list?
> > Too many similar part names, so I missed it until now.
> >
> > Currently I have Kyle's patches queued up. All else being equal that seems fair
> > as Kyle started on this last year whereas Carlos' work on this is much more
> > recent.
> >
> > I'm seeing some small differences. Please could you work together on this.
> > Ideally send any additional changes on top of Kyle's series.
> >
> > Thanks,
> >
> > Jonathan
> >
>
> First off, my apologies to everyone for not knowing how to check for
> existing upstream request for the LTC2305 device before working on it
> and wasting everyone's review time. It's a learning experience for me.
It is pretty rare! Only tend to see this sort of collision once every
few years.
>
> But it's still awesome to see how both ended up with almost the same
> code after review.
>
> I'll reply to Kyle's series to ask if the delay for LTC2305 could be included.
Excellent! Note I've merged Kyle's code, so patches on top please.
Potentially the delay might be a fix if I understand it correctly.
Thanks,
Jonathan
>
> Kind regards,
> Carlos
>
prev parent reply other threads:[~2026-03-26 8:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 7:13 [PATCH v2 0/4] Add support for LTC2305 Carlos Jones Jr
2026-03-24 7:13 ` [PATCH v2 1/4] iio: adc: ltc2309: Introduce chip_info structure Carlos Jones Jr
2026-03-24 12:24 ` Andy Shevchenko
2026-03-25 0:01 ` Jones, Carlos jr
2026-03-24 7:13 ` [PATCH v2 2/4] iio: adc: ltc2309: Use i2c_get_match_data() helper Carlos Jones Jr
2026-03-24 12:35 ` Andy Shevchenko
2026-03-24 7:13 ` [PATCH v2 3/4] dt-bindings: iio: adc: ltc2497: Add LTC2305 compatible Carlos Jones Jr
2026-03-24 12:36 ` Krzysztof Kozlowski
2026-03-24 7:13 ` [PATCH v2 4/4] iio: adc: ltc2309: Add LTC2305 support Carlos Jones Jr
2026-03-24 12:39 ` Andy Shevchenko
2026-03-25 20:19 ` [PATCH v2 0/4] Add support for LTC2305 Jonathan Cameron
2026-03-26 2:21 ` Jones, Carlos jr
2026-03-26 8:17 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326081708.05b50999@jic23-huawei \
--to=jic23@kernel.org \
--cc=Carlosjr.Jones@analog.com \
--cc=Jorge.Marques@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=kylehsieh1995@gmail.com \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox