From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Siratul Islam <email@sirat.me>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
Date: Thu, 26 Mar 2026 08:21:42 +0000 [thread overview]
Message-ID: <20260326082142.5d0bdfba@jic23-huawei> (raw)
In-Reply-To: <20260326-noisy-successful-petrel-ba85ec@quoll>
On Thu, 26 Mar 2026 08:38:59 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Mar 26, 2026 at 02:19:41AM +0600, Siratul Islam wrote:
> > vdd-supply: true
> >
> > @@ -28,6 +33,18 @@ required:
> > - compatible
> > - reg
> >
> > +# vdd-supply is not made globally required to maintain backwards compatibility
> > +# with existing st,vl53l0x devicetrees that do not specify it.
>
> Commit should rather explain that, not code.
That was my suggestion. I'm not that tied to it though so moved to the commit message.
>
> Anyway, regardless:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Thanks,
J
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-03-26 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 20:19 [PATCH v8 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor Siratul Islam
2026-03-25 20:19 ` [PATCH v8 1/2] dt-bindings: iio: proximity: add " Siratul Islam
2026-03-26 7:38 ` Krzysztof Kozlowski
2026-03-26 8:21 ` Jonathan Cameron [this message]
2026-03-25 20:19 ` [PATCH v8 2/2] iio: proximity: add driver for " Siratul Islam
2026-03-26 10:14 ` Andy Shevchenko
2026-03-26 12:20 ` Sirat
2026-03-26 8:24 ` [PATCH v8 0/2] " Jonathan Cameron
2026-03-26 12:24 ` Sirat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326082142.5d0bdfba@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox