public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/8] regulator: pbias: Add pbias SIM regulator for OMAP4
Date: Fri, 27 Mar 2026 13:36:12 +0100	[thread overview]
Message-ID: <20260327133612.6ee909fd@kemnade.info> (raw)
In-Reply-To: <20260323-omap4-fix-usb-support-v1-1-b668132124ac@bootlin.com>

On Mon, 23 Mar 2026 16:02:42 +0100
Thomas Richard <thomas.richard@bootlin.com> wrote:

> Add support for the pbias SIM regulator found on OMAP4 (for USB I/O cell).
> 
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
>  drivers/regulator/pbias-regulator.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/regulator/pbias-regulator.c b/drivers/regulator/pbias-regulator.c
> index cd5a0d7e44555f04d1e44470036c6e3d9feb7be6..10c4940e73635293bebd26bf99a9067eb6e39107 100644
> --- a/drivers/regulator/pbias-regulator.c
> +++ b/drivers/regulator/pbias-regulator.c
> @@ -81,6 +81,16 @@ static const struct pbias_reg_info pbias_sim_omap3 = {
>  	.name = "pbias_sim_omap3"
>  };
>  
> +static const struct pbias_reg_info pbias_sim_omap4 = {
> +	.enable = BIT(28) |  BIT(20),
> +	.enable_mask = BIT(31) | BIT(28) | BIT(20),
> +	.vmode = BIT(31),

BIT(27)? or am I mixing something up?

Regards,
Andreas

  parent reply	other threads:[~2026-03-27 12:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 15:02 [PATCH 0/8] Add SIM pbias regulator support for USB on OMAP4 Thomas Richard
2026-03-23 15:02 ` [PATCH 1/8] regulator: pbias: Add pbias SIM regulator for OMAP4 Thomas Richard
2026-03-23 17:29   ` Mark Brown
2026-03-27 12:36   ` Andreas Kemnade [this message]
2026-03-27 13:18     ` Thomas Richard
2026-03-23 15:02 ` [PATCH 2/8] ARM: dts: ti: omap4: Add pbias SIM regulator Thomas Richard
2026-03-23 15:02 ` [PATCH 3/8] mfd: omap-usb-host: Cleanup header includes Thomas Richard
2026-03-31 15:45   ` Lee Jones
2026-03-23 15:02 ` [PATCH 4/8] mfd: omap-usb-host: Sanitize error path in the probe() Thomas Richard
2026-03-23 15:02 ` [PATCH 5/8] dt-bindings: mfd: ti,omap-usb-host: Convert to DT schema Thomas Richard
2026-03-23 19:55   ` Conor Dooley
2026-03-23 15:02 ` [PATCH 6/8] dt-bindings: mfd: ti,omap-usb-host: Add 'pbias-supply' property Thomas Richard
2026-03-23 15:02 ` [PATCH 7/8] mfd: omap-usb-host: Add pbias regulator support Thomas Richard
2026-03-31 16:55   ` Lee Jones
2026-03-31 18:19     ` Thomas Richard
2026-03-23 15:02 ` [PATCH 8/8] ARM: dts: ti: omap4: Add pbias regulator to the HS USB Host Thomas Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327133612.6ee909fd@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas.richard@bootlin.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox