Re: [PATCH 1/1] dt-bindings: media: convert hix5hd2-ir to DT schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On Sat, Mar 28, 2026 at 02:12:38PM +0530, Pranav Kharche wrote:
> Convert the legacy plaintext binding for HiSilicon hix5hd2 IR remote
> controller to JSON Schema (DT schema) format in YAML.
> 
> This binding documents the infrared remote receiver found in HiSilicon
> SoCs such as hix5hd2 and hi3796cv300. The conversion includes:
> 
> - Standardized property definitions with types and constraints

Drop

> - Reference to rc.yaml base schema for remote controller properties

Drop

> - Addition of include directives for interrupt-controller bindings

Drop

> - Proper example with GIC interrupt specifiers

Drop

> - Schema validation support for device tree sources

Drop

> 
> The new schema enables:
> - Validation improvement

Drop

> 
> tested with: make dt_binding_check DT_SCHEMA_FILES=...
> All schema validation checks pass.

Drop

Please write useful commit msgs, meaning you do not need to state
obvious things. Plenty of examples in git log.

What you MUST say here is documenting the changes you done to the
binding. You removed existing property which is not explained at all,
introduces undocumented ABI and adds new warnings. No, seriously, no.

And if you TESTED this you would see errors, so back to basic
requirements of schema conversion - see my posts on social.kernel.org.


> 
> Signed-off-by: Pranav Kharche <pranavkharche7@gmail.com>
> ---
>  .../devicetree/bindings/media/hix5hd2-ir.txt  | 26 ---------
>  .../devicetree/bindings/media/hix5hd2-ir.yaml | 53 +++++++++++++++++++
>  2 files changed, 53 insertions(+), 26 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>  create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> deleted file mode 100644
> index ca4cf774662e..000000000000
> --- a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -Device-Tree bindings for hix5hd2 ir IP
> -
> -Required properties:
> -	- compatible: Should contain "hisilicon,hix5hd2-ir", or:
> -		- "hisilicon,hi3796cv300-ir" for Hi3796CV300 IR device.
> -	- reg: Base physical address of the controller and length of memory
> -	  mapped region.
> -	- interrupts: interrupt-specifier for the sole interrupt generated by
> -	  the device. The interrupt specifier format depends on the interrupt
> -	  controller parent.
> -	- clocks: clock phandle and specifier pair.
> -
> -Optional properties:
> -	- linux,rc-map-name: see rc.txt file in the same directory.
> -	- hisilicon,power-syscon: DEPRECATED. Don't use this in new dts files.
> -		Provide correct clocks instead.
> -
> -Example node:
> -
> -	ir: ir@f8001000 {
> -		compatible = "hisilicon,hix5hd2-ir";
> -		reg = <0xf8001000 0x1000>;
> -		interrupts = <0 47 4>;
> -		clocks = <&clock HIX5HD2_IR_CLOCK>;
> -		linux,rc-map-name = "rc-tivo";
> -	};
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml b/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
> new file mode 100644
> index 000000000000..91cba6ec88c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml

Filename must match the compatible, choose one.

> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/hix5hd2-ir.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon Hix5hd2 infrared remote controller
> +
> +maintainers:
> +  - Pranav Kharche <pranavkharche7@gmail.com>
> +
> +allOf:
> +  - $ref: rc.yaml#
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  This binding describes the infrared remote controller found in

So description describes that your binding describes... No, drop.
Explain the hardware and if you do not have any explanation, no need to
state obvious and paste here compatibles.

Best regards,
Krzysztof