* [PATCH 0/1] dt-bindings: media: convert hix5hd2-ir to DT schema
@ 2026-03-28 8:42 Pranav Kharche
2026-03-28 8:42 ` [PATCH 1/1] " Pranav Kharche
0 siblings, 1 reply; 3+ messages in thread
From: Pranav Kharche @ 2026-03-28 8:42 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Mauro Carvalho Chehab, linux-media, devicetree, Pranav Kharche
This patch converts the HiSilicon hix5hd2 IR remote controller binding from
legacy plaintext format to JSON Schema (DT schema) YAML format. This is part
of the GSoC 2026 Device Tree Bindings conversion project.
The conversion includes:
- Standardized property definitions with proper types and constraints
- Reference to rc.yaml for common IR remote controller properties
- Proper example device tree node with GIC interrupt specifiers
- Support for schema-based validation of device tree sources
Validation Results:
1. Binding schema check passed:
$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
✓ PASSED
2. DTB validation with actual IR node passed:
$ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CHECK_DTBS=y DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/hix5hd2-ir.yaml hisilicon/hi3798cv200-poplar.dtb
✓ PASSED
The binding correctly validates the IR controller found in hix5hd2 and
hi3796cv300 HiSilicon SoCs.
---
Note:
* This patch is part of the GSoC2026 application process for device tree bindings conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
Pranav Kharche (1):
dt-bindings: media: convert hix5hd2-ir to DT schema
.../devicetree/bindings/media/hix5hd2-ir.txt | 26 ---------
.../devicetree/bindings/media/hix5hd2-ir.yaml | 53 +++++++++++++++++++
2 files changed, 53 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] dt-bindings: media: convert hix5hd2-ir to DT schema
2026-03-28 8:42 [PATCH 0/1] dt-bindings: media: convert hix5hd2-ir to DT schema Pranav Kharche
@ 2026-03-28 8:42 ` Pranav Kharche
2026-03-29 9:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Pranav Kharche @ 2026-03-28 8:42 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Mauro Carvalho Chehab, linux-media, devicetree, Pranav Kharche
Convert the legacy plaintext binding for HiSilicon hix5hd2 IR remote
controller to JSON Schema (DT schema) format in YAML.
This binding documents the infrared remote receiver found in HiSilicon
SoCs such as hix5hd2 and hi3796cv300. The conversion includes:
- Standardized property definitions with types and constraints
- Reference to rc.yaml base schema for remote controller properties
- Addition of include directives for interrupt-controller bindings
- Proper example with GIC interrupt specifiers
- Schema validation support for device tree sources
The new schema enables:
- Validation improvement
tested with: make dt_binding_check DT_SCHEMA_FILES=...
All schema validation checks pass.
Signed-off-by: Pranav Kharche <pranavkharche7@gmail.com>
---
.../devicetree/bindings/media/hix5hd2-ir.txt | 26 ---------
.../devicetree/bindings/media/hix5hd2-ir.yaml | 53 +++++++++++++++++++
2 files changed, 53 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
deleted file mode 100644
index ca4cf774662e..000000000000
--- a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Device-Tree bindings for hix5hd2 ir IP
-
-Required properties:
- - compatible: Should contain "hisilicon,hix5hd2-ir", or:
- - "hisilicon,hi3796cv300-ir" for Hi3796CV300 IR device.
- - reg: Base physical address of the controller and length of memory
- mapped region.
- - interrupts: interrupt-specifier for the sole interrupt generated by
- the device. The interrupt specifier format depends on the interrupt
- controller parent.
- - clocks: clock phandle and specifier pair.
-
-Optional properties:
- - linux,rc-map-name: see rc.txt file in the same directory.
- - hisilicon,power-syscon: DEPRECATED. Don't use this in new dts files.
- Provide correct clocks instead.
-
-Example node:
-
- ir: ir@f8001000 {
- compatible = "hisilicon,hix5hd2-ir";
- reg = <0xf8001000 0x1000>;
- interrupts = <0 47 4>;
- clocks = <&clock HIX5HD2_IR_CLOCK>;
- linux,rc-map-name = "rc-tivo";
- };
diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml b/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
new file mode 100644
index 000000000000..91cba6ec88c5
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/hix5hd2-ir.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HiSilicon Hix5hd2 infrared remote controller
+
+maintainers:
+ - Pranav Kharche <pranavkharche7@gmail.com>
+
+allOf:
+ - $ref: rc.yaml#
+
+description: |
+ This binding describes the infrared remote controller found in
+ HiSilicon SoCs such as hix5hd2 and hi3796cv300.
+
+properties:
+ compatible:
+ enum:
+ - hisilicon,hix5hd2-ir
+ - hisilicon,hi3796cv300-ir
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ ir: ir@f8001000 {
+ compatible = "hisilicon,hix5hd2-ir";
+ reg = <0xf8001000 0x1000>;
+ interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clock 0>;
+ linux,rc-map-name = "rc-tivo";
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: media: convert hix5hd2-ir to DT schema
2026-03-28 8:42 ` [PATCH 1/1] " Pranav Kharche
@ 2026-03-29 9:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-29 9:45 UTC (permalink / raw)
To: Pranav Kharche
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Mauro Carvalho Chehab, linux-media, devicetree
On Sat, Mar 28, 2026 at 02:12:38PM +0530, Pranav Kharche wrote:
> Convert the legacy plaintext binding for HiSilicon hix5hd2 IR remote
> controller to JSON Schema (DT schema) format in YAML.
>
> This binding documents the infrared remote receiver found in HiSilicon
> SoCs such as hix5hd2 and hi3796cv300. The conversion includes:
>
> - Standardized property definitions with types and constraints
Drop
> - Reference to rc.yaml base schema for remote controller properties
Drop
> - Addition of include directives for interrupt-controller bindings
Drop
> - Proper example with GIC interrupt specifiers
Drop
> - Schema validation support for device tree sources
Drop
>
> The new schema enables:
> - Validation improvement
Drop
>
> tested with: make dt_binding_check DT_SCHEMA_FILES=...
> All schema validation checks pass.
Drop
Please write useful commit msgs, meaning you do not need to state
obvious things. Plenty of examples in git log.
What you MUST say here is documenting the changes you done to the
binding. You removed existing property which is not explained at all,
introduces undocumented ABI and adds new warnings. No, seriously, no.
And if you TESTED this you would see errors, so back to basic
requirements of schema conversion - see my posts on social.kernel.org.
>
> Signed-off-by: Pranav Kharche <pranavkharche7@gmail.com>
> ---
> .../devicetree/bindings/media/hix5hd2-ir.txt | 26 ---------
> .../devicetree/bindings/media/hix5hd2-ir.yaml | 53 +++++++++++++++++++
> 2 files changed, 53 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> deleted file mode 100644
> index ca4cf774662e..000000000000
> --- a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -Device-Tree bindings for hix5hd2 ir IP
> -
> -Required properties:
> - - compatible: Should contain "hisilicon,hix5hd2-ir", or:
> - - "hisilicon,hi3796cv300-ir" for Hi3796CV300 IR device.
> - - reg: Base physical address of the controller and length of memory
> - mapped region.
> - - interrupts: interrupt-specifier for the sole interrupt generated by
> - the device. The interrupt specifier format depends on the interrupt
> - controller parent.
> - - clocks: clock phandle and specifier pair.
> -
> -Optional properties:
> - - linux,rc-map-name: see rc.txt file in the same directory.
> - - hisilicon,power-syscon: DEPRECATED. Don't use this in new dts files.
> - Provide correct clocks instead.
> -
> -Example node:
> -
> - ir: ir@f8001000 {
> - compatible = "hisilicon,hix5hd2-ir";
> - reg = <0xf8001000 0x1000>;
> - interrupts = <0 47 4>;
> - clocks = <&clock HIX5HD2_IR_CLOCK>;
> - linux,rc-map-name = "rc-tivo";
> - };
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml b/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
> new file mode 100644
> index 000000000000..91cba6ec88c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.yaml
Filename must match the compatible, choose one.
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/hix5hd2-ir.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HiSilicon Hix5hd2 infrared remote controller
> +
> +maintainers:
> + - Pranav Kharche <pranavkharche7@gmail.com>
> +
> +allOf:
> + - $ref: rc.yaml#
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + This binding describes the infrared remote controller found in
So description describes that your binding describes... No, drop.
Explain the hardware and if you do not have any explanation, no need to
state obvious and paste here compatibles.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-29 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-28 8:42 [PATCH 0/1] dt-bindings: media: convert hix5hd2-ir to DT schema Pranav Kharche
2026-03-28 8:42 ` [PATCH 1/1] " Pranav Kharche
2026-03-29 9:45 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox