From: Krzysztof Kozlowski <krzk@kernel.org>
To: Khushal Chitturi <khushalchitturi@gmail.com>
Cc: sre@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ulli.kroll@googlemail.com,
linusw@kernel.org, daniel.baluta@nxp.com, simona.toaca@nxp.com,
d-gole@ti.com, m-chawdhry@ti.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: gemini: Rename power controller node to gemini-poweroff
Date: Mon, 30 Mar 2026 09:22:06 +0200 [thread overview]
Message-ID: <20260330-rough-military-saluki-e2dd8f@quoll> (raw)
In-Reply-To: <20260329205151.15161-3-khushalchitturi@gmail.com>
On Mon, Mar 30, 2026 at 02:21:51AM +0530, Khushal Chitturi wrote:
> Update the node name for the Cortina Gemini power controller from
> power-controller to gemini-poweroff since node "power controller" is
> reserved for power domain controller.
>
> Signed-off-by: Khushal Chitturi <khushalchitturi@gmail.com>
> ---
> arch/arm/boot/dts/gemini/gemini.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/gemini/gemini.dtsi b/arch/arm/boot/dts/gemini/gemini.dtsi
> index befe322bd7de..c524adadcf81 100644
> --- a/arch/arm/boot/dts/gemini/gemini.dtsi
> +++ b/arch/arm/boot/dts/gemini/gemini.dtsi
> @@ -228,7 +228,7 @@ intcon: interrupt-controller@48000000 {
> #interrupt-cells = <2>;
> };
>
> - power-controller@4b000000 {
> + gemini-poweroff@4b000000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
Why gemini is added here? It's not generic.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-30 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 20:51 [PATCH v2 0/2] dt-bindings: power: reset: cortina: Convert to DT schema and rename node Khushal Chitturi
2026-03-29 20:51 ` [PATCH v2 1/2] dt-bindings: power: reset: cortina,gemini-power-controller: convert to DT schema Khushal Chitturi
2026-03-30 7:21 ` Krzysztof Kozlowski
2026-03-29 20:51 ` [PATCH v2 2/2] ARM: dts: gemini: Rename power controller node to gemini-poweroff Khushal Chitturi
2026-03-30 7:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330-rough-military-saluki-e2dd8f@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=khushalchitturi@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m-chawdhry@ti.com \
--cc=robh@kernel.org \
--cc=simona.toaca@nxp.com \
--cc=sre@kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox