From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDB403D88F4; Mon, 30 Mar 2026 14:16:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774880186; cv=none; b=MRDX0/2usAiHul21RKnhCMZZ5wieeYjg8nGAb9Dn+7rIp0fokCF6HW3a/bh3S79sUHKC0HnDZNZKVYYmEG3C1vLOG+yDjJFKtXp6AnwfIkH1/OEXtw13Kac2wZczX7n7dsIN1IsYp2quZuyo2RVflyeZhH3ub2Ysqt6+VE6+ZVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774880186; c=relaxed/simple; bh=OZwA9LX64oU0rjcQ/xGojr0ysWNIRLqBgjf2L9V8WS8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bqCxzIln29ZdVRNdXNCFGHC9Dqlmp45a6mr91DZreIPzxcLyLvob8UnEoRfBP4tpLbyR3xt3Gx6FJFann/ZlGxwiYPr3F6iVbpU/2fjhy0OMurqLD/k7HjRCIVVSgrjEqlPnVgHE8KAON7yUgL9u11Heq5SN0jfaTc+Bsy7vW+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AnzLTqSW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AnzLTqSW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85151C4CEF7; Mon, 30 Mar 2026 14:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774880186; bh=OZwA9LX64oU0rjcQ/xGojr0ysWNIRLqBgjf2L9V8WS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AnzLTqSW3JI4wm0Gcq8Shu/IGh0tUhJLNhnPe/4fMS1BQvFXwLkqaFavjRkMTg+ke 35GfCFAZzvJVdPppri8AkN54iXVQybARLeaZU3XtOzFYGGeQcJsFcdKLCWHylHTggF 2o9PG2Qe+35r+OzCRD17BB6yZ4zgqp4t7+rZIv2f/1Z88jYu1xxAveqnKYu8pwJBbK KrWMwPXEJ8SLXIe5Da4Wvbozat4m6eZQHT2DSKLXaVq/0AqkESQ6cylwCNQsRV8TXw Qwv7cajU/bVi6RqCmse5cHQDJVFwZI7/D8410l65KmIC9kwa88S/xFl9cRRRTOgY2k drY3J7QcDRXsw== Date: Mon, 30 Mar 2026 16:16:21 +0200 From: Nathan Chancellor To: Rob Herring Cc: Saravana Kannan , Nick Desaulniers , Bill Wendling , Justin Stitt , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] scripts/dtc: Remove unused dts_version in dtc-lexer.l Message-ID: <20260330141621.GB1990358@ax162> References: <20260327-dtc-drop-dts_version-v1-1-41066690aefd@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 30, 2026 at 07:19:16AM -0500, Rob Herring wrote: > On Fri, Mar 27, 2026 at 4:39 PM Nathan Chancellor wrote: > > > > A recent strengthening of -Wunused-but-set-variable (enabled with -Wall) > > in clang under a new subwarning, -Wunused-but-set-global, points out an > > unused static global variable in dtc-lexer.lex.c (compiled from > > dtc-lexer.l): > > > > scripts/dtc/dtc-lexer.lex.c:641:12: warning: variable 'dts_version' set but not used [-Wunused-but-set-global] > > 641 | static int dts_version = 1; > > | ^ > > > > This variable has been unused since commit 658f29a51e98 ("of/flattree: > > Update dtc to current mainline."). Remove it to clear up the warning. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Nathan Chancellor > > --- > > This is commit 53373d1 ("dtc: Remove unused dts_version in dtc-lexer.l") > > in upstream dtc. I sent it separately to make it easier to backport to > > stable, along with updating the warning and hash to match the kernel's > > version. > > --- > > scripts/dtc/dtc-lexer.l | 3 --- > > 1 file changed, 3 deletions(-) > > We don't take changes to dtc as we just sync with the upstream copy. I > saw you already submitted this upstream, so I will do a sync to pull > this in. Fair enough. As I mentioned in the fold, I will need this in stable so I figured having a separate patch would make that easier while not impacting a future sync (since it is already there). I can just wait to send this to stable directly until the sync lands in Linus's tree. Cheers, Nathan