From: Jakub Kicinski <kuba@kernel.org>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Aleksander Jan Bajkowski <olek2@wp.pl>,
Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor+dt@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Ivan Galkin <ivan.galkin@axis.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Klein <michael@fossekall.de>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
devicetree@vger.kernel.org
Subject: Re: [net-next,PATCH v5 3/3] net: phy: realtek: Add property to enable SSC
Date: Mon, 30 Mar 2026 18:57:21 -0700 [thread overview]
Message-ID: <20260330185721.4b94ed30@kernel.org> (raw)
In-Reply-To: <20260326210704.58912-3-marek.vasut@mailbox.org>
On Thu, 26 Mar 2026 22:06:35 +0100 Marek Vasut wrote:
> +/* RTL8211F SSC settings */
> +#define RTL8211F_SSC_PAGE 0xc44
> +#define RTL8211F_SSC_RXC 0x13
> +#define RTL8211F_SSC_SYSCLK 0x17
> +#define RTL8211F_SSC_CLKOUT 0x19
> + /* Unnamed registers from EMI improvement parameters application note 1.2 */
> + ret = phy_write_paged(phydev, 0xd09, 0x10, 0xcf00);
> + if (ret < 0) {
> + dev_err(dev, "CLKOUT SSC initialization failed: %pe\n", ERR_PTR(ret));
> + return ret;
> + }
> +
> + ret = phy_write(phydev, RTL8211F_SSC_CLKOUT, 0x38c3);
> + if (ret < 0) {
> + dev_err(dev, "CLKOUT SSC configuration failed: %pe\n", ERR_PTR(ret));
> + return ret;
> + }
AI flags that this, did you mean to write to the SSC_PAGE here?
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-31 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 21:06 [net-next,PATCH v5 1/3] dt-bindings: net: realtek,rtl82xx: Keep property list sorted Marek Vasut
2026-03-26 21:06 ` [net-next,PATCH v5 2/3] dt-bindings: net: realtek,rtl82xx: Document realtek,*-ssc-enable property Marek Vasut
2026-03-26 21:06 ` [net-next,PATCH v5 3/3] net: phy: realtek: Add property to enable SSC Marek Vasut
2026-03-31 1:57 ` Jakub Kicinski [this message]
2026-04-05 21:46 ` Marek Vasut
2026-04-05 20:23 ` Aleksander Jan Bajkowski
2026-04-05 21:59 ` Marek Vasut
2026-04-06 9:06 ` Aleksander Jan Bajkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330185721.4b94ed30@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ivan.galkin@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.vasut@mailbox.org \
--cc=michael@fossekall.de \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox