Re: [RFC uL PATCH 2/2] mux-controller: ti: add driver for event mux router

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 30, 2026 at 11:02:11AM +0530, rahul sharma wrote:
> CC: Greg Kroah-Hartman
> 
> Hi Greg,
> 
> Could you please review this patch(2nd one in the series). It seems Peter is
> not online for almost a month.

But I am not the mux maintainer, so I am probably not the best one to
review it :(

One instant comment though:

> On 13/03/26 11:34, Rahul Sharma wrote:
> > The driver supports event muxing routers like gpio mux router and timesync
> > router. This driver is adaptation of original reg-mux driver, along with
> > changes specific to support TI's mux router.
> > 
> > The idle states this driver supports are only 2 which active(represented
> > by 1 in dt-node) and in-active(represented by 0 in dt-node).
> > 
> > Signed-off-by: Rahul Sharma <r-sharma3@ti.com>
> > ---
> >   drivers/mux/Kconfig           |  15 +++
> >   drivers/mux/Makefile          |   2 +
> >   drivers/mux/ti-k3-event-mux.c | 235 ++++++++++++++++++++++++++++++++++
> >   3 files changed, 252 insertions(+)
> >   create mode 100644 drivers/mux/ti-k3-event-mux.c
> > 
> > diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
> > index c68132e38138..ad3af2724d28 100644
> > --- a/drivers/mux/Kconfig
> > +++ b/drivers/mux/Kconfig
> > @@ -59,4 +59,19 @@ config MUX_MMIO
> >   	  To compile the driver as a module, choose M here: the module will
> >   	  be called mux-mmio.
> > +config MUX_TI_K3_EVENT_ROUTER
> > +	tristate "TI Event Mux Router using MMIO registers"
> > +	depends on OF && (REGMAP_MMIO || COMPILE_TEST)
> > +	help
> > +	  This is extension of MMIO mux for  timesync router and gpiomux
> > +	  routers on TI K3 SoCs. This driver supports the 3-field format for
> > +	  mux control: <register-offset mask value>.
> > +
> > +	  The driver allows configuration of hardware mux routers using
> > +	  memory-mapped registers. It's based on the mmio-mux driver but
> > +	  supports the extended 3-field format for more precise control.
> > +
> > +	  To compile the driver as a module, choose M here: the module will
> > +	  be called mux-ti-k3-event.
> > +

Don't you need a blank line before your new config option?

thanks,

greg k-h